Removing maskInputs for general settings (#21)

* removing maskInputs for general settings
Azure · Dec 2, 2020 · 1808c4f · 1808c4f
1 parent cc5dcad
commit 1808c4f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/lib/Utils.js b/lib/Utils.js
@@ -12,7 +12,7 @@ class Utils {
     static validateSettings(customSettings, maskInputs) {
         try {
             var customParsedSettings = JSON.parse(customSettings);
-            if (maskInputs !== "false") {
+            if (maskInputs !== undefined && maskInputs !== "false") {
                 Utils.maskValues(customParsedSettings);
             }
             return customParsedSettings;

diff --git a/lib/main.js b/lib/main.js
@@ -59,7 +59,7 @@ function main() {
                 yield appServiceUtility.updateConnectionStrings(customConnectionStrings);
             }
             if (ConfigurationSettings) {
-                let customConfigurationSettings = Utils_1.Utils.validateSettings(ConfigurationSettings, maskInputs);
+                let customConfigurationSettings = Utils_1.Utils.validateSettings(ConfigurationSettings);
                 yield appServiceUtility.updateConfigurationSettings(customConfigurationSettings);
             }
             applicationURL = yield appServiceUtility.getApplicationURL();

diff --git a/src/Utils.ts b/src/Utils.ts
@@ -1,10 +1,10 @@
 import * as core from '@actions/core';
 
 export class Utils {
-    static validateSettings(customSettings: string, maskInputs: string) {
+    static validateSettings(customSettings: string, maskInputs?: string) {
         try {
             var customParsedSettings = JSON.parse(customSettings);
-            if (maskInputs !== "false") {
+            if (maskInputs !== undefined && maskInputs !== "false") {
                 Utils.maskValues(customParsedSettings);
             }
             return customParsedSettings;

diff --git a/src/main.ts b/src/main.ts
@@ -53,7 +53,7 @@ async function main() {
         }
 
         if(ConfigurationSettings) {
-            let customConfigurationSettings = Utils.validateSettings(ConfigurationSettings, maskInputs);
+            let customConfigurationSettings = Utils.validateSettings(ConfigurationSettings);
             await appServiceUtility.updateConfigurationSettings(customConfigurationSettings);
         }