Skip to content

Update generation to write ModelReaderWriterBuildableAttributes for all IPersistableModels consumed #5366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
live1206 merged 25 commits into from
Jul 23, 2025
Merged

Update generation to write ModelReaderWriterBuildableAttributes for all IPersistableModels consumed #5366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
53967a3
Initial plan
Copilot Jul 15, 2025
727588a
Update generation to write ModelReaderWriterBuildableAttributes for I…
Copilot Jul 15, 2025
6941e79
Add unit tests for ModelReaderWriterBuildableAttributesWriter
Copilot Jul 15, 2025
f695942
Improve ModelReaderWriterBuildableAttributesWriter implementation
Copilot Jul 15, 2025
847267a
Move ModelReaderWriterBuildableAttributes to Context class instead of…
Copilot Jul 15, 2025
db00f6e
Update ModelReaderWriterBuildableAttributes to be class-level instead…
Copilot Jul 15, 2025
cc2704e
Resolve merge conflict and sync with main
Copilot Jul 18, 2025
f45eaa1
Improve ModelReaderWriterBuildableAttributes algorithm with better IP…
Copilot Jul 18, 2025
9761bcc
update algo
m-nash Jul 19, 2025
89b8cdc
Update PostProcessor to handle invalid attributes similar to TypeSpec…
Copilot Jul 21, 2025
46409ac
- remove `RemoveInvalidUsings` in postProcessor since it's not working
live1206 Jul 21, 2025
34ba279
remove buildable attributes for internal models and add resources to …
live1206 Jul 21, 2025
248699e
typo
live1206 Jul 21, 2025
e02c35c
typo
live1206 Jul 21, 2025
96541bb
update logic to not fail for azure identity
m-nash Jul 21, 2025
5fb929c
regen after changes
m-nash Jul 21, 2025
9a6de48
Revert use-model-reader-writer settings from readme.md files as they …
Copilot Jul 21, 2025
ce48baf
regen
JoshLove-msft Jul 21, 2025
f1bc169
regen
JoshLove-msft Jul 21, 2025
4a0457d
Add ResourceData and base type property types to buildable types
live1206 Jul 22, 2025
f887f29
regen
live1206 Jul 22, 2025
d3a24cd
fix tests
live1206 Jul 22, 2025
7d14cd9
- Skip internal models from buildable types
live1206 Jul 22, 2025
5351d96
skip MRWContext from reference map builder
live1206 Jul 22, 2025
8e69559
keep leading trivia to keep xml docs
live1206 Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
9 changes: 5 additions & 4 deletions Packages.Data.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,11 @@

<!-- All csproj dependencies. -->
<ItemGroup>
<PackageReference Update="Azure.Core" Version="1.47.0" />
<PackageReference Update="Azure.Core" Version="1.47.1" />
<PackageReference Update="Azure.Core.Experimental" Version="0.1.0-preview.18" />
<PackageReference Update="Azure.Core.Expressions.DataFactory" Version="1.0.0" />
<PackageReference Update="Azure.ResourceManager" Version="1.14.0-beta.1" />
<PackageReference Update="Azure.Identity" Version="1.14.2" />
<PackageReference Update="Azure.ResourceManager" Version="1.13.2" />
<PackageReference Update="CommandLineParser" Version="2.9.1" />
<PackageReference Update="Humanizer.Core" Version="2.13.14" />
<PackageReference Update="Microsoft.AspNetCore.Server.Kestrel" Version="2.2.0" />
Expand All @@ -49,9 +50,9 @@
<PackageReference Update="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.1.0" />
<PackageReference Update="NuGet.Configuration" Version="6.8.0" />
<PackageReference Update="NUnit" Version="3.13.2" />
<PackageReference Update="System.ClientModel" Version="1.5.0" />
<PackageReference Update="System.ClientModel" Version="1.5.1" />
<PackageReference Update="System.Diagnostics.DiagnosticSource" Version="8.0.0" />
<PackageReference Update="System.Memory" Version="4.5.4" />
<PackageReference Update="System.Memory" Version="4.5.5" />
<PackageReference Update="System.Text.Json" Version="8.0.5" />
<PackageReference Update="YamlDotNet" Version="11.2.1" />
</ItemGroup>
Expand Down
24 changes: 24 additions & 0 deletions samples/AnomalyDetector/src/Generated/Models/AnomalyDetectorContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,37 @@
#nullable disable

using System.ClientModel.Primitives;
using AnomalyDetector.Models;

namespace AnomalyDetector
{
/// <summary>
/// Context class which will be filled in by the System.ClientModel.SourceGeneration.
/// For more information see 'https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/System.ClientModel/src/docs/ModelReaderWriterContext.md'
/// </summary>
[ModelReaderWriterBuildable(typeof(AlignPolicy))]
[ModelReaderWriterBuildable(typeof(AnomalyDetectionModel))]
[ModelReaderWriterBuildable(typeof(AnomalyInterpretation))]
[ModelReaderWriterBuildable(typeof(AnomalyState))]
[ModelReaderWriterBuildable(typeof(AnomalyValue))]
[ModelReaderWriterBuildable(typeof(CorrelationChanges))]
[ModelReaderWriterBuildable(typeof(DiagnosticsInfo))]
[ModelReaderWriterBuildable(typeof(ErrorResponse))]
[ModelReaderWriterBuildable(typeof(ModelInfo))]
[ModelReaderWriterBuildable(typeof(ModelState))]
[ModelReaderWriterBuildable(typeof(MultivariateBatchDetectionOptions))]
[ModelReaderWriterBuildable(typeof(MultivariateBatchDetectionResultSummary))]
[ModelReaderWriterBuildable(typeof(MultivariateDetectionResult))]
[ModelReaderWriterBuildable(typeof(MultivariateLastDetectionOptions))]
[ModelReaderWriterBuildable(typeof(MultivariateLastDetectionResult))]
[ModelReaderWriterBuildable(typeof(TimeSeriesPoint))]
[ModelReaderWriterBuildable(typeof(UnivariateChangePointDetectionOptions))]
[ModelReaderWriterBuildable(typeof(UnivariateChangePointDetectionResult))]
[ModelReaderWriterBuildable(typeof(UnivariateDetectionOptions))]
[ModelReaderWriterBuildable(typeof(UnivariateEntireDetectionResult))]
[ModelReaderWriterBuildable(typeof(UnivariateLastDetectionResult))]
[ModelReaderWriterBuildable(typeof(VariableState))]
[ModelReaderWriterBuildable(typeof(VariableValues))]
public partial class AnomalyDetectorContext : ModelReaderWriterContext
{
}
Expand Down
166 changes: 166 additions & 0 deletions ...le.ResourceManager.Sample/src/Generated/Models/AzureSampleResourceManagerSampleContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,179 @@
#nullable disable

using System.ClientModel.Primitives;
using Azure.ResourceManager.Models;
using AzureSample.ResourceManager.Sample.Models;

namespace AzureSample.ResourceManager.Sample
{
/// <summary>
/// Context class which will be filled in by the System.ClientModel.SourceGeneration.
/// For more information see 'https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/System.ClientModel/src/docs/ModelReaderWriterContext.md'
/// </summary>
[ModelReaderWriterBuildable(typeof(AdditionalUnattendContent))]
[ModelReaderWriterBuildable(typeof(ApiError))]
[ModelReaderWriterBuildable(typeof(ApiErrorBase))]
[ModelReaderWriterBuildable(typeof(AutomaticOSUpgradePolicy))]
[ModelReaderWriterBuildable(typeof(AutomaticRepairsPolicy))]
[ModelReaderWriterBuildable(typeof(AvailabilitySetData))]
[ModelReaderWriterBuildable(typeof(AvailabilitySetListResult))]
[ModelReaderWriterBuildable(typeof(AvailabilitySetPatch))]
[ModelReaderWriterBuildable(typeof(AvailabilitySetResource))]
[ModelReaderWriterBuildable(typeof(AvailablePatchSummary))]
[ModelReaderWriterBuildable(typeof(AzureSampleResourceManagerSamplePlan))]
[ModelReaderWriterBuildable(typeof(AzureSampleResourceManagerSampleSku))]
[ModelReaderWriterBuildable(typeof(AzureSampleResourceManagerSampleUsage))]
[ModelReaderWriterBuildable(typeof(AzureSampleResourceManagerSampleUsageName))]
[ModelReaderWriterBuildable(typeof(BootDiagnostics))]
[ModelReaderWriterBuildable(typeof(BootDiagnosticsInstanceView))]
[ModelReaderWriterBuildable(typeof(DataDisk))]
[ModelReaderWriterBuildable(typeof(DataDiskImage))]
[ModelReaderWriterBuildable(typeof(DedicatedHostAllocatableVm))]
[ModelReaderWriterBuildable(typeof(DedicatedHostData))]
[ModelReaderWriterBuildable(typeof(DedicatedHostGroupData))]
[ModelReaderWriterBuildable(typeof(DedicatedHostGroupListResult))]
[ModelReaderWriterBuildable(typeof(DedicatedHostGroupPatch))]
[ModelReaderWriterBuildable(typeof(DedicatedHostGroupResource))]
[ModelReaderWriterBuildable(typeof(DedicatedHostInstanceView))]
[ModelReaderWriterBuildable(typeof(DedicatedHostInstanceViewWithName))]
[ModelReaderWriterBuildable(typeof(DedicatedHostListResult))]
[ModelReaderWriterBuildable(typeof(DedicatedHostPatch))]
[ModelReaderWriterBuildable(typeof(DedicatedHostResource))]
[ModelReaderWriterBuildable(typeof(DiffDiskSettings))]
[ModelReaderWriterBuildable(typeof(DiskEncryptionSettings))]
[ModelReaderWriterBuildable(typeof(DiskInstanceView))]
[ModelReaderWriterBuildable(typeof(ImageData))]
[ModelReaderWriterBuildable(typeof(ImageDataDisk))]
[ModelReaderWriterBuildable(typeof(ImageDisk))]
[ModelReaderWriterBuildable(typeof(ImageListResult))]
[ModelReaderWriterBuildable(typeof(ImageOSDisk))]
[ModelReaderWriterBuildable(typeof(ImagePatch))]
[ModelReaderWriterBuildable(typeof(ImageReference))]
[ModelReaderWriterBuildable(typeof(ImageResource))]
[ModelReaderWriterBuildable(typeof(ImageStorageProfile))]
[ModelReaderWriterBuildable(typeof(InnerError))]
[ModelReaderWriterBuildable(typeof(InstanceViewStatus))]
[ModelReaderWriterBuildable(typeof(KeyVaultKeyReference))]
[ModelReaderWriterBuildable(typeof(KeyVaultSecretReference))]
[ModelReaderWriterBuildable(typeof(LastPatchInstallationSummary))]
[ModelReaderWriterBuildable(typeof(LinuxConfiguration))]
[ModelReaderWriterBuildable(typeof(ListUsagesResult))]
[ModelReaderWriterBuildable(typeof(LogAnalytics))]
[ModelReaderWriterBuildable(typeof(LogAnalyticsInputBase))]
[ModelReaderWriterBuildable(typeof(MaintenanceRedeployStatus))]
[ModelReaderWriterBuildable(typeof(ManagedDiskParameters))]
[ModelReaderWriterBuildable(typeof(NetworkInterfaceReference))]
[ModelReaderWriterBuildable(typeof(OrchestrationServiceStateContent))]
[ModelReaderWriterBuildable(typeof(OrchestrationServiceSummary))]
[ModelReaderWriterBuildable(typeof(OSDisk))]
[ModelReaderWriterBuildable(typeof(OSProfile))]
[ModelReaderWriterBuildable(typeof(ProximityPlacementGroupData))]
[ModelReaderWriterBuildable(typeof(ProximityPlacementGroupListResult))]
[ModelReaderWriterBuildable(typeof(ProximityPlacementGroupPatch))]
[ModelReaderWriterBuildable(typeof(ProximityPlacementGroupResource))]
[ModelReaderWriterBuildable(typeof(PurchasePlan))]
[ModelReaderWriterBuildable(typeof(RecoveryWalkResponse))]
[ModelReaderWriterBuildable(typeof(RequestRateByIntervalContent))]
[ModelReaderWriterBuildable(typeof(RetrieveBootDiagnosticsDataResult))]
[ModelReaderWriterBuildable(typeof(RollbackStatusInfo))]
[ModelReaderWriterBuildable(typeof(RollingUpgradePolicy))]
[ModelReaderWriterBuildable(typeof(RollingUpgradeProgressInfo))]
[ModelReaderWriterBuildable(typeof(RollingUpgradeRunningStatus))]
[ModelReaderWriterBuildable(typeof(SshPublicKeyData))]
[ModelReaderWriterBuildable(typeof(SshPublicKeyGenerateKeyPairResult))]
[ModelReaderWriterBuildable(typeof(SshPublicKeyInfo))]
[ModelReaderWriterBuildable(typeof(SshPublicKeyPatch))]
[ModelReaderWriterBuildable(typeof(SshPublicKeyResource))]
[ModelReaderWriterBuildable(typeof(SshPublicKeysGroupListResult))]
[ModelReaderWriterBuildable(typeof(StorageProfile))]
[ModelReaderWriterBuildable(typeof(SubResource))]
[ModelReaderWriterBuildable(typeof(SubResourceReadOnly))]
[ModelReaderWriterBuildable(typeof(SubResourceWithColocationStatus))]
[ModelReaderWriterBuildable(typeof(SubscriptionResourceGetVirtualMachineImagesOptions))]
[ModelReaderWriterBuildable(typeof(SystemData))]
[ModelReaderWriterBuildable(typeof(TerminateNotificationProfile))]
[ModelReaderWriterBuildable(typeof(ThrottledRequestsContent))]
[ModelReaderWriterBuildable(typeof(UpdateResource))]
[ModelReaderWriterBuildable(typeof(UpgradeOperationHistoricalStatusInfo))]
[ModelReaderWriterBuildable(typeof(UpgradeOperationHistoricalStatusInfoProperties))]
[ModelReaderWriterBuildable(typeof(UpgradeOperationHistoryStatus))]
[ModelReaderWriterBuildable(typeof(UpgradePolicy))]
[ModelReaderWriterBuildable(typeof(VaultCertificate))]
[ModelReaderWriterBuildable(typeof(VaultSecretGroup))]
[ModelReaderWriterBuildable(typeof(VirtualMachineAgentInstanceView))]
[ModelReaderWriterBuildable(typeof(VirtualMachineAssessPatchesResult))]
[ModelReaderWriterBuildable(typeof(VirtualMachineCaptureContent))]
[ModelReaderWriterBuildable(typeof(VirtualMachineCaptureResult))]
[ModelReaderWriterBuildable(typeof(VirtualMachineData))]
[ModelReaderWriterBuildable(typeof(VirtualMachineExtensionData))]
[ModelReaderWriterBuildable(typeof(VirtualMachineExtensionHandlerInstanceView))]
[ModelReaderWriterBuildable(typeof(VirtualMachineExtensionImageData))]
[ModelReaderWriterBuildable(typeof(VirtualMachineExtensionImageResource))]
[ModelReaderWriterBuildable(typeof(VirtualMachineExtensionInstanceView))]
[ModelReaderWriterBuildable(typeof(VirtualMachineExtensionResource))]
[ModelReaderWriterBuildable(typeof(VirtualMachineExtensionUpdate))]
[ModelReaderWriterBuildable(typeof(VirtualMachineImage))]
[ModelReaderWriterBuildable(typeof(VirtualMachineImageResource))]
[ModelReaderWriterBuildable(typeof(VirtualMachineInstanceView))]
[ModelReaderWriterBuildable(typeof(VirtualMachineListResult))]
[ModelReaderWriterBuildable(typeof(VirtualMachinePatch))]
[ModelReaderWriterBuildable(typeof(VirtualMachinePatchStatus))]
[ModelReaderWriterBuildable(typeof(VirtualMachineReimageContent))]
[ModelReaderWriterBuildable(typeof(VirtualMachineResource))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetData))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetDataDisk))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetExtensionData))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetExtensionListResult))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetExtensionPatch))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetExtensionProfile))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetExtensionResource))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetInstanceView))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetIPConfiguration))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetIPTag))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetListOSUpgradeHistory))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetListResult))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetListSkusResult))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetListWithLinkResult))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetManagedDiskParameters))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetNetworkConfiguration))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetNetworkProfile))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetOSDisk))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetOSProfile))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetPatch))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetPublicIPAddressConfiguration))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetReimageContent))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetResource))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetRollingUpgradeData))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetRollingUpgradeResource))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetSku))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetSkuCapacity))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetStorageProfile))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdateIPConfiguration))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdateNetworkConfiguration))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdateNetworkProfile))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdateOSDisk))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdateOSProfile))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdatePublicIPAddressConfiguration))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdateStorageProfile))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdateVmProfile))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVirtualMachineExtensionResource))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmData))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmExtensionsSummary))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmInstanceIds))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmInstanceRequiredIds))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmInstanceView))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmListResult))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmProfile))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmProtectionPolicy))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmReimageContent))]
[ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmResource))]
[ModelReaderWriterBuildable(typeof(VirtualMachineSize))]
[ModelReaderWriterBuildable(typeof(VirtualMachineSizeListResult))]
[ModelReaderWriterBuildable(typeof(VirtualMachineSoftwarePatchProperties))]
[ModelReaderWriterBuildable(typeof(VirtualMachineStatusCodeCount))]
[ModelReaderWriterBuildable(typeof(VmScaleSetConvertToSinglePlacementGroupContent))]
[ModelReaderWriterBuildable(typeof(WindowsConfiguration))]
[ModelReaderWriterBuildable(typeof(WinRMListener))]
public partial class AzureSampleResourceManagerSampleContext : ModelReaderWriterContext
{
}
Expand Down
4 changes: 2 additions & 2 deletions ...Generated/AzureSampleResourceManagerStoragePrivateEndpointConnectionData.Serialization.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion samples/AzureSample.ResourceManager.Storage/src/Generated/BlobContainerData.Serialization.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...zureSample.ResourceManager.Storage/src/Generated/BlobInventoryPolicyData.Serialization.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion samples/AzureSample.ResourceManager.Storage/src/Generated/BlobServiceData.Serialization.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...les/AzureSample.ResourceManager.Storage/src/Generated/DeletedAccountData.Serialization.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading