-
Notifications
You must be signed in to change notification settings - Fork 1.4k
{Dependency-map} Initial release for dependency-map
#8797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Validation for Breaking Change Starting...
Thanks for your contribution! |
Hi @AllyW, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces the initial release of the DependencyMap extension for Azure CLI, with auto‑generated commands to create, update, delete, export, and display dependency map resources.
- Adds core command implementations for dependency map management, including discovery, creation, deletion, and export operations.
- Introduces supporting modules and helper files for integrating with Azure management endpoints.
Reviewed Changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/dependency-map/azext_dependency_map/aaz/latest/dependency_map/_list.py | Implements listing commands with conditional logic based on resource group presence. |
Other files | Auto‑generated command modules and helpers for managing dependency map resources. |
|
||
def _execute_operations(self): | ||
self.pre_operations() | ||
condition_0 = has_value(self.ctx.subscription_id) and has_value(self.ctx.args.resource_group) is not True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider rewriting the condition to 'has_value(self.ctx.subscription_id) and not has_value(self.ctx.args.resource_group)' for improved readability.
condition_0 = has_value(self.ctx.subscription_id) and has_value(self.ctx.args.resource_group) is not True | |
condition_0 = has_value(self.ctx.subscription_id) and not has_value(self.ctx.args.resource_group) |
Copilot uses AI. Check for mistakes.
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
[Release] Update index.json for extension [ dependency-map-1.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=126641150&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.aaz: Azure/aaz#771