fix: Handle non-tty scenario correctly for aks agent evals #9275
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @nilo19, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
FumingZhang,
yanzhudd,
yonzhan and
zhoxing-ms
There was a problem hiding this comment.
Pull Request Overview
This PR fixes stdin reading issues in CI/CD pipelines for the AKS agent by implementing timeout protection and proper non-interactive mode handling. It also updates the test framework with better debugging capabilities and addresses deprecation warnings.
- Fixes stdin reading hang in non-interactive environments using select with timeout
- Improves test framework with real-time output visibility and subprocess timeouts
- Updates pytest configuration and addresses datetime deprecation warnings
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/aks-agent/setup.cfg | Adds pytest marker registration for AKS agent evaluation test categories |
| src/aks-agent/azext_aks_agent/tests/evals/test_ask_agent.py | Enhances test framework with real-time logging, subprocess timeouts, and replaces deprecated datetime.utcnow() |
| src/aks-agent/azext_aks_agent/agent/agent.py | Implements select-based timeout protection for stdin reading to prevent hangs in CI/CD |
|
Hi @nilo19 Release SuggestionsModule: aks-agent
Notes
|
|
@yonzhan can I have an update? |
| # Check if data is available with 100ms timeout | ||
| if select.select([sys.stdin], [], [], 0.1)[0]: | ||
| piped_data = sys.stdin.read().strip() | ||
| console.print( |
| # as it may hang in CI/CD environments. Only read stdin if: | ||
| # 1. Not a TTY (indicating piped input) | ||
| # 2. Interactive mode is enabled (allows stdin reading) | ||
| should_check_stdin = not sys.stdin.isatty() and interactive |
There was a problem hiding this comment.
Is our eval pipeline failure related to this change?
There was a problem hiding this comment.
related to another pipeline failure
5 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks agent
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.