Skip to content

Conversation

MuhammadAliFleet
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

This PR increases the delay in role assignment creation. Previously, the private fleet creation was flaky due to the role assignment not being propagated in time.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 06:14
Copy link

azure-client-tools-bot-prd bot commented Oct 9, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the delay in role assignment creation to fix flaky behavior in private fleet creation where role assignments weren't propagating in time.

  • Added a 3-second delay parameter to the add_role_assignment function call
  • Updated version from 1.7.0 to 1.7.1
  • Added corresponding HISTORY.rst entry

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/fleet/setup.py Version bump from 1.7.0 to 1.7.1
src/fleet/azext_fleet/_helpers.py Added delay=3 parameter to role assignment function
src/fleet/HISTORY.rst Added changelog entry for version 1.7.1

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 9, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Oct 9, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link

github-actions bot commented Oct 9, 2025

@MuhammadAliFleet MuhammadAliFleet force-pushed the alimuhammad/fleet/inc-delay-roleassignment branch from c6c75ba to 044a407 Compare October 10, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants