-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Andrhan12/ssh auth changes #9293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…into andrhan12/ssh-auth-changes
…into andrhan12/ssh-auth-changes
Validation for Breaking Change Starting...
Thanks for your contribution! |
Hi @andrhan12, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the SSH extension to version 2.0.7 with authentication changes for Azure Arc connectivity. The changes improve support for airgapped clouds by dynamically constructing endpoint URLs and updating the client proxy version.
- Updates the SSH extension version from 2.0.6 to 2.0.7
- Adds dynamic endpoint URL construction for airgapped Azure clouds
- Updates client proxy version and modifies MCR target configuration
- Updates function signatures to pass
cmd
parameter for cloud context access
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
setup.py | Version bump from 2.0.6 to 2.0.7 |
custom.py | Adds dynamic scope generation for airgapped clouds and updates proxy installation call |
constants.py | Updates client proxy version and removes MCR prefix from target |
connectivity_utils.py | Adds dynamic MCR URL construction and updates function signature |
test_custom.py | Updates test mocks to include cloud endpoints and fixes function call signatures |
test_connectivity_utils.py | Updates test to include cmd parameter and cloud endpoint mocks |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Adding in auth changes for ssh extension to handle air gapped cloud environments for the CLI module.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.