Skip to content

Conversation

andrhan12
Copy link

@andrhan12 andrhan12 commented Oct 12, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Adding in auth changes for ssh extension to handle air gapped cloud environments for the CLI module.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Copilot Copilot AI review requested due to automatic review settings October 12, 2025 22:50
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

Copy link

Hi @andrhan12,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 12, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the SSH extension to version 2.0.7 with authentication changes for Azure Arc connectivity. The changes improve support for airgapped clouds by dynamically constructing endpoint URLs and updating the client proxy version.

  • Updates the SSH extension version from 2.0.6 to 2.0.7
  • Adds dynamic endpoint URL construction for airgapped Azure clouds
  • Updates client proxy version and modifies MCR target configuration
  • Updates function signatures to pass cmd parameter for cloud context access

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
setup.py Version bump from 2.0.6 to 2.0.7
custom.py Adds dynamic scope generation for airgapped clouds and updates proxy installation call
constants.py Updates client proxy version and removes MCR prefix from target
connectivity_utils.py Adds dynamic MCR URL construction and updates function signature
test_custom.py Updates test mocks to include cloud endpoints and fixes function call signatures
test_connectivity_utils.py Updates test to include cmd parameter and cloud endpoint mocks

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Oct 12, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 12, 2025
@yonzhan yonzhan requested review from jiasli and jsntcy October 13, 2025 02:01
@yonzhan yonzhan requested a review from evelyn-ys October 13, 2025 02:01
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants