-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CLI Refresh for Elastic (2025-06-01) #9309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌Azure CLI Extensions Breaking Change Test
|
Hi @jkore1911, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Elastic CLI extension to a newer service/API version (2025-06-01), raises the minimum Azure CLI core version, and introduces new commands and schema fields for expanded Elastic monitor and integration functionality.
- Bumps api-version across all Elastic commands from 2024-06-15-preview to 2025-06-01 and updates azext.minCliCoreVersion.
- Adds new commands (e.g., get-status, list-monitored-resource, vm-collection-update, get-elastic-organization-to-azure-subscription-mapping) and extends monitor resource schemas (kind, hostingType, projectDetails).
- Adjusts test file by commenting out previously executed upgrade and traffic filter association steps (reducing test coverage).
Reviewed Changes
Copilot reviewed 51 out of 55 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
src/elastic/azext_elastic/tests/latest/test_elastic_scenario.py | Adjusts imports and comments out several test steps tied to upgrade and filter creation. |
src/elastic/azext_elastic/azext_metadata.json | Increases min CLI core version to 2.75.0 to match new API requirements. |
tag_rule/_wait.py | Updates api-version to 2025-06-01 for wait operation. |
tag_rule/_update.py | Updates api-version and docstring example; version metadata bumped. |
tag_rule/_show.py | Updates api-version and example usage. |
tag_rule/_list.py | Updates api-version and example; resource path version bumped. |
tag_rule/_delete.py | Updates api-version and example usage. |
tag_rule/_create.py | Updates api-version and example usage. |
open_ai_integration/_update.py | Updates api-version; modifies argument options and example. |
open_ai_integration/_show.py | Updates api-version metadata. |
open_ai_integration/_list.py | Updates api-version metadata. |
open_ai_integration/_get_status.py | Adds new get-status command implementation. |
open_ai_integration/_delete.py | Updates api-version metadata. |
open_ai_integration/_create.py | Updates api-version metadata; adjusts endpoint option aliases. |
open_ai_integration/init.py | Adds new import; retains legacy misspelled import. |
monitored_subscription/_wait.py | Updates api-version metadata. |
monitored_subscription/_update.py | Updates api-version; adjusts option aliases. |
monitored_subscription/_show.py | Updates api-version metadata. |
monitored_subscription/_list.py | Updates api-version metadata. |
monitored_subscription/_delete.py | Updates api-version metadata. |
monitored_subscription/_create.py | Updates api-version; adjusts option aliases. |
monitor/_wait.py | Updates api-version; extends schema with new fields (kind, hostingType, projectDetails). |
monitor/_vm_ingestion_detail.py | Updates api-version and example usage. |
monitor/_vm_collection_update.py | Introduces new vm-collection-update POST command. |
monitor/_upgrade.py | Updates api-version; switches to LRO poller return pattern. |
monitor/_update.py | Updates api-version; adds kind, hostingType, projectDetails; adjusts argument aliases. |
monitor/_show.py | Updates api-version; extends schema with new fields. |
monitor/_list_vm_host.py | Updates api-version and example usage. |
monitor/_list_upgradable_version.py | Updates api-version and example usage. |
monitor/_list_monitored_resource.py | Adds new list-monitored-resource command with pagination. |
monitor/_list_deployment_info.py | Updates api-version; adds configurationType/projectType to schema. |
monitor/_list_connected_partner_resource.py | Updates api-version; adds type field to properties. |
monitor/_list_associated_traffic_filter.py | Updates api-version and example usage. |
monitor/_list_all_traffic_filter.py | Updates api-version and example usage. |
monitor/_list.py | Updates api-version; refactors list logic and adds new schema fields. |
monitor/_get_billing_info.py | Updates api-version metadata. |
monitor/_detach_traffic_filter.py | Updates api-version and example usage. |
monitor/_detach_and_delete_traffic_filter.py | Updates api-version and example usage. |
monitor/_delete_traffic_filter.py | Updates api-version and example usage. |
monitor/_delete.py | Updates api-version and example usage. |
monitor/_create_or_update_external_user.py | Updates api-version and example usage. |
monitor/_create_and_associate_pl_filter.py | Updates api-version; switches to LRO poller. |
monitor/_create_and_associate_ip_filter.py | Updates api-version; switches to LRO poller. |
monitor/_create.py | Updates api-version; adds identity, kind, hostingType, projectDetails; adjusts validation lengths. |
monitor/_associate_traffic_filter.py | Updates api-version; switches to LRO poller. |
monitor/init.py | Adds imports for new commands; introduces potential duplicate/overlapping imports. |
elastic_version/_list.py | Updates api-version and expands description. |
elastic_version/__cmd_group.py | Replaces docstring; scope may no longer align with actual commands. |
elastic/_get_organization_api_key.py | Updates api-version; example simplified. |
elastic/_get_elastic_organization_to_azure_subscription_mapping.py | Adds new mapping command. |
elastic/init.py | Adds import for new mapping command. |
src/elastic/azext_elastic/aaz/latest/elastic/monitor/open_ai_integration/__init__.py
Show resolved
Hide resolved
src/elastic/azext_elastic/aaz/latest/elastic/elastic_version/__cmd_group.py
Show resolved
Hide resolved
|
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.