Skip to content

Conversation

jkore1911
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@jkore1911 jkore1911 requested a review from kairu-ms as a code owner October 17, 2025 08:15
@Copilot Copilot AI review requested due to automatic review settings October 17, 2025 08:15
@jkore1911 jkore1911 requested a review from jsntcy as a code owner October 17, 2025 08:15
Copy link

azure-client-tools-bot-prd bot commented Oct 17, 2025

❌Azure CLI Extensions Breaking Change Test
❌elastic
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate elastic monitor create cmd elastic monitor create update parameter saa_s_azure_subscription_status: updated property options from ['--saa-s-azure-subscription-status', '-s'] to ['--saa-s-azure-subscription-status', '--saas-status'] please change property options from ['--saa-s-azure-subscription-status', '--saas-status'] to ['--saa-s-azure-subscription-status', '-s'] for parameter saa_s_azure_subscription_status of cmd elastic monitor create
1010 - ParaPropUpdate elastic monitor monitored-subscription create cmd elastic monitor monitored-subscription create update parameter monitored_subscription_list: updated property options from ['--monitored-subscription-list', '-m'] to ['--monitored-subscription-list', '--subscription-list'] please change property options from ['--monitored-subscription-list', '--subscription-list'] to ['--monitored-subscription-list', '-m'] for parameter monitored_subscription_list of cmd elastic monitor monitored-subscription create
1010 - ParaPropUpdate elastic monitor monitored-subscription update cmd elastic monitor monitored-subscription update update parameter monitored_subscription_list: updated property options from ['--monitored-subscription-list', '-m'] to ['--monitored-subscription-list', '--subscription-list'] please change property options from ['--monitored-subscription-list', '--subscription-list'] to ['--monitored-subscription-list', '-m'] for parameter monitored_subscription_list of cmd elastic monitor monitored-subscription update
1010 - ParaPropUpdate elastic monitor open-ai-integration create cmd elastic monitor open-ai-integration create update parameter open_ai_resource_endpoint: updated property options from ['--open-ai-resource-endpoint', '-e'] to ['--open-ai-resource-endpoint', '--openai-endpoint'] please change property options from ['--open-ai-resource-endpoint', '--openai-endpoint'] to ['--open-ai-resource-endpoint', '-e'] for parameter open_ai_resource_endpoint of cmd elastic monitor open-ai-integration create
1010 - ParaPropUpdate elastic monitor open-ai-integration update cmd elastic monitor open-ai-integration update update parameter open_ai_resource_endpoint: updated property options from ['--open-ai-resource-endpoint', '-e'] to ['--open-ai-resource-endpoint', '--openai-endpoint'] please change property options from ['--open-ai-resource-endpoint', '--openai-endpoint'] to ['--open-ai-resource-endpoint', '-e'] for parameter open_ai_resource_endpoint of cmd elastic monitor open-ai-integration update
1010 - ParaPropUpdate elastic monitor update cmd elastic monitor update update parameter saa_s_azure_subscription_status: updated property options from ['--saa-s-azure-subscription-status', '-s'] to ['--saa-s-azure-subscription-status', '--saas-status'] please change property options from ['--saa-s-azure-subscription-status', '--saas-status'] to ['--saa-s-azure-subscription-status', '-s'] for parameter saa_s_azure_subscription_status of cmd elastic monitor update
⚠️ 1001 - CmdAdd elastic get-elastic-organization-to-azure-subscription-mapping cmd elastic get-elastic-organization-to-azure-subscription-mapping added
⚠️ 1006 - ParaAdd elastic monitor create cmd elastic monitor create added parameter hosting_type
⚠️ 1006 - ParaAdd elastic monitor create cmd elastic monitor create added parameter identity
⚠️ 1006 - ParaAdd elastic monitor create cmd elastic monitor create added parameter kind
⚠️ 1006 - ParaAdd elastic monitor create cmd elastic monitor create added parameter project_details
⚠️ 1001 - CmdAdd elastic monitor list-monitored-resource cmd elastic monitor list-monitored-resource added
⚠️ 1001 - CmdAdd elastic monitor open-ai-integration get-status cmd elastic monitor open-ai-integration get-status added
⚠️ 1006 - ParaAdd elastic monitor update cmd elastic monitor update added parameter hosting_type
⚠️ 1006 - ParaAdd elastic monitor update cmd elastic monitor update added parameter kind
⚠️ 1006 - ParaAdd elastic monitor update cmd elastic monitor update added parameter project_details
⚠️ 1001 - CmdAdd elastic monitor vm-collection-update cmd elastic monitor vm-collection-update added

Copy link

Hi @jkore1911,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 17, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Elastic CLI extension to a newer service/API version (2025-06-01), raises the minimum Azure CLI core version, and introduces new commands and schema fields for expanded Elastic monitor and integration functionality.

  • Bumps api-version across all Elastic commands from 2024-06-15-preview to 2025-06-01 and updates azext.minCliCoreVersion.
  • Adds new commands (e.g., get-status, list-monitored-resource, vm-collection-update, get-elastic-organization-to-azure-subscription-mapping) and extends monitor resource schemas (kind, hostingType, projectDetails).
  • Adjusts test file by commenting out previously executed upgrade and traffic filter association steps (reducing test coverage).

Reviewed Changes

Copilot reviewed 51 out of 55 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/elastic/azext_elastic/tests/latest/test_elastic_scenario.py Adjusts imports and comments out several test steps tied to upgrade and filter creation.
src/elastic/azext_elastic/azext_metadata.json Increases min CLI core version to 2.75.0 to match new API requirements.
tag_rule/_wait.py Updates api-version to 2025-06-01 for wait operation.
tag_rule/_update.py Updates api-version and docstring example; version metadata bumped.
tag_rule/_show.py Updates api-version and example usage.
tag_rule/_list.py Updates api-version and example; resource path version bumped.
tag_rule/_delete.py Updates api-version and example usage.
tag_rule/_create.py Updates api-version and example usage.
open_ai_integration/_update.py Updates api-version; modifies argument options and example.
open_ai_integration/_show.py Updates api-version metadata.
open_ai_integration/_list.py Updates api-version metadata.
open_ai_integration/_get_status.py Adds new get-status command implementation.
open_ai_integration/_delete.py Updates api-version metadata.
open_ai_integration/_create.py Updates api-version metadata; adjusts endpoint option aliases.
open_ai_integration/init.py Adds new import; retains legacy misspelled import.
monitored_subscription/_wait.py Updates api-version metadata.
monitored_subscription/_update.py Updates api-version; adjusts option aliases.
monitored_subscription/_show.py Updates api-version metadata.
monitored_subscription/_list.py Updates api-version metadata.
monitored_subscription/_delete.py Updates api-version metadata.
monitored_subscription/_create.py Updates api-version; adjusts option aliases.
monitor/_wait.py Updates api-version; extends schema with new fields (kind, hostingType, projectDetails).
monitor/_vm_ingestion_detail.py Updates api-version and example usage.
monitor/_vm_collection_update.py Introduces new vm-collection-update POST command.
monitor/_upgrade.py Updates api-version; switches to LRO poller return pattern.
monitor/_update.py Updates api-version; adds kind, hostingType, projectDetails; adjusts argument aliases.
monitor/_show.py Updates api-version; extends schema with new fields.
monitor/_list_vm_host.py Updates api-version and example usage.
monitor/_list_upgradable_version.py Updates api-version and example usage.
monitor/_list_monitored_resource.py Adds new list-monitored-resource command with pagination.
monitor/_list_deployment_info.py Updates api-version; adds configurationType/projectType to schema.
monitor/_list_connected_partner_resource.py Updates api-version; adds type field to properties.
monitor/_list_associated_traffic_filter.py Updates api-version and example usage.
monitor/_list_all_traffic_filter.py Updates api-version and example usage.
monitor/_list.py Updates api-version; refactors list logic and adds new schema fields.
monitor/_get_billing_info.py Updates api-version metadata.
monitor/_detach_traffic_filter.py Updates api-version and example usage.
monitor/_detach_and_delete_traffic_filter.py Updates api-version and example usage.
monitor/_delete_traffic_filter.py Updates api-version and example usage.
monitor/_delete.py Updates api-version and example usage.
monitor/_create_or_update_external_user.py Updates api-version and example usage.
monitor/_create_and_associate_pl_filter.py Updates api-version; switches to LRO poller.
monitor/_create_and_associate_ip_filter.py Updates api-version; switches to LRO poller.
monitor/_create.py Updates api-version; adds identity, kind, hostingType, projectDetails; adjusts validation lengths.
monitor/_associate_traffic_filter.py Updates api-version; switches to LRO poller.
monitor/init.py Adds imports for new commands; introduces potential duplicate/overlapping imports.
elastic_version/_list.py Updates api-version and expands description.
elastic_version/__cmd_group.py Replaces docstring; scope may no longer align with actual commands.
elastic/_get_organization_api_key.py Updates api-version; example simplified.
elastic/_get_elastic_organization_to_azure_subscription_mapping.py Adds new mapping command.
elastic/init.py Adds import for new mapping command.

Copy link

github-actions bot commented Oct 17, 2025

@jsntcy
Copy link
Member

jsntcy commented Oct 17, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants