Skip to content

Conversation

a0x1ab
Copy link
Member

@a0x1ab a0x1ab commented Oct 17, 2025

Related command

az webapp auth update -g {resource-group} --excluded-paths {paths}

Description

  1. Fixed logic for parsing excluded paths for auth update
  2. Added new test and recording for the parsing fix
  3. Fixed errors in AuthV2 scenario tests which were affecting this PR
  4. Re-recorded their tests

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Copilot Copilot AI review requested due to automatic review settings October 17, 2025 09:57
Copy link

azure-client-tools-bot-prd bot commented Oct 17, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 17, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the --excluded-paths parsing logic in the az webapp auth update command to properly handle multiple input formats including JSON arrays and comma-separated values.

Key Changes:

  • Updated excluded paths parsing to support both JSON array format and comma-separated strings
  • Added comprehensive test coverage for various excluded paths input formats
  • Bumped extension version to 1.0.1

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
src/authV2/setup.py Incremented version from 1.0.0 to 1.0.1
src/authV2/azext_authV2/custom.py Replaced string slicing logic with JSON parsing that falls back to comma-separated parsing
src/authV2/azext_authV2/tests/latest/test_authV2_scenario.py Added comprehensive test case covering single paths, comma-separated paths, JSON arrays, and special characters
src/authV2/HISTORY.rst Added changelog entry for version 1.0.1 documenting the excluded paths parsing fix

Copy link

@a0x1ab a0x1ab force-pushed the authv2-excluded-paths-fix branch from 4fd554e to c8f7298 Compare October 18, 2025 07:59
@a0x1ab a0x1ab closed this Oct 18, 2025
@a0x1ab a0x1ab deleted the authv2-excluded-paths-fix branch October 18, 2025 08:02
@a0x1ab a0x1ab restored the authv2-excluded-paths-fix branch October 18, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants