-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{AuthV2} az webapp auth update
: Fix --excluded-paths
logic
#9311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the --excluded-paths
parsing logic in the az webapp auth update
command to properly handle multiple input formats including JSON arrays and comma-separated values.
Key Changes:
- Updated excluded paths parsing to support both JSON array format and comma-separated strings
- Added comprehensive test coverage for various excluded paths input formats
- Bumped extension version to 1.0.1
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/authV2/setup.py | Incremented version from 1.0.0 to 1.0.1 |
src/authV2/azext_authV2/custom.py | Replaced string slicing logic with JSON parsing that falls back to comma-separated parsing |
src/authV2/azext_authV2/tests/latest/test_authV2_scenario.py | Added comprehensive test case covering single paths, comma-separated paths, JSON arrays, and special characters |
src/authV2/HISTORY.rst | Added changelog entry for version 1.0.1 documenting the excluded paths parsing fix |
|
4fd554e
to
c8f7298
Compare
Related command
az webapp auth update -g {resource-group} --excluded-paths {paths}
Description
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.