Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MarketplaceOrdering] New command group az term to accept/show terms #17686

Merged
merged 12 commits into from
Apr 28, 2021

Conversation

yungezz
Copy link
Member

@yungezz yungezz commented Apr 14, 2021

Description

MarketplaceOrdering RP https://docs.microsoft.com/en-us/rest/api/marketplaceordering/marketplaceagreements, API version 2021-01-01, on Track2 SDK. CodeGen readme config file: https://github.com/Azure/azure-rest-api-specs/pull/12484/files

Why this is a core module instead of extension?
Terms accepting is a general flow in mgmt plane e2e flow. It's a cross RP operation. Accepting term is a key step during RP registration, user will not able to use RP like LiftR specific commands without terms. Put it in core improving discoverability and availability to users. Secondly, marketplaceordering SDK is already a dependency in core repo from long time ago, this will not impact core package heavily.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@fengzhou-msft
Copy link
Member

Should we use az term or az terms? It looks like terms is more common as a command name or option name.

@yungezz
Copy link
Member Author

yungezz commented Apr 14, 2021

Should we use az term or az terms? It looks like terms is more common as a command name or option name.

use term to follow existing command group naming convention: single noun like vm, acr, keyvault etc. what's your thought?

@fengzhou-msft
Copy link
Member

Should we use az term or az terms? It looks like terms is more common as a command name or option name.

use term to follow existing command group naming convention: single noun like vm, acr, keyvault etc. what's your thought?

Yes, it's more common to have single form noun as command group. I was think that it is more common to say accept terms than accept a term. For command group name, I think both forms are acceptable.

@qwordy
Copy link
Member

qwordy commented Apr 27, 2021

@yungezz Example name needs to be updated. You might need to add a manual help file.

@yungezz yungezz merged commit 3ecfd4d into Azure:dev Apr 28, 2021
@yungezz yungezz deleted the term branch April 28, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants