Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Packaging} Bump PyNaCl from 1.4.0 to 1.5.0 to support arm64 wheel installation #22167

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

tbugfinder
Copy link
Contributor

Description

  • bump PyNaCl from 1.4.0 to 1.5.0 to support arm64 wheel installation.

Ref:
#7368

PyNaCl 1.5.0 provides pre-built wheel installation also form arm64 architecture, so the installation is more efficient than building it every time needed.

Testing Guide

History Notes


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Apr 24, 2022
@ghost
Copy link

ghost commented Apr 24, 2022

Thank you for your contribution tbugfinder! We will review the pull request and get back to you soon.

@ghost ghost requested review from jiasli and wangzelin007 April 24, 2022 15:27
@ghost
Copy link

ghost commented Apr 24, 2022

CLA assistant check
All CLA requirements met.

@ghost ghost requested review from yonzhan and kairu-ms April 24, 2022 15:27
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 24, 2022
@ghost ghost assigned jiasli Apr 24, 2022
@ghost ghost added the Packaging label Apr 24, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 24, 2022

Packaging

@jiasli
Copy link
Member

jiasli commented Apr 25, 2022

@tbugfinder, thanks a lot for the contribution!

@jiasli
Copy link
Member

jiasli commented Apr 25, 2022

PyNaCl is used by

@panchagnula @jsntcy @zhoxing-ms, please help verify if the latest version of PyNaCl works correctly.

@jiasli jiasli changed the title {Packaging} fix #7368: bump PyNaCl from 1.4.0 to 1.5.0 to support arm64 wheel installation. {Packaging} Bump PyNaCl from 1.4.0 to 1.5.0 to support arm64 wheel installation Apr 25, 2022
@calvinsID
Copy link
Contributor

from nacl import encoding, public

Confirmed new version is working

@jiasli jiasli merged commit 1f17c0b into Azure:dev Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization. Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants