{Graph} Drop azure-graphrbac SDK in keyvault module
#22203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested a review
from
3 tasks
|
MSGraph |
jiasli
reviewed
Apr 27, 2022
| return current_user.object_id # pylint:disable=no-member | ||
| except CloudError: | ||
| current_user = graph_client.signed_in_user_get() | ||
| if current_user and current_user.get('id', None): # pylint:disable=no-member |
There was a problem hiding this comment.
I think id property should always be there... Any case it won't?
There was a problem hiding this comment.
Just in case id doesn't exist. But yes, we might never meet such case😂
|
A kind reminder. |
jiasli
changed the title
azure-graphrbac SDK in keyvault moduleazure-graphrbac SDK in keyvault module
jiasli
approved these changes
May 11, 2022
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As #22174 mentioned, keyvault module has dependency on
azure-graphrbacSDK.This PR migrates all the callings from
azure.graphrbac.GraphRbacManagementClienttoazure.cli.command_modules.role._graph_client.GraphClientAnd all the related tests have been re-recorded
Testing Guide
Switch to each profile to run all profiles' tests:
az cloud set -n AzureCloud --profile latestaz cloud set -n AzureCloud --profile 2018-03-01-hybridAnd run tests:
azdev test keyvaultThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.