{Service Connector} Fix #24213: az spring connection create mysql-flexible: Resolve dependency conflict with interactive extension
#24268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix dependency conflict issue |
bebound
reviewed
Oct 19, 2022
bebound
changed the title
az spring connection create mysql-flexible: Fix dependency conflict issueaz spring connection create mysql-flexible: Resolve dependency conflict with interactive extension
jiasli
reviewed
Oct 19, 2022
src/azure-cli/azure/cli/command_modules/serviceconnector/_credential_free.py
Outdated
Show resolved
Hide resolved
jiasli
reviewed
Oct 19, 2022
| @@ -215,7 +215,7 @@ def create_aad_user_in_mysql(self, connection_kwargs, query_list): | |||
| for d in installed_packages) | |||
| if not pym_installed: | |||
| import pip | |||
| pip.main(['install', 'mycli']) | |||
| pip.main(['install', 'pymysql']) | |||
There was a problem hiding this comment.
mycli internally depends on PyMySQL:
https://github.com/dbcli/mycli/blob/bc9492a2d425c4d4908c1bfc97c316739a284b9f/setup.py#L27
install_requirements = [
'click >= 7.0',
# Temporary to suppress paramiko Blowfish warning which breaks CI.
# Pinning cryptography should not be needed after paramiko 2.11.0.
'cryptography == 36.0.2',
# 'Pygments>=1.6,<=2.11.1',
'Pygments>=1.6',
'prompt_toolkit>=3.0.6,<4.0.0',
'PyMySQL >= 0.9.2',I guess that's why mycli can be replaced by PyMySQL here.
I am still wondering why mycli was chosen in lieu of PyMySQL initially. Any functionality from mycli is used?
There was a problem hiding this comment.
Mysql team use mycli in their extension, we just align with them but currently Service Connector commands don't need other function from mycli.
jiasli
approved these changes
Oct 19, 2022
bebound
approved these changes
Oct 20, 2022
yanzhudd
approved these changes
Oct 20, 2022
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…ql-flexible`: Resolve dependency conflict with `interactive` extension (Azure#24268) * fix dependency issue * fix setup dependency * revert other changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Fix #24213 by replacing
mycliwithPyMySQLTesting Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.