[Service Connector] az connection: Support local connection which allow local environment to connect Azure resource
#24905
Conversation
|
Service Connector |
xfz11
force-pushed
the
svcconnector/api11
branch
from
f2b6e81
to
c54554f
Compare
src/azure-cli/azure/cli/command_modules/serviceconnector/_help.py
Outdated
Show resolved
Hide resolved
...li/azure/cli/command_modules/serviceconnector/tests/latest/test_local_connection_scenario.py
Show resolved
Hide resolved
xfz11
changed the title
az connection: support local connectionaz connection: support local connection
xfz11
changed the title
az connection: support local connectionaz connection: Support local connection which allow local environment to connect Azure resource
|
@kairu-ms Hi Kai, can you help review the PR? |
src/azure-cli/setup.py
Outdated
| @@ -145,6 +145,7 @@ | |||
| 'PyGithub~=1.38', | |||
| 'PyMySQL~=1.0.2', | |||
| 'PyNaCl~=1.5.0', | |||
| 'pyodbc==4.0.35', | |||
There was a problem hiding this comment.
Why use "==" instead of "~=" here?
| @@ -125,6 +125,7 @@ PyGithub==1.55 | |||
| PyJWT==2.4.0 | |||
| PyMySQL==1.0.2 | |||
| PyNaCl==1.5.0 | |||
| pyodbc==4.0.35 | |||
There was a problem hiding this comment.
It seems more dependencies are included. What's pyodbc used to?
There was a problem hiding this comment.
BTW, I highly recommend moving Service Connector into azure-cli-extension because it involves lots of third parts libraries. And it may block other modules or extensions like az interactive issue
There was a problem hiding this comment.
It's a valid concern, we will take it into serious consideration and discuss it with the team. While before that, how about we let the new command group in the core to keep consistency.
For the library, if it indeed has some conflicts with other components, i think we can discuss if there are any work arounds there
There was a problem hiding this comment.
@bebound is evaluating the pyodbc package.
There was a problem hiding this comment.
Thanks @kairu-ms and @bebound. As we discussed, pyodbc doesn't support well on linux and it does fail many tests on the pipeline: https://github.com/Azure/azure-cli/pull/24905/checks?check_run_id=10246207156
The homebrew test also failed because it needs to install unixodbc first. The library home page shows the same requirement: https://github.com/mkleehammer/pyodbc
It also says On Windows, the ODBC driver manager is built-in, which means Windows doesn't need prerequisite of installing pyodbc.
So, I remove pyodbc from linux and darwin requirement file and keep the windows requirement file.
…llow local environment to connect Azure resource (Azure#24905) * support local connection * recording test * update test recording * update help * fix param help * update postgres flexible server * fix help * fix * remove enable_pg_extension * update pyodbc version * remove pyodbc from setup * update dependency of pyodbc * fix credential free * add test and update help * update help file * update credential free to create local users * update postgres * fix lint and remove pyodbc dependency * update
Related command
Description
Support local connection, which do some configuration to allow user's local environment to connect some Azure resource, including sql, appconfig, comosdb, mysql, postgresql, etc.
Command group:
az connectionSubgroups:
create: Create a connection from local to a target resource.preview-configuration: Preview the expected configurations of local connection.update: Update a Service Connector local connection.Commands:
delete: Delete a Service Connector local connection.generate-configuration: Generate configurations of a Service Connector local connection.list: List local connections of Service Connector.list-support-types: List client types and auth types supported by local connections.show: Get the details of a Service Connector local connection.validate: Validate a Service Connector local connection.wait: Place the CLI in a waiting state until a condition of the connection ismet.
Command for
az connection creategroupaz connection create appconfig/confluent-cloud/cosmos-cassandra/cosmos-gremlin/cosmos-mongo/cosmos-sql/cosmos-table/eventhub/keyvault/mysql/mysql-flexible/postgres/postgres-flexible/redis/redis-enterprise/servicebus/signalr/sql/storage-blob/storage-file/storage-queue/storage-table/webpubsubCreate connection to connect specific target Azure resource
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.