[Packaging] Bump embedded Python version to 3.11.5 #26749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bebound, |
🔄AzureCLI-FullTest
|
ghost
requested a review
from
️✔️AzureCLI-BreakingChangeTest
|
|
Packaging |
ghost
added
the
|
Close as Python 3.10.12 does not contains binary installers. |
bebound
changed the title
# Conflicts: # build_scripts/windows/scripts/build.cmd # scripts/release/homebrew/docker/formula_generate.py
bebound
changed the title
jiasli
reviewed
Sep 18, 2023
Comment on lines
+128
to
+131
| # update python version | ||
| text = re.sub('depends_on "python@.*"', f'depends_on "python@{PYTHON_VERSION}"', text, 1) | ||
| text = re.sub(r'virtualenv_create\(libexec, "python.*"', f'virtualenv_create(libexec, "python{PYTHON_VERSION}"', text, 1) # pylint: disable=line-too-long | ||
|
|
There was a problem hiding this comment.
Should these lines be dropped in the next release? It is really inconvenient to make any change to the formula.
Or, can we just keep the formula as is and make the change when a PR is submitted for https://github.com/Homebrew/homebrew-core/blob/master/Formula/a/azure-cli.rb ?
In my thought, the Azure CLI repo should be self-contained - it should never depend on external resources to build and install.
There was a problem hiding this comment.
I prefer to keep it here for two reasons.
TestHomebrewFormulacan check whether new formula works with new Python.- Homebrew users can use the new Python version as soon as possible.
For other changes like the without_pip: false in #27186, we can create a PR for homebrew.
Sometimes the Homebrew community update our formula, which cause a conflict, so we modify the external formula. This behavior is introduced in #11964
3 tasks
bebound
modified the milestones:
September 2023 (2023-09-26),
October 2023 (2023-11-15)❗ Breaking change release ❗
jiasli
approved these changes
Sep 20, 2023
bebound
changed the title
bebound
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #26740, CVE-2023-0464, CVE-2023-0466, CVE-2023-24329 are fixed in Python 3.11.4
The user may need to reinstall their extensions if the dependency provides different wheels for different python version.
PS:
scripts/release/debian/Dockerfileis only used inscripts/release/debian/README.md, which is also deprecated. So I don't update its version number.Related issue: #24494
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.