{Container} az container attach: Fix the exception handling for streaming logs
#26807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modules/container/custom.py. This updating is due to the fact that an exception was not properly handled. This exception takes place when a log is received by the function _stream_logs but is None for some reason. Indeed, this function is properly working in most scenarios but problems have been experienced for some particular deployments where some libraries have their own log system
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
ghost
added
the
customer-reported
|
Thank you for your contribution LuisJesusMunozMolina! We will review the pull request and get back to you soon. |
|
custom.py |
zhoxing-ms
changed the title
zhoxing-ms
changed the title
|
@LuisJesusMunozMolina Please resolve these CI issues |
|
@fnuarnav Could you please help review this container related PR? |
|
I will review it, thank you :) |
LuisJesusMunozMolina
changed the title
LuisJesusMunozMolina
changed the title
zhoxing-ms
changed the title
zhoxing-ms
changed the title
az container attach: Fix the exception handling for streaming logs
|
@LuisJesusMunozMolina Any update? |
zhoxing-ms
modified the milestones:
August 2023 (2023-09-05),
Backlog,
September 2023 (2023-09-26)
|
Hi @zhoxing-ms , I took a look but I did not see any detail about the CI issues, so I could not fix them yet. Could someone please give some hints? |
|
Sorry, I am super busy recently, @yanzhudd will help check the CI issue and give you some tips |
zhoxing-ms
added this to the October 2023 (2023-11-15)❗ Breaking change release ❗ milestone
zhoxing-ms
modified the milestones:
October 2023 (2023-11-14)❗ Breaking change release ❗,
November 2023 (2023-12-05)
zhoxing-ms
modified the milestones:
November 2023 (2023-12-05),
December 2023 (2024-01-02)
zhoxing-ms
modified the milestones:
December 2023 (2024-01-09),
January 2024 (2024-02-06)
zhoxing-ms
modified the milestones:
January 2024 (2024-02-06),
February 2024 (2024-03-05)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
stream_logs function in src/azure-cli/azure/cli/command_modules/container/custom.py.
Description
This issue is due to the fact that an exception was not properly handled. This exception takes place when a log is received by the function _stream_logs but is of type Nonetype for some reason. Indeed, this function is properly working in most scenarios, however problems have been experienced for some particular deployments where some libraries have their own log system, and therefor these logs cannot be properly treated by the _stream_logs function.
This issues does not take place when the docker container is run in local, it only appears when it is deployed in the Azure Container Instance
In this pull request, a try and except policy have been included in order handle the exception
History Notes
{Azure Container Instance} cli-custom.py. MINOR ISSUE: bad exception handling in _stream_logs function in custom.py file
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.