[AppConfig] az appconfig kv delete/set/set-keyvault: Add key validations for null or empty space key parameter
#26928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertofori
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @albertofori, |
ghost
added
the
️✔️AzureCLI-BreakingChangeTest
|
ghost
requested review from
|
AppConfig |
albertofori
changed the title
az appconfig kv delete/set/set-keyvault: Add key validations for null or empty space keysaz appconfig kv delete/set/set-keyvault: Add key validations for null or empty space key parameter
avanigupta
reviewed
Jul 18, 2023
| @@ -250,7 +251,7 @@ def load_arguments(self, _): | |||
| c.argument('secret_identifier', validator=validate_secret_identifier, help="ID of the Key Vault object. Can be found using 'az keyvault {collection} show' command, where collection is key, secret or certificate. To set reference to the latest version of your secret, remove version information from secret identifier.") | |||
|
|
|||
| with self.argument_context('appconfig kv delete') as c: | |||
| c.argument('key', help='Support star sign as filters, for instance * means all key and abc* means keys with abc as prefix.') | |||
| c.argument('key', validator=validate_non_empty_key, help='Support star sign as filters, for instance * means all key and abc* means keys with abc as prefix.') | |||
There was a problem hiding this comment.
Why not use validate_key directly? The character restrictions apply for delete command too.
There was a problem hiding this comment.
You are right. The reason for separating the two was that the delete parameter could also be a filter. But specifying any of the restricted characters without any wildcard should return nothing from the backend anyway since no kv could have been created with such a key. As you rightly pointed out, it is even rejected by the backend.
This has been updated, thanks!
avanigupta
approved these changes
Jul 18, 2023
zhoxing-ms
approved these changes
Jul 19, 2023
zhoxing-ms
changed the title
az appconfig kv delete/set/set-keyvault: Add key validations for null or empty space key parameteraz appconfig kv delete/set/set-keyvault: Add key validations for null or empty space key parameter
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…tions for null or empty space key parameter (Azure#26928)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az appconfig kv setaz appconfig kv set-keyvaultaz appconfig kv deleteDescription
Adds validations to ensure that key parameters and filters that are empty or whitespace are rejected for kv
set,set-keyvaultanddeletecommands.Testing Guide
History Notes
[AppConfig]
az appconfig kv delete/set/set-keyvault: Add key validations for null or empty space keysThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.