[Packaging] Support Python 3.12 #29465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @bebound, |
️✔️AzureCLI-BreakingChangeTest
|
|
Packaging |
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007 and
yonzhan
jiasli
reviewed
Jul 26, 2024
| @@ -39,6 +39,7 @@ | |||
| 'Programming Language :: Python :: 3.9', | |||
| 'Programming Language :: Python :: 3.10', | |||
| 'Programming Language :: Python :: 3.11', | |||
| 'Programming Language :: Python :: 3.12', | |||
There was a problem hiding this comment.
This should also be added to
azure-cli/src/azure-cli/setup.py
Line 48 in b616adf
azure-cli/src/azure-cli-testsdk/setup.py
Line 21 in a5198b5
bebound
commented
Jul 26, 2024
| @@ -22,9 +22,9 @@ jobs: | |||
| fetchTags: true | |||
| persistCredentials: true | |||
| - task: UsePythonVersion@0 | |||
| displayName: 'Use Python 3.10' | |||
| displayName: 'Use Python 3.11' | |||
There was a problem hiding this comment.
Same as bundled Python version.
bebound
force-pushed
the
bump-3.12
branch
2 times, most recently
from
1d7fb07
to
196ae5a
Compare
bebound
commented
Jul 30, 2024
| @@ -24,9 +24,9 @@ def test_validate_decorator_mode(self): | |||
| self.assertEqual(validate_decorator_mode(DecoratorMode.CREATE), True) | |||
| self.assertEqual(validate_decorator_mode(DecoratorMode.UPDATE), True) | |||
| self.assertEqual(validate_decorator_mode(DecoratorMode), False) | |||
| self.assertEqual(validate_decorator_mode(1), False) | |||
| # self.assertEqual(validate_decorator_mode(1), False) | |||
There was a problem hiding this comment.
In 3.12, the Enum.value in Enum is True.
DeprecationWarning: in 3.12 __contains__ will no longer raise TypeError, but will return True or False depending on whether the value is a member or the value of a member
This is the result in 3.11:
>>> from enum import Enum
>>> class DecoratorMode(Enum):
... """Enumerations used to distinguish whether to handle creation or update.
... """
... CREATE = 1
... UPDATE = 2
...
>>> 1 in DecoratorMode
<stdin>:1: DeprecationWarning: in 3.12 __contains__ will no longer raise TypeError, but will return True or
False depending on whether the value is a member or the value of a member
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2544.0_x64__qbz5n2kfra8p0\Lib\enum.py", line 742, in __contains__
raise TypeError(
TypeError: unsupported operand type(s) for 'in': 'int' and 'EnumType'
>>> True in DecoratorMode
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2544.0_x64__qbz5n2kfra8p0\Lib\enum.py", line 742, in __contains__
raise TypeError(
TypeError: unsupported operand type(s) for 'in': 'bool' and 'EnumType'
>>> "1" in DecoratorMode
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2544.0_x64__qbz5n2kfra8p0\Lib\enum.py", line 742, in __contains__
raise TypeError(
TypeError: unsupported operand type(s) for 'in': 'str' and 'EnumType'
In 3.12
>>> 1 in DecoratorMode
True
>>> True in DecoratorMode
True
>>> "1" in DecoratorMode
False
Changed in version 3.12: Before Python 3.12, a
TypeErroris raised if a non-Enum-member is used in a containment check. --https://docs.python.org/3/library/enum.html#enum.EnumType.__contains__
Not sure if this affects az command, skip the test temporally.
I'll check it when bundle Python bumps to 3.12.
bebound
requested review from
zhoxing-ms,
jsntcy,
yanzhudd,
evelyn-ys,
kairu-ms,
calvinhzy and
necusjz
as code owners
zhoxing-ms
previously approved these changes
Jul 30, 2024
This reverts commit 2e3a4c3.
jiasli
approved these changes
Aug 1, 2024
evelyn-ys
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #27673
Changes:
setup.pyAlso need to update
scripts/ci/build.shto include 3.12 insetup.py