[SQL] Add IOPS parameter to MI create and update #29873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aleksand4rZivanovic
requested review from
evelyn-ys and
calvinhzy
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| sql mi create | cmd sql mi create added parameter is_general_purpose_v2 |
||
| sql mi create | cmd sql mi create added parameter storage_iops |
||
| sql mi update | cmd sql mi update added parameter is_general_purpose_v2 |
||
| sql mi update | cmd sql mi update added parameter storage_iops |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Aleksand4rZivanovic
changed the title
Aleksand4rZivanovic
changed the title
evelyn-ys
reviewed
Sep 12, 2024
evelyn-ys
approved these changes
Sep 12, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az sql mi create
az sql mi update
Description
There is a new edition of Managed Instance that is a "V2" edition of general purpose edition.
The new edition can specify storage IOPS as a parameter.
This PR adds the V2 flag and storage IOPS parameter.
Testing Guide
Tested manually by creating and updating all combos of edition.
Added tests - will add test recordings in next push.
az sql mi create -n "test-managedinstance-wcus-he-1" -e GeneralPurpose --gpv2 true -f Gen8IM -c 4 --storage 256GB --iops 4000 -l westcentralus -g "test-resourcegroup-wcus" --subnet "/subscriptions/62e48210-5e43-423e-889b-c277f3e08c39/resourceGroups/test-resourcegroup-wcus/providers/Microsoft.Network/virtualNetworks/test-virtualnetwork-wcus/subnets/test-subnet-wcus" -u "clperf" -p "blah123"
az sql mi update -n "test-managedinstance-wcus-he-3" -e GeneralPurpose --gpv2 --storage 512GB --iops 4000 -g "test-resourcegroup-wcus"
History Notes
[SQL]
az sql mi create/update: Add gpv2 parameter and iops parameterThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.