{Compute} az sig: Migrate commands using Code Gen V2
#30524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanzhudd
requested review from
zhoxing-ms,
jsntcy and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
|
|
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
Compute
|
|
zhoxing-ms
reviewed
Dec 16, 2024
| "version": "2021-10-01", | ||
| "version": "2019-12-01", |
There was a problem hiding this comment.
Why do we need to downgrade the api-version here?
There was a problem hiding this comment.
It should be 2019-12-01 instead of 2021-10-01, and this PR just fix it.
I'll fix the API version for az sig list command in 2020-09-01-hybrid as well.
zhoxing-ms
reviewed
Dec 16, 2024
Comment on lines
+7749
to
+7754
| # This command is commented out because the backend service currently prevents updating 'Private' to 'Community'. | ||
| # self.cmd('sig update -g {rg} --gallery-name {gallery1} --permissions Community ' | ||
| # '--publisher-uri pubUri --publisher-email test@123.com --eula eula --public-name-prefix pubName', | ||
| # checks=[ | ||
| # self.check('sharingProfile.permissions', 'Community') | ||
| # ]) |
There was a problem hiding this comment.
Why do we need to remove this test?
There was a problem hiding this comment.
I have added a comment for it:
It is the same as
azure-cli/src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py
Lines 6625 to 6627 in 3b9a7c2
zhoxing-ms
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az sig create/update/show/list-sharedDescription
Migrate
sigcommand group to Code Gen V2Note: The subcommand groups have not yet been migrated
AAZ PR: Azure/aaz#647
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.