[Backup] az backup: Add support for new AFS Vault Standard Policies
#30531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IannGeorges
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| backup policy set | cmd backup policy set added parameter yes |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
|
microsoft-github-policy-service
bot
requested review from
yonzhan and
wangzelin007
IannGeorges
force-pushed
the
users/ianna/afsVaultPolicy
branch
from
20423fe to
de7c8b2
Compare
|
@yonzhan @zhoxing-ms Could you please re-trigger the pipeline, I want to download private build for bug bash |
zubairabid
suggested changes
Dec 27, 2024
src/azure-cli/azure/cli/command_modules/backup/tests/latest/preparers.py
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zubairabid
reviewed
Jan 3, 2025
zhoxing-ms
reviewed
Jan 8, 2025
zhoxing-ms
modified the milestones:
January 2025 (2025-01-14),
February 2025 (2025-02-11)
|
Please refer to this document Submitting Pull Requests to improve the PR title |
IannGeorges
changed the title
zhoxing-ms
changed the title
az backup: Add support for new AFS Vault Standard Policies
zhoxing-ms
reviewed
Jan 22, 2025
| existing_backup_management_type = existing_policy.properties.backup_management_type | ||
| new_backup_management_type = new_policy.properties.backup_management_type | ||
| if existing_backup_management_type != new_backup_management_type: | ||
| raise CLIError("BackupManagementType cannot be different than the existing type.") | ||
| # vault -> snapshot | ||
| if new_backup_management_type.lower() == 'azurestorage' and hasattr(existing_policy.properties, 'vault_retention_policy') and existing_policy.properties.vault_retention_policy is not None and hasattr(new_policy.properties, 'retention_policy') and new_policy.properties.retention_policy is not None: |
There was a problem hiding this comment.
The newly added judgment logic is too complex. Could it be abstracted as a variable to reduce the complexity of code
There was a problem hiding this comment.
@zhoxing-ms Thanks for the feedback, I have refactored the code
zhoxing-ms
reviewed
Jan 22, 2025
| Please create a new policy for snapshot-only backups. | ||
| """) | ||
| # snapshot -> vault | ||
| if new_backup_management_type.lower() == 'azurestorage' and hasattr(existing_policy.properties, 'retention_policy') and existing_policy.properties.retention_policy is not None and hasattr(new_policy.properties, 'vault_retention_policy') and new_policy.properties.vault_retention_policy is not None: |
added 2 commits
January 21, 2025 21:43
…eorges/azure-cli into users/ianna/afsVaultPolicy
zhoxing-ms
previously approved these changes
Jan 22, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Please resolve CI issues. |
|
Please note Azure CLI will freeze the code on 01/28/2025 10:00 UTC for the upcoming release. If you want to catch this release train, please get this PR ready ASAP, otherwise it has to be postponed to next sprint. |
|
@yanzhudd @yonzhan @jsntcy Whenever you have a moment could you please rerun the pipeline? I have addressed the CI linting issues. @zhoxing-ms has already approved, merge was pending CI checks. |
|
/azp run |
|
I believe CI is flaky, could you please run the pipeline again? @yonzhan |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
My apologies but could you please rerun the CI once more? Addressed the remaining linting errors @yonzhan |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
CI is still failing. |
|
@yonzhan Sorry for the inconvenience, could you please run the CI? Linting issues should be resolved now with latest change ... |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.