{ACR} Fix #30041: az acr command failed with "multiple values for keyword argument" error when running on SAW #30542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenm2151
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
SakoPak
reviewed
Dec 19, 2024
| @@ -196,7 +196,7 @@ def _get_aad_token_after_challenge(cli_ctx, | |||
| } | |||
|
|
|||
| logger.debug(add_timestamp("Sending a HTTP Post request to {}".format(authhost))) | |||
| response = requests.post(authhost, urlencode(content), headers=headers, | |||
| response = requests.post(url=authhost, data=urlencode(content), headers=headers, | |||
| verify=not should_disable_connection_verify()) | |||
There was a problem hiding this comment.
I see this same request being used on line 303 as well....to maintain consistency and avoid potential issues with positional arguments, should we also change line 303 to use keyword arguments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az acr login
Description
Fix login issue on SAW #30041 due to a special package used to replace the standard python requests package. Since the standard python package cannot be used on SAW for security reasons, CLI team replaced requests with windows-http. The different positional argument sequence between requests and windows-http caused this issue to occur on SAW. I had a discussion with Hang Lei and the quickest way to resolve this is to use keyword arguments instead of positional arguments. We will have to wait until the next CLI release to SAW for the issue to be resolved.
Testing Guide
az acr login -n myregistry
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.