{RDBMS} az postgres flexible-server create: Support Case-Insensitive Input for --public-access
#30548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Input for --public-access
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
nasc17
reviewed
Dec 20, 2024
| (len(val.split('-')) == 2 and _validate_ip(val))): | ||
| raise CLIError('incorrect usage: --public-access. ' | ||
| 'Acceptable values are \'Disabled\', \'Enabled\', \'all\', \'none\',\'<startIP>\' and ' | ||
| 'Acceptable values are \'disabled\', \'enabled\', \'all\', \'none\',\'<startIP>\' and ' |
There was a problem hiding this comment.
Nit: We typically show Enabled/Disabled as upper case in help text. Can you the first 4 values as upper case here.
added 2 commits
December 20, 2024 09:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az postgres flexible-server create
Description
Adding case-insensitive support for
--public-accessparameterTesting Guide
History Notes
{RDBMS}
az postgres flexible-server create: Support Case-Insensitive Input for--public-accessThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.