{Compute} az sig image-definition: Migrate commands using Code Gen V2
#30576
+5,224
−2,049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanzhudd
requested review from
zhoxing-ms,
jsntcy and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| sig image-definition list | cmd sig image-definition list added parameter pagination_limit |
||
| sig image-definition list | cmd sig image-definition list added parameter pagination_token |
||
| sig image-definition show-community | cmd sig image-definition show-community update parameter gallery_image_name: added property aaz_type=string |
||
| sig image-definition show-community | cmd sig image-definition show-community update parameter gallery_image_name: added property type=string |
||
| sig image-definition show-community | cmd sig image-definition show-community update parameter gallery_image_name: updated property name from gallery_image_name to gallery_image_definition |
||
| sig image-definition show-community | cmd sig image-definition show-community update parameter location: added property aaz_type=string |
||
| sig image-definition show-community | cmd sig image-definition show-community update parameter location: updated property type from custom_type to string |
||
| sig image-definition show-community | cmd sig image-definition show-community update parameter public_gallery_name: added property aaz_type=string |
||
| sig image-definition show-community | cmd sig image-definition show-community update parameter public_gallery_name: added property type=string |
||
| sig image-definition update | cmd sig image-definition update added parameter no_wait |
||
| sig image-definition update | cmd sig image-definition update update parameter gallery_image_name: added property aaz_type=string |
||
| sig image-definition update | cmd sig image-definition update update parameter gallery_image_name: added property id_part=child_name_1 |
||
| sig image-definition update | cmd sig image-definition update update parameter gallery_image_name: added property type=string |
||
| sig image-definition update | cmd sig image-definition update update parameter gallery_image_name: updated property name from gallery_image_name to gallery_image_definition |
||
| sig image-definition update | cmd sig image-definition update update parameter gallery_name: added property aaz_type=string |
||
| sig image-definition update | cmd sig image-definition update update parameter gallery_name: added property id_part=name |
||
| sig image-definition update | cmd sig image-definition update update parameter gallery_name: added property type=string |
||
| sig image-definition update | cmd sig image-definition update update parameter properties_to_add: added property aaz_type=AAZGenericUpdateAddArg |
||
| sig image-definition update | cmd sig image-definition update update parameter properties_to_remove: added property aaz_type=AAZGenericUpdateRemoveArg |
||
| sig image-definition update | cmd sig image-definition update update parameter properties_to_set: added property aaz_type=AAZGenericUpdateSetArg |
||
| sig image-definition update | cmd sig image-definition update update parameter resource_group_name: added property aaz_type=string |
||
| sig image-definition update | cmd sig image-definition update update parameter resource_group_name: added property type=string |
||
| sig image-definition update | cmd sig image-definition update update parameter resource_group_name: updated property name from resource_group_name to resource_group |
|
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
Compute
zhoxing-ms
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az sig image-definition create/updateDescription
Migrate
sig image-definitioncommand group to Code Gen V2Note: The subcommand groups have not yet been migrated, and some commands cannot be migrated at the present:
az sig image-definition list-community/list-sharedIt would bring a breaking change if we migrate these two commands, as they have already supported pagination with specific parameters.
AAZ PR: Azure/aaz#664
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.