feat: Dev stateless cni #2276

behzad-mir · 2023-10-05T01:48:54Z

This PR includes all changes related to Stateless CNI in which CNS will manage and maintain the endpoint states.

There are changes related to CNS to add two new APIs with respect of endpoint state management.
GetEndpoint() is used to return the state of a given endpointId. UpdateEndpoint() is used to update the HNSId and VethName field within the endpoint state.
The other changes are related to CNI and network package so the ADD/Del calls can be done without the use of statefile on Store package and instead use CNS and aformenetioned APIs.
uses conventional commit messages
includes documentation
adds unit tests
relevant PR labels added

vipul-21 · 2023-10-05T16:58:21Z

/azp run Azure Container Networking PR

azure-pipelines · 2023-10-05T16:58:39Z

Azure Pipelines successfully started running 1 pipeline(s).

jaer-tsun · 2023-11-03T18:09:07Z

cni/network/network.go

 				err = nil
-				return err
+				if !plugin.nm.IsStatelessCNIMode() {


do we need this check if it doesn't apply to stateless cni?

I added a comment on top of it :
// this condition will not apply to stateless CNI since the network struct will be crated on each call

jaer-tsun · 2023-11-03T18:11:28Z

cni/network/stateless/main.go

+var logger = zapLog.CNILogger.With(zap.String("component", "cni-main"))
+
+const (
+	hostNetAgentURL = "http://168.63.129.16/machine/plugins?comp=netagent&type=cnireport"


some of these look common across regular cni

Will be corrected on next commit

jaer-tsun · 2023-11-03T18:26:30Z

network/manager.go

+		NetworkContainerID:       epInfo.Id,
+	}
+	logger.Info("Deleting endpoint with", zap.String("Endpoint Info: ", epInfo.PrettyString()), zap.String("HNISID : ", ep.HnsId))
+	return nw.deleteEndpointImpl(netlink.NewNetlink(), platform.NewExecClient(logger), nil, nil, ep)


we'd need to pass endpoint with SecondaryInterfaceInfo for deletion as well

This is only going to cover stateless CNI for single Tenancy

We are not covering Swift 2.0 at this point

if we address swift 2.0, then we dont need to care about migration for swift2.0 later.. Not in this PR, probably a different PR

rbtr

few minor comments. it would be easier to review if we scoped the changes to smaller PRs container only CNS and only CNI

Makefile

rbtr · 2023-12-07T22:07:08Z

cns/service/main.go

+	endpointStoreLocationLinux        = "/var/run/azure-cns/"
+	endpointStoreLocationWindows      = "/k/azurecns/"


/var/run/azure-cns is a legal file path (in Go) on Windows, do we need to differentiate this? maybe it should just be required that it comes from the config? If we must do this though, we shouldn't put multiplatform variables in main/the same file - they need to be in _linux.go, _windows.go etc

I used that path at first but store package showed error and couldn't create the endpoint file.

then it needs to come from config instead of being hardcoded. we could have config_linux.go and config_windows.go to populate defaults if it is not set

We also already made the AgentBaker changes according to k/azurecns directory since it was provided int he CNS Configmap for Windows. I simply applied the value form the configmap

cns/restserver/ipam.go

#2102) * Adding getEndpoint and UpdateEndpoint API to CNS with the respective clients in support of stateless CNI. * Updating the unit tests and address the comments. * Addressing the comments. * Addressing the coments regarding CNS support for Stateless CNI * Adddressing the PR comments

feat: stateless cni

…package. (#2197) * Apllying stateless CNI mode in network package. * Addresing the commetns.

rbtr

unblocking but let's revisit the windows/linux state file path (and how it comes from config). the hardcoded paths can't stay

behzad-mir · 2023-12-11T20:31:10Z

/azp run Azure Container Networking PR

azure-pipelines · 2023-12-11T20:31:26Z

Azure Pipelines successfully started running 1 pipeline(s).

* feat: 🌈 StatelessCNI: Adding getEndpoint and UpdateEndpoint API to CNS (#2102) * Adding getEndpoint and UpdateEndpoint API to CNS with the respective clients in support of stateless CNI. * Updating the unit tests and address the comments. * Addressing the comments. * Addressing the coments regarding CNS support for Stateless CNI * Adddressing the PR comments * 🌈 feat: adding flags for stateless cni (#2103) feat: stateless cni * 🌈 feat: StatelessCNI: Applying stateless CNI mode changes in network package. (#2197) * Apllying stateless CNI mode in network package. * Addresing the commetns. * feat: create stateless cni binary for swift (#2275) * enabling CNS telemetry * Master rebase changes * CNI Telemetry enabled on CNS * Stateless CNI changes. * making change to CNSendpointStorePath * Updating makefile to avoid creating statless CNI release. --------- Co-authored-by: Vipul Singh <vipul21sept@gmail.com>

behzad-mir requested review from a team as code owners October 5, 2023 01:48

behzad-mir requested a review from jaer-tsun October 5, 2023 01:48

behzad-mir added cni Related to CNI. do-not-merge labels Oct 5, 2023

behzad-mir force-pushed the Dev-Stateless-CNI branch 2 times, most recently from 427ed8d to 6c04d2d Compare October 5, 2023 02:54

behzad-mir requested a review from a team as a code owner October 18, 2023 20:39

behzad-mir requested a review from vakalapa October 18, 2023 20:39

behzad-mir force-pushed the Dev-Stateless-CNI branch 4 times, most recently from 1c40e0b to bfebb47 Compare October 18, 2023 23:47

behzad-mir force-pushed the Dev-Stateless-CNI branch 2 times, most recently from bf03466 to 8f2cedf Compare November 1, 2023 20:08

behzad-mir removed the do-not-merge label Nov 1, 2023

behzad-mir requested review from tamilmani1989, rbtr and vipul-21 November 1, 2023 20:09

behzad-mir force-pushed the Dev-Stateless-CNI branch 5 times, most recently from 87d6ab0 to 85b217a Compare November 2, 2023 22:56

jaer-tsun reviewed Nov 3, 2023

View reviewed changes

behzad-mir force-pushed the Dev-Stateless-CNI branch from 54aacbd to 53969b9 Compare November 28, 2023 23:55

tamilmani1989 previously approved these changes Nov 29, 2023

View reviewed changes

rbtr requested changes Dec 7, 2023

View reviewed changes

behzad-mir dismissed tamilmani1989’s stale review via 8f26921 December 7, 2023 22:12

behzad-mir requested review from rbtr and tamilmani1989 December 7, 2023 22:31

behzad-mir and others added 9 commits December 8, 2023 10:14

🌈 feat: adding flags for stateless cni (#2103)

6a541da

feat: stateless cni

🌈 feat: StatelessCNI: Applying stateless CNI mode changes in network …

a96397a

…package. (#2197) * Apllying stateless CNI mode in network package. * Addresing the commetns.

feat: create stateless cni binary for swift (#2275)

5351eac

enabling CNS telemetry

41ff105

Master rebase changes

7660819

CNI Telemetry enabled on CNS

2e5bac4

Stateless CNI changes.

6c15348

making change to CNSendpointStorePath

eefd73a

behzad-mir force-pushed the Dev-Stateless-CNI branch from ae573a2 to ae68d79 Compare December 8, 2023 18:20

tamilmani1989 previously approved these changes Dec 8, 2023

View reviewed changes

behzad-mir enabled auto-merge (squash) December 8, 2023 21:18

Updating makefile to avoid creating statless CNI release.

9344500

behzad-mir dismissed tamilmani1989’s stale review via 9344500 December 8, 2023 21:47

behzad-mir force-pushed the Dev-Stateless-CNI branch from ae68d79 to 9344500 Compare December 8, 2023 21:47

rbtr approved these changes Dec 8, 2023

View reviewed changes

tamilmani1989 approved these changes Dec 11, 2023

View reviewed changes

behzad-mir merged commit c4fe3a8 into master Dec 12, 2023
79 checks passed

behzad-mir deleted the Dev-Stateless-CNI branch December 12, 2023 00:15

behzad-mir mentioned this pull request Jun 26, 2024

Azure CNI: timed out locking store #2817

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Dev stateless cni #2276

feat: Dev stateless cni #2276

behzad-mir commented Oct 5, 2023 •

edited

Loading

vipul-21 commented Oct 5, 2023

azure-pipelines bot commented Oct 5, 2023

jaer-tsun Nov 3, 2023

behzad-mir Nov 6, 2023

jaer-tsun Nov 3, 2023

behzad-mir Nov 6, 2023

jaer-tsun Nov 3, 2023

behzad-mir Nov 6, 2023

behzad-mir Nov 6, 2023

tamilmani1989 Nov 27, 2023

rbtr left a comment

rbtr Dec 7, 2023

behzad-mir Dec 7, 2023

rbtr Dec 7, 2023

behzad-mir Dec 7, 2023

rbtr left a comment

behzad-mir commented Dec 11, 2023

azure-pipelines bot commented Dec 11, 2023

		endpointStoreLocationLinux = "/var/run/azure-cns/"
		endpointStoreLocationWindows = "/k/azurecns/"

feat: Dev stateless cni #2276

feat: Dev stateless cni #2276

Conversation

behzad-mir commented Oct 5, 2023 • edited Loading

vipul-21 commented Oct 5, 2023

azure-pipelines bot commented Oct 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rbtr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rbtr left a comment

Choose a reason for hiding this comment

behzad-mir commented Dec 11, 2023

azure-pipelines bot commented Dec 11, 2023

behzad-mir commented Oct 5, 2023 •

edited

Loading