[NPM] Modified NPM Unit Tests #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm/pkg/controlplane/controllers/v2/networkPolicyController_test.go
Outdated
Show resolved
Hide resolved
huntergregory
previously approved these changes
Nov 21, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Pull request closed due to inactivity. |
rejain456
force-pushed
the
jainriya/npmUnitTestFix
branch
from
3cc100f to
9e3d517
Compare
huntergregory
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
A few of the windows npm unit tests were failing in the pipelines
Issue Fixed:
This pr adds a fix to resolve the unit tests failing issue.
Background:
The NPM Lite PR introduced ingress and egress policy types to mock policy creation in the networkPolicyController_test.go file, enabling all the tests to go through the translatePolicy function. However, since the policy contained named ports, the Windows tests failed. This PR addresses the issue by implementing a fix to handle named ports appropriately for Windows.
Requirements:
Notes: