Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip check-log-errors in cilium connectivity #3332

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

camrynl
Copy link
Contributor

@camrynl camrynl commented Jan 7, 2025

Reason for Change:
check-log-errors sometimes catches on transient errors and fails the entire connectivity test suite
this test case is skipped in other pipelines, adding skip to ACN until issue is resolved
opened a GH issue in cilium - cilium/cilium#36992

Issue Fixed:

Requirements:

Notes:

@camrynl camrynl requested a review from a team as a code owner January 7, 2025 19:42
@camrynl camrynl requested a review from sheylatrudo January 7, 2025 19:42
@camrynl
Copy link
Contributor Author

camrynl commented Jan 7, 2025

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vipul-21
Copy link
Contributor

Couple of things on the PR:

  • Can we please update the description with the cilium issue link you opened.
  • Is there a way we can retry the test in case of log failures rather than skipping it? The concern here is what if we have an issue which is not covered by the test and is reported in logs only ? Just curious, how frequently does this check fail ?

@vipul-21
Copy link
Contributor

Is there a way we can retry the test in case of log failures rather than skipping it?

We are already skipping in our cilium release pipeline.

@camrynl camrynl added this pull request to the merge queue Jan 15, 2025
@camrynl
Copy link
Contributor Author

camrynl commented Jan 15, 2025

Will continue tracking github issue to see if we will eventually be able to reallow this case

Merged via the queue into master with commit fa1fb09 Jan 15, 2025
198 checks passed
@camrynl camrynl deleted the camrynl/skiplogerr branch January 15, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants