Add default route only when skipdefaultroutes flag to false in dualni… #4043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tamilmani1989
approved these changes
Oct 1, 2025
tamilmani1989
requested changes
Oct 1, 2025
Comment on lines
+164
to
+165
| func (m *Multitenancy) addDefaultRouteToGateway(gwStr string, epInfo *network.EndpointInfo, result *network.InterfaceInfo) error { | ||
| gw := net.ParseIP(gwStr) |
There was a problem hiding this comment.
Suggested change
| func (m *Multitenancy) addDefaultRouteToGateway(gwStr string, epInfo *network.EndpointInfo, result *network.InterfaceInfo) error { | |
| gw := net.ParseIP(gwStr) | |
| func (m *Multitenancy) addDefaultRoute(gwStr string, epInfo *network.EndpointInfo, result *network.InterfaceInfo) error { | |
| gw := net.ParseIP(gwStr) |
| result.Routes = append(result.Routes, network.RouteInfo{Dst: dstIP, Gw: gwIP}) | ||
| // only set default route when skipDefaultRoutes is false to avoid duplicated default routes given to HNS | ||
| if !epInfo.SkipDefaultRoutes { | ||
| if err := m.addDefaultRouteToGateway( |
There was a problem hiding this comment.
Suggested change
| if err := m.addDefaultRouteToGateway( | |
| if err := m.addDefaultRoute( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…c scenario
Reason for Change:
This PR is to add the default route only when skipdefaultroutes flag set to false in dualnic scenario
Issue Fixed:
Requirements:
Notes: