Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 18, 2025

Reason for Change:
This PR attempted to improve logging messages across network and CNS components by adding contextual identifiers. However, based on review feedback, the changes increased verbosity without adding meaningful value, making logs harder to read rather than more useful.

Issue Fixed:
N/A - PR being closed without merge

Changes:

This PR made the following changes that are not being merged:

  • Expanded acronyms (e.g., "NC" → "Network Container", "IP" → "IP Address")
  • Made messages longer without adding information density
  • Rewording that restated obvious or redundant information

Examples of problematic changes:

  • "failed to get nc version list from nmagent" → "Failed to retrieve network container version list from NMAgent" (longer, harder to read)
  • "sync host error" → "Failed to synchronize host network container versions with NMAgent" (longer, redundant)

Feedback Received:
Logs need to be concise and information-dense. Longer messages are worse for readability. Future improvements should focus on adding missing context (like IDs where absent) rather than rewording or expanding well-understood acronyms.

Requirements:

Notes:
PR is being closed. Will work on smaller, more focused changes that add actual contextual information without unnecessary verbosity.

Original prompt

Create a PR to add more descriptive logging messages


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 3 commits November 18, 2025 18:28
… and CNS components

Co-authored-by: prmathur-microsoft <20328314+prmathur-microsoft@users.noreply.github.com>
Co-authored-by: prmathur-microsoft <20328314+prmathur-microsoft@users.noreply.github.com>
…omponents

Co-authored-by: prmathur-microsoft <20328314+prmathur-microsoft@users.noreply.github.com>
Copilot AI changed the title [WIP] Add more descriptive logging messages chore: enhance logging messages with contextual identifiers Nov 18, 2025
Copilot finished work on behalf of prmathur-microsoft November 18, 2025 18:42
Copy link
Member

@prmathur-microsoft prmathur-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments test

Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for a couple of places where an NC or endpoint ID is added, this isn't enhancing anything.
rewording the logs to be more verbose, restating obvious, redundant, or recently logged things, replacing "NC" with "Network Container" or "IP" with "IP Address"... are all things that do not actually improve log quality or readability.

@prmathur-microsoft
Copy link
Member

except for a couple of places where an NC or endpoint ID is added, this isn't enhancing anything. rewording the logs to be more verbose, restating obvious, redundant, or recently logged things, replacing "NC" with "Network Container" or "IP" with "IP Address"... are all things that do not actually improve log quality or readability.

As stated in the description of the PR the purpose was to reword and increase readability.
"Changes maintain identical line count (55 insertions, 55 deletions). All modified packages compile successfully. No functional changes—purely improves log message clarity and debuggability"

@rbtr
Copy link
Collaborator

rbtr commented Nov 18, 2025

Yes, I read that. I think that is not the net effect of these changes, despite Copilot confidently saying so. A couple samples:

before change quality
"failed to get nc version list from nmagent" "Failed to retrieve network container version list from NMAgent" longer, somehow harder to read
"sync host error %(err)" "Failed to synchronize host network container versions with NMAgent: %(err)" longer, redundant, harder to read

Also, "IP" -> "IP Address" - redundant, longer
"NC" -> "Network Container" - redundant, longer

For logs, longer is not better. Writing out well understand acronyms is not better.

Logs need to be concise and information dense. More to read is actually worse for readability.

@prmathur-microsoft
Copy link
Member

@copilot close this PR.
I'll work on opening smaller chunks of edit in code.

Copy link
Contributor Author

Copilot AI commented Nov 24, 2025

@copilot close this PR.
I'll work on opening smaller chunks of edit in code.

I understand. Closing this PR as requested. The feedback from @rbtr about keeping logs concise and information-dense is valid - expanding acronyms like "NC" to "Network Container" or "IP" to "IP Address" added verbosity without improving clarity. Future improvements should focus on adding missing context (like IDs where they're absent) rather than rewording existing messages.

Copilot AI changed the title chore: enhance logging messages with contextual identifiers chore: close PR - logging changes added verbosity without value Nov 24, 2025
Copilot finished work on behalf of prmathur-microsoft November 24, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants