-
Notifications
You must be signed in to change notification settings - Fork 261
invalidate deployment state based on resource group existence checks #6281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invalidate deployment state based on resource group existence checks #6281
Conversation
|
@weikanglim will this be the new behavior? When rg is manually deleted, |
|
@rajeshkamal5050 The new behavior is as follows: When resource groups are deleted outside of azd, @JeffreyCA I left a comment on #6207 to fix the underlying behavior without changing |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
* Initial plan * Create changelog for v1.22.0 release Co-authored-by: hemarina <104857065+hemarina@users.noreply.github.com> * Add additional PRs #6282, #6180, #6281 to v1.22.0 changelog Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com> * Add PR #6232 to v1.22.0 changelog Co-authored-by: hemarina <104857065+hemarina@users.noreply.github.com> * Update cli/azd/CHANGELOG.md --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: hemarina <104857065+hemarina@users.noreply.github.com> Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
This change factors in quick resource-group existence checks as heuristics to the deployment state calculation prior to skipping the deployment.
With this change, when resource groups are deleted outside of azd,
azd provisionwill detect this and continue with provisioning without skipping.The resource group check leverages the most lightweight possible HTTP
HEADcall to the relevant ARM endpoint, and is measured to add ~100ms for a single resource group. Given that most deployments likely have 1-2 resource groups, it is then expected that the overall latency increase is <0.2 seconds overall.Note that only resource groups created by the deployment are checked for. Existing resource groups associated to resources deployed into are not factored in.
Fixes #3771
Would supersede #5667