remove magic string, fix log formatting (#908)

Azure · Jan 10, 2023 · a5a8132 · a5a8132
1 parent 1fcb262
commit a5a8132
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/DurableWorker/DurableController.cs b/src/DurableWorker/DurableController.cs
@@ -31,7 +31,7 @@ internal class DurableController
         private readonly ILogger _logger;
 
         private bool isExternalDFSdkEnabled { get; } =
-            PowerShellWorkerConfiguration.GetBoolean("ExternalDurablePowerShellSDK") ?? false;
+            PowerShellWorkerConfiguration.GetBoolean(Utils.ExternalDurableSdkEnvVariable) ?? false;
 
         public DurableController(
             DurableFunctionInfo durableDurableFunctionInfo,
@@ -81,7 +81,7 @@ private void tryEnablingExternalSDK()
             else if (isExternalSdkLoaded)
             {
                 // External SDK is in the session, but customer did not explicitly enable it. Report the potential of runtime errors.
-                _logger.Log(isUserOnlyLog: false, LogLevel.Error, String.Format(PowerShellWorkerStrings.PotentialDurableSDKClash, Utils.ExternalDurableSdkName));
+                _logger.Log(isUserOnlyLog: false, LogLevel.Error, String.Format(PowerShellWorkerStrings.PotentialDurableSDKClash, Utils.ExternalDurableSdkName, Utils.ExternalDurableSdkEnvVariable));
             }
         }
 

diff --git a/src/Utility/Utils.cs b/src/Utility/Utils.cs
@@ -28,6 +28,7 @@ internal class Utils
         internal const string ExternalDurableSdkName = "AzureFunctions.PowerShell.Durable.SDK";
         internal const string IsOrchestrationFailureKey = "IsOrchestrationFailure";
         internal const string TracePipelineObjectCmdlet = "Microsoft.Azure.Functions.PowerShellWorker\\Trace-PipelineObject";
+        internal const string ExternalDurableSdkEnvVariable = "ExternalDurablePowerShellSDK";
 
         internal readonly static object BoxedTrue = (object)true;
         internal readonly static object BoxedFalse = (object)false;