Add LeasesTableName to SqlTriggerAttribute #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyzhang929
requested review from
Charles-Gagnon,
chlafreniere,
MaddyDev and
VasuBhog
as code owners
Charles-Gagnon
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Make sure you update the docs as well, https://github.com/Azure/azure-functions-sql-extension/blob/release/trigger/docs/TriggerBinding.md#az_funcleases_ for sure.
|
Will update the docs in a separate PR - added it as a task to the original issue: #882. |
MaddyDev
added a commit
that referenced
this pull request
Aug 31, 2023
* Revert "Remove trigger binding for GA release (#732)" (#733) This reverts commit 9713259. * vBump release/trigger 2.* -> 3.* (#738) * Add JObject support for SQL trigger (#722) * add support for jobject and js, ps, python samples * use utils JsonSerializeObject + comment * Update src/TriggerBinding/SqlTriggerBindingProvider.cs Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * fix unit test + pylint --------- Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * Fix trigger connection not being retried when connection is closed (#731) * Add Privacy Statement to README and telemetry message (#751) * Add link to privacy statement * Add privacy link to output message * add to output message * Fix typos (cherry picked from commit a9565f7) * enable trigger oop (#750) * add sqltrigger attribute * add SqlChange type * enable oop test * add check * fix the null reference * use GetLogger * Enable debug logging for Python and PS samples (#754) * enable debug logging for ps and python samples * enable debug logs for js samples * Add docs & logging information for Leases table info (#756) * Add ProductsTriggerWithValidation tests for Python, JS, PS (#753) * add js, py, ps ProductsTriggerWithValidation test * fix test + missing file * Further clarifications to trigger retry docs (#770) * Further clarifications to trigger retry docs * Update description * increase timeout to 120 minutes (#776) * Enable more tests for OOP trigger (#777) * add more oop test samples * update logger * bump jackson dependency (#782) * Add detailed trigger docs (#780) * Filter out more default telemetry properties (cherry picked from commit d6ea6d7) * bring back trigger text * Fixes * Add SQLTrigger annotation to java library (#783) * add SQLTrigger annotation to java library * remove default values * use enum for commandtype * Disable CSX trigger tests * fix regex for java library version (#788) * Adding rest of Trigger integration tests for Python, PS, JS (#763) * add js, py, ps ProductsTriggerWithValidation test * fix test + missing file * add tests * remove extra comments + powershell compress * update comment * Skip more trigger tests for CSX (#791) * Introduce Target Based Scaling (#598) * Refactor SqlTriggerListener scaling to SqlTriggerMetricsProvider and SqlTriggerScaleMonitor * Create SqlTriggerTargetScaler * Refactor unit tests * Refactor to include common queries for scaling and listener class to SqlTriggerUtils * Add doc comments for scaling classes * Update src/TriggerBinding/SqlTriggerTargetScaler.cs Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * Fix log statement * Update WebJobs package * Update nuget.config * Address review comments * Address review comments pt2 * Update src/TriggerBinding/SqlTriggerTargetScaler.cs Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * Address comments, test failures * Fix packages lock file * Fix error message * Address comments and test failures * Apply suggestions from code review Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * Change in documentation * Fix log level --------- Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * Enable trace level logging for tests (#795) * Enable trace level logging for tests * one more * Add java trigger samples (#793) * add java trigger samples * update test-java * add SqlChangeProduct type * add rest of tests * fix polling interval test * Fix up performance tests & enable schedule (#799) * Minor trigger doc updates (#800) * Minor trigger doc updates * fix * enable rest of the trigger tests for oop (#798) * enable all trigger tests for OOP * undo * fix test * merge conflict * remove Java * add sample for python v2 model (#803) * Fix logs * fix compile * remove delegate (#809) Signed-off-by: Maddy Koripalli <makoripa@microsoft.com> * add csx trigger samples (#806) * add trigger samples for csx * enable csx tests * add copy trigger sample * use utils.josnserialize * separate utils file * reuse utils from sql extension * remove deleted references * Cleanup trigger logging (#808) * Cleanup trigger logging * more * fix compile * Default log level of debug * Fix scale monitor tests * [Trigger] Update from main (#820) * update java library 0.1.1 -> 1.0.0 (#804) * Pin Node version to 18.15 (#818) * Pin Node version to 18.15 * Update build pipeline * Set node modules path for all * Debug * Pass in env var * Update pipeline comments (#819) --------- Co-authored-by: Lucy Zhang <luczhan@microsoft.com> * [Trigger] Rename csharpscript and align host.json (#825) * Merge branch 'main' into release/trigger # Conflicts: # docs/SetupGuide_DotnetCSharpScript.md # samples/samples-csharp/host.json # test/Microsoft.Azure.WebJobs.Extensions.Sql.Tests.csproj * Move triggers * Fix java version in setup guide (#821) * Refactor integration tests (#813) * create database once * fix compat level test * fix compat + logs * start func host in the beginning * fix change tracking * fix tests * fix tests * add CSharpscript and fix change tracking * set port * update xunit analyzers & temp skip failling tests * update port from fixture * pass console writeline as logger * enable identity tests * fix case sensitive tests + temp disable identity * fix indent * AddProductWithIdentityColumnIncluded fix * AddProductWithIdentityColumnIncluded * cleanup * remove extra fixture * default port * fix csx * Clean csx samples (#812) * sql attribute not needed * simplify the folder structure for csx * add local.settings.json * rename folders in proj file * clean up logs and unused * remove TriggerSamples folder * update trigger docs for csx * Fix compilation error (#835) * Add retry for Trigger tests (#836) * add retry logic * fix the csx compilation error * use xRetry * replace with RetryTheory * add diagnostic messages to logs * Update Trigger Binding set up in SetupGuide_DotnetOutOfProc.md (#845) * Update SetupGuide_DotnetOutOfProc.md * fixes * Update Trigger Binding set up in SetupGuide_Java.md (#846) * Update SetupGuide_Java.md * fix annotation * Update SetupGuide_Javascript.md (#847) * Update SetupGuide_Javascript.md * fix toc * FIx perf pipeline (#838) * dont start func host in fixture for perf * don't use fixture in perf test * finally block * Update SetupGuide_PowerShell.md (#848) * Update SetupGuide_Python.md (#849) * enable test TriggerWithException (#801) * enable the TriggerWithException test * update comment * remove logger delegate * fix error * add retry * remove Java test and try --------- Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * Add additional check for closed/broken connection errors (#862) * add timestamp to global state table for lease table cleanup (#861) * add LastAccessTime column to GlobalState * update docs with clean up scripts * update createtable * add comments * refine comments * fix script error * add print * add test to check LastAccessTime column creation for existing triggers (#865) * add LastAccessTime column to GlobalState * update docs with clean up scripts * update createtable * add comments * refine comments * fix script error * add print * add test * fix test error * use constants * Merge latest from main into trigger (#866) * Fix the race condition by adding the extension reference to build first. (#839) * fix the correct path separator * add the extension ref to avoid race condition * format files * pack and copy the sql nupkg to local-packages after build (#853) * copy to local packages before build * AfterTargets since package is created after build * make sure pack runs after build * address comments * Remove doc/sample references to preview bundle (#744) * Remove doc/sample references to preview bundle * Few more * undo * Powershell -> PowerShell * fix version * use scriptdom nuget (#864) * Revert "Remove doc/sample references to preview bundle (#744)" This reverts commit d7cd728. * Fix nuget package versioning --------- Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com> Co-authored-by: Lucy Zhang <luczhan@microsoft.com> * Revert "Remove doc/sample references to preview bundle (#744)" This reverts commit d7cd728. * add troubleshooting information to the overview doc (#871) * add troubleshooting section * update format * Update docs/BindingsOverview.md Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * Update docs/BindingsOverview.md Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> --------- Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * clarifying view change tracking command (#873) * Add sql trigger test for different data types (#876) * add productcolumntypestriggertest * try running only csharp * try running js * comment out column values check temporarily * skip date and byte checks * fix build error * skip byte check * remove date/time, add back binary * fix build error * remove only binary check * remove only nchar and nvarchar * check equality of nchar and nvarchar * fix tests * change nchar to test * Bump Version of Grpc.Net.Client (#877) * Bump version of Grpc.Net.Client * Bump grpc.net.client to latest * Update packages.lock * Add to Directory.Packages.props * Fix code coverage in trigger branch (#880) * run only csharp test task * comment out trigger tests * don't start func hosts in the beginning * start three functions in beginning * start only csharp host * fix build error * start both csharp and java hosts * start only csharp and oop hosts * add logging for disposefunctionhosts * start only csharp host * revert commented out code * add comment * Fix schema parse error when using reserved keys as table names (#881) * bracketed name for reserved words as table name * add test * add tests * fix csx test * enable test only for csharp * fix TableNotPresentTest * revert GetUserTableIdAsync change * refactor GetUserTableIdAsync * comment out Java test * refactor code to use SqlObject * Add LeasesTableName to SqlTriggerAttribute (#893) * addLeasesTableNameSetting to SqlTriggerAttribute * add provider test * add samples * remove setting * add new constructor * fix metrics provider * add integration test * fix oop * fix test * cleanup + pr comments * quote escape leasestablename * Add leasesTableName to SqlTrigger Java annotation (#897) * add leasestablename to java sqltrigger * add default value for commandtype * remove sample * update java library to 2.1.0-preview (#899) * Update docs with LeasesTableName (#898) * add leasestablename to docs * fix links * GetLeaseLockedRows for debug logging (#900) * add isLeaseLocked into the getchanges query * add log message * add debug logging for row counts * update log msg * create a separate query for getting the locked rows * update ver name * update * remove user table join * unused var * correct xml info * address comments * remove extra line * dont throw * Update src/TriggerBinding/SqlTableChangeMonitor.cs Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> --------- Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * rename leasesTableName to bracketedLeasesTableName (#902) * rename leasesTableName to bracketedLeasesTableName * merge error * [Trigger] Sync with main (#906) * Bump Version of Grpc.Net.Client (#877) * Bump version of Grpc.Net.Client * Bump grpc.net.client to latest * Update packages.lock * Add to Directory.Packages.props * Update GetProducts.js (#884) Corrected input model so it works * Bump word-wrap from 1.2.3 to 1.2.4 in /samples/samples-js (#885) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump word-wrap from 1.2.3 to 1.2.4 in /test/Integration/test-js (#886) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update dependencies (#887) * update all dependencies to latest versions * revert xunit package update * undo * test * restoreArguments * --no-restore * force-evaluate * noCache * revert xunit update * undo exception change * Update docs with details about output binding columns (#889) * update sdk and xunit (#890) * package lock updates * restore packages * merge conflicts * exclusing oop test for timeout issue * remove retrytheory * add oop * use TrySetResult * revert back to RetryTheory --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com> Co-authored-by: Taigh Hawkins <taigh.hawkins@cloud-trade.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * undo logging deletes * uno default * update perf.yml --------- Signed-off-by: Maddy Koripalli <makoripa@microsoft.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> Co-authored-by: Lucy Zhang <luczhan@microsoft.com> Co-authored-by: AmeyaRele <35621237+AmeyaRele@users.noreply.github.com> Co-authored-by: Drew Skwiers-Koballa <dzsquared@users.noreply.github.com> Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com> Co-authored-by: Taigh Hawkins <taigh.hawkins@cloud-trade.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MaddyDev
added a commit
that referenced
this pull request
Nov 1, 2023
* Revert "Remove trigger binding for GA release (#732)" (#733) This reverts commit 9713259. * vBump release/trigger 2.* -> 3.* (#738) * Add JObject support for SQL trigger (#722) * add support for jobject and js, ps, python samples * use utils JsonSerializeObject + comment * Update src/TriggerBinding/SqlTriggerBindingProvider.cs Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * fix unit test + pylint --------- Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * Fix trigger connection not being retried when connection is closed (#731) * Add Privacy Statement to README and telemetry message (#751) * Add link to privacy statement * Add privacy link to output message * add to output message * Fix typos (cherry picked from commit a9565f7) * enable trigger oop (#750) * add sqltrigger attribute * add SqlChange type * enable oop test * add check * fix the null reference * use GetLogger * Enable debug logging for Python and PS samples (#754) * enable debug logging for ps and python samples * enable debug logs for js samples * Add docs & logging information for Leases table info (#756) * Add ProductsTriggerWithValidation tests for Python, JS, PS (#753) * add js, py, ps ProductsTriggerWithValidation test * fix test + missing file * Further clarifications to trigger retry docs (#770) * Further clarifications to trigger retry docs * Update description * increase timeout to 120 minutes (#776) * Enable more tests for OOP trigger (#777) * add more oop test samples * update logger * bump jackson dependency (#782) * Add detailed trigger docs (#780) * Filter out more default telemetry properties (cherry picked from commit d6ea6d7) * bring back trigger text * Fixes * Add SQLTrigger annotation to java library (#783) * add SQLTrigger annotation to java library * remove default values * use enum for commandtype * Disable CSX trigger tests * fix regex for java library version (#788) * Adding rest of Trigger integration tests for Python, PS, JS (#763) * add js, py, ps ProductsTriggerWithValidation test * fix test + missing file * add tests * remove extra comments + powershell compress * update comment * Skip more trigger tests for CSX (#791) * Introduce Target Based Scaling (#598) * Refactor SqlTriggerListener scaling to SqlTriggerMetricsProvider and SqlTriggerScaleMonitor * Create SqlTriggerTargetScaler * Refactor unit tests * Refactor to include common queries for scaling and listener class to SqlTriggerUtils * Add doc comments for scaling classes * Update src/TriggerBinding/SqlTriggerTargetScaler.cs Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * Fix log statement * Update WebJobs package * Update nuget.config * Address review comments * Address review comments pt2 * Update src/TriggerBinding/SqlTriggerTargetScaler.cs Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * Address comments, test failures * Fix packages lock file * Fix error message * Address comments and test failures * Apply suggestions from code review Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * Change in documentation * Fix log level --------- Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * Enable trace level logging for tests (#795) * Enable trace level logging for tests * one more * Add java trigger samples (#793) * add java trigger samples * update test-java * add SqlChangeProduct type * add rest of tests * fix polling interval test * Fix up performance tests & enable schedule (#799) * Minor trigger doc updates (#800) * Minor trigger doc updates * fix * enable rest of the trigger tests for oop (#798) * enable all trigger tests for OOP * undo * fix test * merge conflict * remove Java * add sample for python v2 model (#803) * Fix logs * fix compile * remove delegate (#809) Signed-off-by: Maddy Koripalli <makoripa@microsoft.com> * add csx trigger samples (#806) * add trigger samples for csx * enable csx tests * add copy trigger sample * use utils.josnserialize * separate utils file * reuse utils from sql extension * remove deleted references * Cleanup trigger logging (#808) * Cleanup trigger logging * more * fix compile * Default log level of debug * Fix scale monitor tests * [Trigger] Update from main (#820) * update java library 0.1.1 -> 1.0.0 (#804) * Pin Node version to 18.15 (#818) * Pin Node version to 18.15 * Update build pipeline * Set node modules path for all * Debug * Pass in env var * Update pipeline comments (#819) --------- Co-authored-by: Lucy Zhang <luczhan@microsoft.com> * [Trigger] Rename csharpscript and align host.json (#825) * Merge branch 'main' into release/trigger # Conflicts: # docs/SetupGuide_DotnetCSharpScript.md # samples/samples-csharp/host.json # test/Microsoft.Azure.WebJobs.Extensions.Sql.Tests.csproj * Move triggers * Fix java version in setup guide (#821) * Refactor integration tests (#813) * create database once * fix compat level test * fix compat + logs * start func host in the beginning * fix change tracking * fix tests * fix tests * add CSharpscript and fix change tracking * set port * update xunit analyzers & temp skip failling tests * update port from fixture * pass console writeline as logger * enable identity tests * fix case sensitive tests + temp disable identity * fix indent * AddProductWithIdentityColumnIncluded fix * AddProductWithIdentityColumnIncluded * cleanup * remove extra fixture * default port * fix csx * Clean csx samples (#812) * sql attribute not needed * simplify the folder structure for csx * add local.settings.json * rename folders in proj file * clean up logs and unused * remove TriggerSamples folder * update trigger docs for csx * Fix compilation error (#835) * Add retry for Trigger tests (#836) * add retry logic * fix the csx compilation error * use xRetry * replace with RetryTheory * add diagnostic messages to logs * Update Trigger Binding set up in SetupGuide_DotnetOutOfProc.md (#845) * Update SetupGuide_DotnetOutOfProc.md * fixes * Update Trigger Binding set up in SetupGuide_Java.md (#846) * Update SetupGuide_Java.md * fix annotation * Update SetupGuide_Javascript.md (#847) * Update SetupGuide_Javascript.md * fix toc * FIx perf pipeline (#838) * dont start func host in fixture for perf * don't use fixture in perf test * finally block * Update SetupGuide_PowerShell.md (#848) * Update SetupGuide_Python.md (#849) * enable test TriggerWithException (#801) * enable the TriggerWithException test * update comment * remove logger delegate * fix error * add retry * remove Java test and try --------- Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * Add additional check for closed/broken connection errors (#862) * add timestamp to global state table for lease table cleanup (#861) * add LastAccessTime column to GlobalState * update docs with clean up scripts * update createtable * add comments * refine comments * fix script error * add print * add test to check LastAccessTime column creation for existing triggers (#865) * add LastAccessTime column to GlobalState * update docs with clean up scripts * update createtable * add comments * refine comments * fix script error * add print * add test * fix test error * use constants * Merge latest from main into trigger (#866) * Fix the race condition by adding the extension reference to build first. (#839) * fix the correct path separator * add the extension ref to avoid race condition * format files * pack and copy the sql nupkg to local-packages after build (#853) * copy to local packages before build * AfterTargets since package is created after build * make sure pack runs after build * address comments * Remove doc/sample references to preview bundle (#744) * Remove doc/sample references to preview bundle * Few more * undo * Powershell -> PowerShell * fix version * use scriptdom nuget (#864) * Revert "Remove doc/sample references to preview bundle (#744)" This reverts commit d7cd728. * Fix nuget package versioning --------- Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com> Co-authored-by: Lucy Zhang <luczhan@microsoft.com> * Revert "Remove doc/sample references to preview bundle (#744)" This reverts commit d7cd728. * add troubleshooting information to the overview doc (#871) * add troubleshooting section * update format * Update docs/BindingsOverview.md Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * Update docs/BindingsOverview.md Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> --------- Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * clarifying view change tracking command (#873) * Add sql trigger test for different data types (#876) * add productcolumntypestriggertest * try running only csharp * try running js * comment out column values check temporarily * skip date and byte checks * fix build error * skip byte check * remove date/time, add back binary * fix build error * remove only binary check * remove only nchar and nvarchar * check equality of nchar and nvarchar * fix tests * change nchar to test * Bump Version of Grpc.Net.Client (#877) * Bump version of Grpc.Net.Client * Bump grpc.net.client to latest * Update packages.lock * Add to Directory.Packages.props * Fix code coverage in trigger branch (#880) * run only csharp test task * comment out trigger tests * don't start func hosts in the beginning * start three functions in beginning * start only csharp host * fix build error * start both csharp and java hosts * start only csharp and oop hosts * add logging for disposefunctionhosts * start only csharp host * revert commented out code * add comment * Fix schema parse error when using reserved keys as table names (#881) * bracketed name for reserved words as table name * add test * add tests * fix csx test * enable test only for csharp * fix TableNotPresentTest * revert GetUserTableIdAsync change * refactor GetUserTableIdAsync * comment out Java test * refactor code to use SqlObject * Add LeasesTableName to SqlTriggerAttribute (#893) * addLeasesTableNameSetting to SqlTriggerAttribute * add provider test * add samples * remove setting * add new constructor * fix metrics provider * add integration test * fix oop * fix test * cleanup + pr comments * quote escape leasestablename * Add leasesTableName to SqlTrigger Java annotation (#897) * add leasestablename to java sqltrigger * add default value for commandtype * remove sample * update java library to 2.1.0-preview (#899) * Update docs with LeasesTableName (#898) * add leasestablename to docs * fix links * GetLeaseLockedRows for debug logging (#900) * add isLeaseLocked into the getchanges query * add log message * add debug logging for row counts * update log msg * create a separate query for getting the locked rows * update ver name * update * remove user table join * unused var * correct xml info * address comments * remove extra line * dont throw * Update src/TriggerBinding/SqlTableChangeMonitor.cs Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> --------- Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * rename leasesTableName to bracketedLeasesTableName (#902) * rename leasesTableName to bracketedLeasesTableName * merge error * update ReadAsync with Read * replace ExecuteReaderAsync * remove missed ExecuteReaderAsync * remove ReadAsync * remove async from updated methods * merge main * fix perf uml * resolve doc conflicts * resolve remaining conflicts * fix incomplete merge --------- Signed-off-by: Maddy Koripalli <makoripa@microsoft.com> Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> Co-authored-by: Lucy Zhang <luczhan@microsoft.com> Co-authored-by: AmeyaRele <35621237+AmeyaRele@users.noreply.github.com> Co-authored-by: Drew Skwiers-Koballa <dzsquared@users.noreply.github.com> Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #882. Adding LeasesTableName option to the SqlTriggerAttribute will prevent two leases tables from being created during a slot swap.
If the LeasesTableName is not included, we default back to using the host id to generate the lease table name.