This repository was archived by the owner on Mar 20, 2019. It is now read-only.
Open
Conversation
Replaced deprecated API calls in urlEncode/urlDecode Use APIs for generating CSV tag list instead of manually concatenating Replaced deprecated NSURLConnection with NSURLSession in SBURLConnection
lumaxis
reviewed
Oct 18, 2018
| if(!theConnection && completion) | ||
|
|
||
| NSURLSession* session = [NSURLSession sharedSession]; | ||
| NSURLSessionDataTask* task = [session dataTaskWithRequest:request completionHandler:^(NSData * _Nullable c_data, NSURLResponse * _Nullable c_response, NSError * _Nullable c_error) { |
There was a problem hiding this comment.
I'm not a big fan of the variable names here. For one, they are not using the regular casing and also, they are not very descriptive. In my opinion, they should use more verbose and descriptive names.
| } | ||
|
|
||
| self->_response = (NSHTTPURLResponse*)response; | ||
| __block NSData* b_data = nil; |
iamclement
reviewed
Oct 18, 2018
| SBURLConnectionCompletion _completion; | ||
| NSMutableData *_data; | ||
| } | ||
| @interface SBURLConnection : NSObject |
There was a problem hiding this comment.
Should rename the class/file name if we are now only using NSURLSession.
iamclement
reviewed
Oct 18, 2018
|
|
||
| reg.RegistrationName = [SBNotificationHubHelper nameOfRegistration:registration]; | ||
| reg.registrationId = registration.registrationId; | ||
| reg.RegistrationId = registration.registrationId; |
There was a problem hiding this comment.
I think we should follow Apple convention on property names here so doing it the other way around, all properties' name of StoredRegistrationEntry should start with a lowercase letter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected warnings on const strings and properties
Replaced deprecated API calls in urlEncode/urlDecode
Use APIs for generating CSV tag list instead of manually concatenating
Replaced deprecated NSURLConnection with NSURLSession in SBURLConnection