Skip to content

Audit procedure for ensureRootPath #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Audit procedure for ensureRootPath #1003

merged 2 commits into from
May 22, 2025

Conversation

wupeka
Copy link
Contributor

@wupeka wupeka commented May 6, 2025

Description

Audit procedure for ensureRootPath

Checklist

  • I have read the contribution guidelines.
  • I added unit-tests to validate my changes. All unit tests are passing.
  • I have merged the latest dev branch prior to this PR submission.
  • I ran pre-commit on my changes prior to this PR submission.
  • I submitted this PR against the dev branch.

@wupeka wupeka requested a review from a team as a code owner May 6, 2025 12:53
@wupeka wupeka requested a review from danielszot May 6, 2025 12:54
Copy link

github-actions bot commented May 6, 2025

Test Results

 48 files   48 suites   30m 28s ⏱️
  4 tests   4 ✅  0 💤 0 ❌
192 runs  168 ✅ 24 💤 0 ❌

Results for commit 2ddb7a8.

♻️ This comment has been updated with latest results.

@wupeka wupeka force-pushed the wupeka/ensureRootPath branch from 7f8c7d0 to 5951aed Compare May 12, 2025 07:35
Copy link
Member

@jepio jepio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please include module tests with this PR?

@wupeka wupeka force-pushed the wupeka/ensureRootPath branch 6 times, most recently from 10b824d to ef9a5fe Compare May 19, 2025 07:37
@wupeka wupeka force-pushed the wupeka/ensureRootPath branch from ef9a5fe to 774d30e Compare May 19, 2025 11:46
@wupeka wupeka enabled auto-merge (squash) May 20, 2025 19:18
@wupeka wupeka requested a review from jepio May 21, 2025 07:44
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wupeka wupeka force-pushed the wupeka/ensureRootPath branch from 774d30e to 2ddb7a8 Compare May 21, 2025 18:46
@wupeka wupeka merged commit e36ca42 into dev May 22, 2025
117 of 119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants