Introduce clang-tidy #878
Open
Introduce clang-tidy #878
+2,104
−616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertwoj-microsoft
changed the title
robertwoj-microsoft
force-pushed
the
compliance/clang_tidy
branch
from
b647657 to
43ecf32
Compare
robertwoj-microsoft
force-pushed
the
compliance/clang_tidy
branch
from
43ecf32 to
750e5b7
Compare
MariusNi
reviewed
Feb 18, 2025
| @@ -61,7 +61,7 @@ Result<std::string> Base64Decode(const std::string& input) | |||
|
|
|||
| for (size_t i = 0; i < input.size(); i += 4) | |||
| { | |||
| unsigned char enc[4]; | |||
| char enc[4]; | |||
MariusNi
reviewed
Feb 18, 2025
| @@ -36,10 +36,11 @@ class Engine | |||
|
|
|||
| AuditResult(const AuditResult&) = delete; | |||
| AuditResult(AuditResult&& other) noexcept | |||
| : result(other.result) | |||
| , payload(other.payload) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
This is unusual, not used anywhere else in this project.
This is C++-specific - member initialization.
There was a problem hiding this comment.
Just informational comment: putting commas in front of the initializer makes much easier to add new fields and reorder them in case of class definition changes.
robertwoj-microsoft
changed the title
5 tasks
AhmedBM
previously approved these changes
Feb 20, 2025
robertwoj-microsoft
force-pushed
the
compliance/code_formatting
branch
2 times, most recently
from
30874ce to
033c331
Compare
MariusNi
dismissed stale reviews from AhmedBM and themself
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce clang-tidy to the project. Currently it only works on the src/modules/compliance directory.
This PR depends on #873, DO NOT MERGE YET
Checklist
devbranch prior to this PR submission.devbranch.