Az.network function1 #18966

kukulkarni1 · 2022-07-18T20:53:35Z

Description

Added custom script for get traffic collector

Checklist

Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
SHOULD make the title of PR clear and informative, and in the present imperative tense.
SHOULD update ChangeLog.md file(s) appropriately
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
- Create new module from the scratch
- Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
- Create new resource type which name doesn't use module name as prefix
- Have design question before implementation
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT introduce breaking changes in Az minor release except preview version.
SHOULD NOT change version of module in pull request

src/NetworkFunction/README.md

src/NetworkFunction/custom/Get-AzNetworkFunctionAzureTrafficCollector.ps1

BethanyZhou · 2022-07-20T05:50:54Z

Could you explain what's your purpose to do this customization so that we can check whether your PR is the correct way to do so?

kukulkarni1 · 2022-07-20T15:15:22Z

Could you explain what's your purpose to do this customization so that we can check whether your PR is the correct way to do so?
There are 2 things we want to do:

Hide the 2 cmdlets Get-AzNetworkFunctionAzureTrafficCollectorsByResourceGroup and Get-AzNetworkFunctionAzureTrafficCollectorsBySubscription, and add 1 cmdlet Get-AzNetworkFunctionAzureTrafficCollector_List. We want to add 2 parameter sets, 1 is for Get and 1 is for List.
We have made Collector Policy (the child resource) as a Tracked Resource in ARM, so we need to add a new parameter Location to the cmdlet New-AzNetworkFunctionCollectorPolicy. We need to pass this property while creating a new Collector Policy, similar to how we do it for TrafficCollector (the parent resource)

BethanyZhou · 2022-07-21T02:52:58Z

Hide the 2 cmdlets Get-AzNetworkFunctionAzureTrafficCollectorsByResourceGroup and Get-AzNetworkFunctionAzureTrafficCollectorsBySubscription, and add 1 cmdlet Get-AzNetworkFunctionAzureTrafficCollector_List. We want to add 2 parameter sets, 1 is for Get and 1 is for List.

As you said, Get-AzNetworkFunctionAzureTrafficCollector_List will use Get-AzNetworkFunctionAzureTrafficCollectorsByResourceGroup and Get-AzNetworkFunctionAzureTrafficCollectorsBySubscription. The easiest way to combine them together is changing OperationId of Get-AzNetworkFunctionAzureTrafficCollectorsByResourceGroup and Get-AzNetworkFunctionAzureTrafficCollectorsBySubscription so that they will show as parameter sets of Get-AzNetworkFunctionAzureTrafficCollector directly.

OperationId AzureTrafficCollectorsBySubscription_List ->AzureTrafficCollectors_ListBySubscription and
OperationId AzureTrafficCollectorsByResourceGroup_List -> AzureTrafficCollectors_ListByResourceGroup
See example: https://cs.github.com/Azure/azure-powershell/blob/086ce98d157d5fe3513d3a4c6dc1ff9412fd06cf/src/GuestConfiguration/README.md#L57

We have made Collector Policy (the child resource) as a Tracked Resource in ARM, so we need to add a new parameter Location to the cmdlet New-AzNetworkFunctionCollectorPolicy. We need to pass this property while creating a new Collector Policy, similar to how we do it for TrafficCollector (the parent resource)

Did this change check into azure-rest-api-spec? Can we do this work just updating the commit id of swagger?

kukulkarni1 · 2022-07-21T17:43:13Z

Hide the 2 cmdlets Get-AzNetworkFunctionAzureTrafficCollectorsByResourceGroup and Get-AzNetworkFunctionAzureTrafficCollectorsBySubscription, and add 1 cmdlet Get-AzNetworkFunctionAzureTrafficCollector_List. We want to add 2 parameter sets, 1 is for Get and 1 is for List.

As you said, Get-AzNetworkFunctionAzureTrafficCollector_List will use Get-AzNetworkFunctionAzureTrafficCollectorsByResourceGroup and Get-AzNetworkFunctionAzureTrafficCollectorsBySubscription. The easiest way to combine them together is changing OperationId of Get-AzNetworkFunctionAzureTrafficCollectorsByResourceGroup and Get-AzNetworkFunctionAzureTrafficCollectorsBySubscription so that they will show as parameter sets of Get-AzNetworkFunctionAzureTrafficCollector directly.

OperationId AzureTrafficCollectorsBySubscription_List ->AzureTrafficCollectors_ListBySubscription and

OperationId AzureTrafficCollectorsByResourceGroup_List -> AzureTrafficCollectors_ListByResourceGroup
See example: https://cs.github.com/Azure/azure-powershell/blob/086ce98d157d5fe3513d3a4c6dc1ff9412fd06cf/src/GuestConfiguration/README.md#L57

I have made this change in the Readme. I see 2 cmdlets generated, is this correct?

Did this change check into azure-rest-api-spec? Can we do this work just updating the commit id of swagger?

We haven't changed our swagger. If the swagger is checked in, will we still need any customization from Powershell side for this cmdlet?
( I am removing the New-AzNetworkFunctionCollectorPolicy cmdlet for now from this PR so that this can get approved. Will create separate PR for that if needed.)

BethanyZhou · 2022-07-22T00:44:34Z

I have made this change in the Readme. I see 2 cmdlets generated, is this correct?

Yes, they should be from OperationId AzureTrafficCollectorsBySubscription_List and AzureTrafficCollectorsByResourceGroup_List. Does current Get-AzTrafficCollectors match your requirement now?

We haven't changed our swagger. If the swagger is checked in, will we still need any customization from Powershell side for this cmdlet?
( I am removing the New-AzNetworkFunctionCollectorPolicy cmdlet for now from this PR so that this can get approved. Will create separate PR for that if needed.)

it depends what change has been done in swagger side. Removing module doesn't matter in preview module. Az.NetworkFunction is 0.1.0. all module is in preview status when its version is lower than 1.0.0

kukulkarni1 · 2022-07-22T16:36:52Z

Yes, they should be from OperationId AzureTrafficCollectorsBySubscription_List and AzureTrafficCollectorsByResourceGroup_List. Does current Get-AzTrafficCollectors match your requirement now?

Yes it matches the requirement now. Just 1 question - is there a reason why this isn't part of the automated pipeline in Powershell? If this is a common scenario needed by multiple teams, is there a reason we need to do this manually and it's not automated?

it depends what change has been done in swagger side. Removing module doesn't matter in preview module. Az.NetworkFunction is 0.1.0. all module is in preview status when its version is lower than 1.0.0

Ok, we are trying to make the resource as a tracked resource in swagger. Currently it is a proxy resource. Once this is done, location property should automatically be added as per our understanding - pls correct if wrong.

BethanyZhou · 2022-07-26T00:39:10Z

Just 1 question - is there a reason why this isn't part of the automated pipeline in Powershell? If this is a common scenario needed by multiple teams, is there a reason we need to do this manually and it's not automated?

As we assume that an operation id should follow pattern {Noun}_{Verb}, so our generator recognizes AzureTrafficCollectorsBySubscription as a resource by operation id AzureTrafficCollectorsBySubscription_List. Many teams follow the pattern above to name operation id. If the team does not follow the convention, we need to do this manually.

Ok, we are trying to make the resource as a tracked resource in swagger. Currently it is a proxy resource. Once this is done, location property should automatically be added as per our understanding - pls correct if wrong.

I guess you can modify swagger by directive to make the resource as a tracked resource by far to reach your goal.

    "CollectorPolicy": {
      "type": "object",
      "properties": {
        "properties": {
          "x-ms-client-flatten": true,
          "$ref": "#/definitions/CollectorPolicyPropertiesFormat",
          "description": "Properties of the Collector Policy."
        },
        "etag": {
          "type": "string",
          "readOnly": true,
          "description": "A unique read-only string that changes whenever the resource is updated."
        },
        "systemData": {
          "allOf": [
            {
              "$ref": "#/definitions/SystemData"
            }
          ],
          "description": "Metadata pertaining to creation and last modification of the resource.",
          "readOnly": true
        }
      },
      "allOf": [
        {
          "$ref": "#/definitions/ProxyResource" --------------------> TrackedResource
        }
      ],
      "description": "Collector policy resource."
    },

kukulkarni1 · 2022-07-26T16:37:58Z

Just 1 question - is there a reason why this isn't part of the automated pipeline in Powershell? If this is a common scenario needed by multiple teams, is there a reason we need to do this manually and it's not automated?

As we assume that an operation id should follow pattern {Noun}_{Verb}, so our generator recognizes AzureTrafficCollectorsBySubscription as a resource by operation id AzureTrafficCollectorsBySubscription_List. Many teams follow the pattern above to name operation id. If the team does not follow the convention, we need to do this manually.

Ok, we are trying to make the resource as a tracked resource in swagger. Currently it is a proxy resource. Once this is done, location property should automatically be added as per our understanding - pls correct if wrong.

I guess you can modify swagger by directive to make the resource as a tracked resource by far to reach your goal.
    "CollectorPolicy": {
      "type": "object",
      "properties": {
        "properties": {
          "x-ms-client-flatten": true,
          "$ref": "#/definitions/CollectorPolicyPropertiesFormat",
          "description": "Properties of the Collector Policy."
        },
        "etag": {
          "type": "string",
          "readOnly": true,
          "description": "A unique read-only string that changes whenever the resource is updated."
        },
        "systemData": {
          "allOf": [
            {
              "$ref": "#/definitions/SystemData"
            }
          ],
          "description": "Metadata pertaining to creation and last modification of the resource.",
          "readOnly": true
        }
      },
      "allOf": [
        {
          "$ref": "#/definitions/ProxyResource" --------------------> TrackedResource
        }
      ],
      "description": "Collector policy resource."
    },

Thanks - we have made the swagger change and PR is under review: Azure/azure-rest-api-specs#19888

BethanyZhou · 2022-07-27T02:36:39Z

That's good. We have two options now.

Wait for swagger change finished. And then update the commid id in README.md.
Or modify swagger by directive of autorest.powershell.
Which one do you prefer

src/NetworkFunction/custom/Set-AzNetworkFunctionCollectorPolicy.ps1

src/NetworkFunction/custom/New-AzNetworkFunctionTrafficCollector.ps1

src/NetworkFunction/custom/New-AzNetworkFunctionCollectorPolicy.ps1

BethanyZhou · 2022-08-04T02:27:08Z

like @isra-fel said, the best way is marking Location in TrackedResource as required. Is it doable?

kukulkarni1 · 2022-08-04T16:36:27Z

like @isra-fel said, the best way is marking Location in TrackedResource as required. Is it doable?

We have time constraints since we have our public preview this month. Changing swagger again would require us to go through more review processes and would need additional testing. Is it possible to keep the customization on the powershell side? Thanks.

BethanyZhou · 2022-08-05T03:20:36Z

Looks good to me. No update-* cmdlet is expected, is it?

kukulkarni1 · 2022-08-05T17:15:18Z

Looks good to me. No update-* cmdlet is expected, is it?

Actually, the set cmdlets that we had included in the earlier commit were supposed to be the update cmdlets. I have added them again, and named them as update and also made the location property mandatory in them. Those cmdlets are used for updating the traffic collector and collector policy.

kukulkarni1 · 2022-08-11T16:18:46Z

Hi @BethanyZhou @isra-fel Is this good to be merged?

isra-fel · 2022-08-12T07:18:02Z

@kukulkarni1 Hi, can you write down a list of changes that we can put into change log?

isra-fel

Please fix these issues in examples. And don't forget to run ./build-module.ps1 to refresh doc/ folder.

  "Module","Cmdlet","Example","Line","RuleName","ProblemId","Severity","Description","Extent","Remediation"
  "NetworkFunction","Get-AzNetworkFunctionCollectorPolicy","1","1","Invalid_Parameter_Name","5011","1","Get-AzNetworkFunctionCollectorPolicy -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."
  "NetworkFunction","Get-AzNetworkFunctionTrafficCollector","2","1","Invalid_Parameter_Name","5011","1","Get-AzNetworkFunctionTrafficCollector -ResourceGroup is not a valid parameter name.","-ResourceGroup","Check validity of the parameter -ResourceGroup."
  "NetworkFunction","Get-AzNetworkFunctionTrafficCollector","3","1","Invalid_Parameter_Name","5011","1","Get-AzNetworkFunctionTrafficCollector -ResourceGroup is not a valid parameter name.","-ResourceGroup","Check validity of the parameter -ResourceGroup."
  "NetworkFunction","New-AzNetworkFunctionCollectorPolicy","1","1","Unassigned_Parameter","5013","1","New-AzNetworkFunctionCollectorPolicy -azuretrafficcollectorname must be assigned with a value.","-azuretrafficcollectorname","Assign value for the parameter -azuretrafficcollectorname."
  "NetworkFunction","New-AzNetworkFunctionCollectorPolicy","1","1","Invalid_Parameter_Name","5011","1","New-AzNetworkFunctionCollectorPolicy -atc is not a valid parameter name.","-atc","Check validity of the parameter -atc."
  "NetworkFunction","New-AzNetworkFunctionCollectorPolicy","1","1","Invalid_Parameter_Name","5011","1","New-AzNetworkFunctionCollectorPolicy -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."
  "NetworkFunction","New-AzNetworkFunctionTrafficCollector","1","1","Invalid_Parameter_Name","5011","1","New-AzNetworkFunctionTrafficCollector -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."
  "NetworkFunction","Remove-AzNetworkFunctionCollectorPolicy","1","1","Invalid_Parameter_Name","5011","1","Remove-AzNetworkFunctionCollectorPolicy -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."
  "NetworkFunction","Remove-AzNetworkFunctionTrafficCollector","1","1","Invalid_Parameter_Name","5011","1","Remove-AzNetworkFunctionTrafficCollector -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."
  "NetworkFunction","Update-AzNetworkFunctionCollectorPolicy","1","1","Unassigned_Parameter","5013","1","Update-AzNetworkFunctionCollectorPolicy -azuretrafficcollectorname must be assigned with a value.","-azuretrafficcollectorname","Assign value for the parameter -azuretrafficcollectorname."
  "NetworkFunction","Update-AzNetworkFunctionCollectorPolicy","1","1","Invalid_Parameter_Name","5011","1","Update-AzNetworkFunctionCollectorPolicy -atc is not a valid parameter name.","-atc","Check validity of the parameter -atc."
  "NetworkFunction","Update-AzNetworkFunctionCollectorPolicy","1","1","Invalid_Parameter_Name","5011","1","Update-AzNetworkFunctionCollectorPolicy -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."
  "NetworkFunction","Update-AzNetworkFunctionTrafficCollector","1","1","Invalid_Parameter_Name","5011","1","Update-AzNetworkFunctionTrafficCollector -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."
  "NetworkFunction","Update-AzNetworkFunctionTrafficCollectorTag","1","1","Invalid_Parameter_Name","5011","1","Update-AzNetworkFunctionTrafficCollectorTag -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."

kukulkarni1 · 2022-08-12T16:39:13Z

@kukulkarni1 Hi, can you write down a list of changes that we can put into change log?

Made Collector policy a tracked resource (added location property to create and update cmdlet and made it mandatory)
Change prefix of cmdlets from AzureTrafficCollector to TrafficCollector
Change operation id of list cmdlets to remove the cmdlets Get-AzNetworkFunctionAzureTrafficCollectorsByResourceGroup and Get-AzNetworkFunctionAzureTrafficCollectorsBySubscription and call them internally based on parameters provided to the cmdlet Get-AzNetworkFunctionAzureTrafficCollector_List.

kukulkarni1 · 2022-08-12T19:44:17Z

Please fix these issues in examples. And don't forget to run ./build-module.ps1 to refresh doc/ folder.

  "Module","Cmdlet","Example","Line","RuleName","ProblemId","Severity","Description","Extent","Remediation"
  "NetworkFunction","Get-AzNetworkFunctionCollectorPolicy","1","1","Invalid_Parameter_Name","5011","1","Get-AzNetworkFunctionCollectorPolicy -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."
  "NetworkFunction","Get-AzNetworkFunctionTrafficCollector","2","1","Invalid_Parameter_Name","5011","1","Get-AzNetworkFunctionTrafficCollector -ResourceGroup is not a valid parameter name.","-ResourceGroup","Check validity of the parameter -ResourceGroup."
  "NetworkFunction","Get-AzNetworkFunctionTrafficCollector","3","1","Invalid_Parameter_Name","5011","1","Get-AzNetworkFunctionTrafficCollector -ResourceGroup is not a valid parameter name.","-ResourceGroup","Check validity of the parameter -ResourceGroup."
  "NetworkFunction","New-AzNetworkFunctionCollectorPolicy","1","1","Unassigned_Parameter","5013","1","New-AzNetworkFunctionCollectorPolicy -azuretrafficcollectorname must be assigned with a value.","-azuretrafficcollectorname","Assign value for the parameter -azuretrafficcollectorname."
  "NetworkFunction","New-AzNetworkFunctionCollectorPolicy","1","1","Invalid_Parameter_Name","5011","1","New-AzNetworkFunctionCollectorPolicy -atc is not a valid parameter name.","-atc","Check validity of the parameter -atc."
  "NetworkFunction","New-AzNetworkFunctionCollectorPolicy","1","1","Invalid_Parameter_Name","5011","1","New-AzNetworkFunctionCollectorPolicy -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."
  "NetworkFunction","New-AzNetworkFunctionTrafficCollector","1","1","Invalid_Parameter_Name","5011","1","New-AzNetworkFunctionTrafficCollector -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."
  "NetworkFunction","Remove-AzNetworkFunctionCollectorPolicy","1","1","Invalid_Parameter_Name","5011","1","Remove-AzNetworkFunctionCollectorPolicy -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."
  "NetworkFunction","Remove-AzNetworkFunctionTrafficCollector","1","1","Invalid_Parameter_Name","5011","1","Remove-AzNetworkFunctionTrafficCollector -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."
  "NetworkFunction","Update-AzNetworkFunctionCollectorPolicy","1","1","Unassigned_Parameter","5013","1","Update-AzNetworkFunctionCollectorPolicy -azuretrafficcollectorname must be assigned with a value.","-azuretrafficcollectorname","Assign value for the parameter -azuretrafficcollectorname."
  "NetworkFunction","Update-AzNetworkFunctionCollectorPolicy","1","1","Invalid_Parameter_Name","5011","1","Update-AzNetworkFunctionCollectorPolicy -atc is not a valid parameter name.","-atc","Check validity of the parameter -atc."
  "NetworkFunction","Update-AzNetworkFunctionCollectorPolicy","1","1","Invalid_Parameter_Name","5011","1","Update-AzNetworkFunctionCollectorPolicy -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."
  "NetworkFunction","Update-AzNetworkFunctionTrafficCollector","1","1","Invalid_Parameter_Name","5011","1","Update-AzNetworkFunctionTrafficCollector -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."
  "NetworkFunction","Update-AzNetworkFunctionTrafficCollectorTag","1","1","Invalid_Parameter_Name","5011","1","Update-AzNetworkFunctionTrafficCollectorTag -resourcegroup is not a valid parameter name.","-resourcegroup","Check validity of the parameter -resourcegroup."

I have renamed the resourcegroup parameter to resourcegroupname in the examples. also pushed the latest doc folder after running ./build-modules.ps1

kukulkarni1 added 6 commits July 15, 2022 16:18

updated readme

4dfbe27

Added custom script for get traffic collector

db5b027

readme indentation

bb8f081

resolving compile issues

d0f68f8

resolving compile issues

f0ebf4d

removed extra file

31f160c

wyunchi-ms reviewed Jul 19, 2022

View reviewed changes

src/NetworkFunction/README.md Show resolved Hide resolved

src/NetworkFunction/custom/Get-AzNetworkFunctionAzureTrafficCollector.ps1 Outdated Show resolved Hide resolved

kukulkarni1 added 7 commits July 19, 2022 08:09

renamed file

ba7e6fa

added new collector policy cmdlet

82e1aa6

solving compile issues

e497394

solving compile issues

6253baa

solving compile issues

e424ea6

added new ps script

ce56968

added new ps script

3cd1cf9

BethanyZhou added the needs-author-feedback More information is needed from author to address the issue. label Jul 20, 2022

kukulkarni1 added 2 commits July 20, 2022 15:08

New cmdlet csharp script

8302601

New cmdlet csharp bug fix

d1efa74

BethanyZhou added the needs-revision label Jul 21, 2022

change operationId in readme

be35ed5

kukulkarni1 added 2 commits July 21, 2022 11:40

Changed functions to export

39e45d2

removing new cmdlet

6c2a104

minor typo

f212db6

BethanyZhou reviewed Aug 4, 2022

View reviewed changes

src/NetworkFunction/custom/Set-AzNetworkFunctionCollectorPolicy.ps1 Outdated Show resolved Hide resolved

BethanyZhou reviewed Aug 4, 2022

View reviewed changes

src/NetworkFunction/custom/New-AzNetworkFunctionTrafficCollector.ps1 Outdated Show resolved Hide resolved

src/NetworkFunction/custom/New-AzNetworkFunctionCollectorPolicy.ps1 Show resolved Hide resolved

removed set cmdlet, simplified custom cmdlets

09c0c8c

removed set cmdlet

5f5a30d

isra-fel assigned isra-fel and unassigned kukulkarni1 Aug 5, 2022

isra-fel added needs-review and removed needs-revision labels Aug 5, 2022

Added update cmdlet

13c6c8e

isra-fel mentioned this pull request Aug 12, 2022

Move NetworkFunction to main #19215

Closed

1 task

isra-fel requested changes Aug 12, 2022

View reviewed changes

isra-fel added needs-revision and removed needs-review labels Aug 12, 2022

isra-fel assigned kukulkarni1 and unassigned isra-fel Aug 12, 2022

kukulkarni1 added 2 commits August 12, 2022 11:13

updated examples

b4a799b

updating docs folder

dae6e1c

isra-fel approved these changes Aug 15, 2022

View reviewed changes

isra-fel merged commit 9a98bd5 into Azure:generation Aug 15, 2022

This was referenced Aug 15, 2022

Move NetworkFunction to main #19227

Closed

Move NetworkFunction to main #19270

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Az.network function1 #18966

Az.network function1 #18966

kukulkarni1 commented Jul 18, 2022

BethanyZhou commented Jul 20, 2022

kukulkarni1 commented Jul 20, 2022 •

edited

Loading

BethanyZhou commented Jul 21, 2022

kukulkarni1 commented Jul 21, 2022 •

edited

Loading

BethanyZhou commented Jul 22, 2022 •

edited

Loading

kukulkarni1 commented Jul 22, 2022 •

edited

Loading

BethanyZhou commented Jul 26, 2022

kukulkarni1 commented Jul 26, 2022

BethanyZhou commented Jul 27, 2022

BethanyZhou commented Aug 4, 2022

kukulkarni1 commented Aug 4, 2022

BethanyZhou commented Aug 5, 2022

kukulkarni1 commented Aug 5, 2022

kukulkarni1 commented Aug 11, 2022

isra-fel commented Aug 12, 2022

isra-fel left a comment •

edited

Loading

kukulkarni1 commented Aug 12, 2022

kukulkarni1 commented Aug 12, 2022 •

edited

Loading

Az.network function1 #18966

Az.network function1 #18966

Conversation

kukulkarni1 commented Jul 18, 2022

Description

Checklist

BethanyZhou commented Jul 20, 2022

kukulkarni1 commented Jul 20, 2022 • edited Loading

BethanyZhou commented Jul 21, 2022

kukulkarni1 commented Jul 21, 2022 • edited Loading

BethanyZhou commented Jul 22, 2022 • edited Loading

kukulkarni1 commented Jul 22, 2022 • edited Loading

BethanyZhou commented Jul 26, 2022

kukulkarni1 commented Jul 26, 2022

BethanyZhou commented Jul 27, 2022

BethanyZhou commented Aug 4, 2022

kukulkarni1 commented Aug 4, 2022

BethanyZhou commented Aug 5, 2022

kukulkarni1 commented Aug 5, 2022

kukulkarni1 commented Aug 11, 2022

isra-fel commented Aug 12, 2022

isra-fel left a comment • edited Loading

Choose a reason for hiding this comment

kukulkarni1 commented Aug 12, 2022

kukulkarni1 commented Aug 12, 2022 • edited Loading

kukulkarni1 commented Jul 20, 2022 •

edited

Loading

kukulkarni1 commented Jul 21, 2022 •

edited

Loading

BethanyZhou commented Jul 22, 2022 •

edited

Loading

kukulkarni1 commented Jul 22, 2022 •

edited

Loading

isra-fel left a comment •

edited

Loading

kukulkarni1 commented Aug 12, 2022 •

edited

Loading