Pin DI version #28838
Pin DI version #28838
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR aligns dependency versions across Azure PowerShell modules by adding the Microsoft.Extensions.DependencyInjection.Abstractions package (version 8.0.2) to the Resources and IotHub modules.
- Adds the same dependency package reference to both Resources and IotHub modules
- Updates ChangeLog.md files to document the dependency alignment
- Removes trailing whitespace in Resources ChangeLog
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Resources/Resources/Resources.csproj | Adds Microsoft.Extensions.DependencyInjection.Abstractions v8.0.2 package reference |
| src/Resources/Resources/ChangeLog.md | Documents dependency alignment and removes trailing whitespace |
| src/IotHub/IotHub/IotHub.csproj | Adds Microsoft.Extensions.DependencyInjection.Abstractions v8.0.2 package reference |
| src/IotHub/IotHub/ChangeLog.md | Documents dependency alignment |
| --> | ||
|
|
||
| ## Upcoming Release | ||
| * Aligned dependency versions with other modules |
There was a problem hiding this comment.
The ChangeLog entry is too generic and doesn't explain the user impact. Per the ChangeLog guidelines, entries should be written from the user's perspective and explain what changed and how it affects their usage. Consider providing more specific details, such as: "* Updated internal dependencies to align versions across modules" or explain if there's any user-visible impact. Additionally, if this change is related to a GitHub issue, please reference it using the format [#issue_number].
| --> | ||
| ## Upcoming Release | ||
| * Removed unused libraries | ||
| * Aligned dependency versions with other modules |
There was a problem hiding this comment.
The ChangeLog entry is too generic and doesn't explain the user impact. Per the ChangeLog guidelines, entries should be written from the user's perspective and explain what changed and how it affects their usage. Consider providing more specific details, such as: "* Updated internal dependencies to align versions across modules" or explain if there's any user-visible impact. Additionally, if this change is related to a GitHub issue, please reference it using the format [#issue_number].
This PR aligns the version of
Microsoft.Extensions.DependencyInjection.Abstractionslibrary, which is a indirect dependency ofAzure.Core,Az.Resourcesmodule andAz.IotHub, ensuring they can work together.A more robust way might be adding it to the Assembly Load Context of Az.Accounts.