[Az.Migrate] Stabilize command internals & update policy defaults #28869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request stabilizes command internals for the Azure Migrate module and updates replication policy defaults to align with the Azure Portal user experience. The changes primarily focus on refactoring error handling, improving code organization, and updating default frequency values for replication policies.
Key Changes
- Updated default crash-consistent and app-consistent frequency values in replication policy defaults
- Consolidated test cases into an end-to-end test suite
- Refactored error handling to use standardized exception helper functions
- Updated test environment configuration with new resource identifiers
- Reorganized solution file structure to reference generated AutoRest code from the
/generated/directory
Reviewed Changes
Copilot reviewed 22 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Migrate/Migrate/ChangeLog.md | Added changelog entry documenting policy default updates for New-AzMigrateLocalServerReplication |
| src/Migrate/Migrate.sln | Reorganized solution structure to reference AutoRest-generated project from /generated/ directory |
| src/Migrate/Migrate.Autorest/test/utils.ps1 | Updated test environment variables with new subscription IDs and resource identifiers |
| src/Migrate/Migrate.Autorest/test/localEnv.json | Updated test configuration with new resource IDs and reorganized property ordering |
| src/Migrate/Migrate.Autorest/test/env.json | Updated test environment with new subscription and resource identifiers |
| src/Migrate/Migrate.Autorest/test/Test-AzMigrateLocalEndToEnd.Tests.ps1 | Added comprehensive end-to-end test suite covering default and power user scenarios |
| src/Migrate/Migrate.Autorest/test/Remove-AzMigrateLocalServerReplication.Tests.ps1 | Consolidated tests to reference end-to-end suite and skipped individual test cases |
| src/Migrate/Migrate.Autorest/test/New-AzMigrateLocalServerReplication.Tests.ps1 | Consolidated tests to reference end-to-end suite and skipped individual test cases |
| src/Migrate/Migrate.Autorest/test/Get-AzMigrateLocalServerReplication.Tests.ps1 | Added skip flags to tests and reference to end-to-end suite |
| src/Migrate/Migrate.Autorest/test/Get-AzMigrateLocalReplicationFabric.Recording.json | Updated test recording with new subscription and resource data |
| src/Migrate/Migrate.Autorest/test/Get-AzMigrateLocalServerReplication.Recording.json | Deleted obsolete test recording file |
| src/Migrate/Migrate.Autorest/test/Get-AzMigrateLocalJob.Tests.ps1 | Consolidated tests to reference end-to-end suite with skip flags |
| src/Migrate/Migrate.Autorest/generate-info.json | Updated AutoRest generation ID |
| src/Migrate/Migrate.Autorest/docs/Az.Migrate.md | Updated module GUID |
| src/Migrate/Migrate.Autorest/custom/Set-AzMigrateLocalServerReplication.ps1 | Refactored error handling to use helper functions and improved code organization |
| src/Migrate/Migrate.Autorest/custom/Remove-AzMigrateLocalServerReplication.ps1 | Improved error handling with standardized exception messages |
| src/Migrate/Migrate.Autorest/custom/Helper/AzLocalCommonSettings.ps1 | Swapped default crash-consistent and app-consistent frequency values; added new constants |
| src/Migrate/Migrate.Autorest/custom/Helper/AzLocalCommonHelper.ps1 | Added standardized exception helper functions and refactored validation logic |
| src/Migrate/Migrate.Autorest/custom/Get-AzMigrateLocalServerReplication.ps1 | Improved error handling and removed retry logic in favor of direct calls with validation |
Contributor
Author
|
Replication policy now aligns with Portal UX for default config. Passing dev test with private module 3.0.17: https://dev.azure.com/msazure/One/_build/results?buildId=143763316&view=results 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.