Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2022-10-01 #24020

Merged
merged 1 commit into from
May 22, 2023
Merged

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2022-10-01 #24020

merged 1 commit into from
May 22, 2023

Conversation

karthikku-2020
Copy link
Contributor

@karthikku-2020 karthikku-2020 commented May 16, 2023 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 16, 2023 •
edited
Loading

Swagger Validation Report

️❌BreakingChange: 5 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
costmanagement.json 2023-04-01-preview(50dc914) 2023-04-01-preview(main)
costmanagement.json 2022-10-01(50dc914) 2022-10-01(main)
costmanagement.json 2023-03-01(50dc914) 2023-03-01(main)
Rule Message
❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L1590:9
Old: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L1590:9
❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L1596:9
Old: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L1596:9
❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.CostManagement/stable/2022-10-01/costmanagement.json#L1596:9
Old: Microsoft.CostManagement/stable/2022-10-01/costmanagement.json#L1596:9
❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.CostManagement/stable/2023-03-01/costmanagement.json#L1590:9
Old: Microsoft.CostManagement/stable/2023-03-01/costmanagement.json#L1590:9
❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.CostManagement/stable/2023-03-01/costmanagement.json#L1596:9
Old: Microsoft.CostManagement/stable/2023-03-01/costmanagement.json#L1596:9
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.1) new version base version
package-2023-03 package-2023-03(50dc914) package-2023-03(main)
package-2022-10 package-2022-10(50dc914) package-2022-10(main)
package-preview-2023-04 package-preview-2023-04(50dc914) package-preview-2023-04(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ NoDuplicatePathsForScopeParameter Path '/{scope}/providers/Microsoft.CostManagement/views/{viewName}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.CostManagement/views' that has the scope parameter.'.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L75
❌ PathForPutOperation The path for 'put' operation must be under a subscription and resource group.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L117
❌ ResourceNameRestriction The resource name parameter 'viewName' should be defined with a 'pattern' restriction.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L117
❌ PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L186
❌ ResourceNameRestriction The resource name parameter 'viewName' should be defined with a 'pattern' restriction.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L245
❌ RepeatedPathInfo The 'scope' already appears in the path, please don't repeat it in the request body.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L301
❌ PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L320
❌ NoDuplicatePathsForScopeParameter Path '/{scope}/providers/Microsoft.CostManagement/alerts/{alertId}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.CostManagement/alerts' that has the scope parameter.'.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L382
❌ PathContainsResourceType The path for the CURD methods do not contain a resource type.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L536
❌ SyncPostReturn A synchronous POST operation must have either 200 or 204 return codes.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L582
❌ ParametersInPost $filter is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L614
❌ PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L657
❌ ParametersInPost $filter is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L675
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L851
❌ GetOperation200 The get operation should only return 200.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L855
❌ PathContainsResourceType The path for the CURD methods do not contain a resource type.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L870
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L934
❌ SyncPostReturn A synchronous POST operation must have either 200 or 204 return codes.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L951
❌ PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L1058
❌ ParametersInPost startDate is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L1131
❌ ParametersInPost endDate is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L1131
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L1169
❌ ParametersInPost startDate is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L1194
❌ ParametersInPost endDate is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L1194
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L1235
❌ TopLevelResourcesListBySubscription The top-level resource 'View' does not have list by subscription operation, please add it.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L1556
❌ TopLevelResourcesListBySubscription The top-level resource 'Alert' does not have list by subscription operation, please add it.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L1870
❌ ValidFormats 'decimal' is not a known format.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L2022
❌ ValidFormats 'decimal' is not a known format.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L2043
❌ ValidFormats 'decimal' is not a known format.
Location: Microsoft.CostManagement/preview/2023-04-01-preview/costmanagement.json#L2052
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand] 
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand] 
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @karthikku-2020 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 16, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • ❌Failed [Logs]Release - Generate from a9c6594. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:800
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 800 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • ❌Azure.ResourceManager.Cost-Management [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a9c6594. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/costmanagement/armcostmanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New enum type `ScheduleFrequency` with values `ScheduleFrequencyDaily`, `ScheduleFrequencyMonthly`, `ScheduleFrequencyWeekly`
info	[Changelog] - New enum type `ScheduledActionKind` with values `ScheduledActionKindEmail`, `ScheduledActionKindInsightAlert`
info	[Changelog] - New enum type `ScheduledActionStatus` with values `ScheduledActionStatusDisabled`, `ScheduledActionStatusEnabled`, `ScheduledActionStatusExpired`
info	[Changelog] - New enum type `Scope` with values `ScopeShared`, `ScopeSingle`
info	[Changelog] - New enum type `Term` with values `TermP1Y`, `TermP3Y`
info	[Changelog] - New enum type `WeeksOfMonth` with values `WeeksOfMonthFirst`, `WeeksOfMonthFourth`, `WeeksOfMonthLast`, `WeeksOfMonthSecond`, `WeeksOfMonthThird`
info	[Changelog] - New function `*BenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties`
info	[Changelog] - New function `NewBenefitRecommendationsClient(azcore.TokenCredential, *arm.ClientOptions) (*BenefitRecommendationsClient, error)`
info	[Changelog] - New function `*BenefitRecommendationsClient.NewListPager(string, *BenefitRecommendationsClientListOptions) *runtime.Pager[BenefitRecommendationsClientListResponse]`
info	[Changelog] - New function `NewBenefitUtilizationSummariesClient(azcore.TokenCredential, *arm.ClientOptions) (*BenefitUtilizationSummariesClient, error)`
info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListByBillingAccountIDPager(string, *BenefitUtilizationSummariesClientListByBillingAccountIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListByBillingAccountIDResponse]`
info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListByBillingProfileIDPager(string, string, *BenefitUtilizationSummariesClientListByBillingProfileIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListByBillingProfileIDResponse]`
info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListBySavingsPlanIDPager(string, string, *BenefitUtilizationSummariesClientListBySavingsPlanIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListBySavingsPlanIDResponse]`
info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListBySavingsPlanOrderPager(string, *BenefitUtilizationSummariesClientListBySavingsPlanOrderOptions) *runtime.Pager[BenefitUtilizationSummariesClientListBySavingsPlanOrderResponse]`
info	[Changelog] - New function `*BenefitUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary`
info	[Changelog] - New function `NewBillingAccountScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*BillingAccountScopeClient, error)`
info	[Changelog] - New function `*BillingAccountScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, BenefitUtilizationSummariesRequest, *BillingAccountScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[BillingAccountScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)`
info	[Changelog] - New function `NewBillingProfileScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*BillingProfileScopeClient, error)`
info	[Changelog] - New function `*BillingProfileScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, string, BenefitUtilizationSummariesRequest, *BillingProfileScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[BillingProfileScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)`
info	[Changelog] - New function `*ClientFactory.NewBenefitRecommendationsClient() *BenefitRecommendationsClient`
info	[Changelog] - New function `*ClientFactory.NewBenefitUtilizationSummariesClient() *BenefitUtilizationSummariesClient`
info	[Changelog] - New function `*ClientFactory.NewBillingAccountScopeClient() *BillingAccountScopeClient`
info	[Changelog] - New function `*ClientFactory.NewBillingProfileScopeClient() *BillingProfileScopeClient`
info	[Changelog] - New function `*ClientFactory.NewGenerateCostDetailsReportClient() *GenerateCostDetailsReportClient`
info	[Changelog] - New function `*ClientFactory.NewPriceSheetClient() *PriceSheetClient`
info	[Changelog] - New function `*ClientFactory.NewReservationOrderScopeClient() *ReservationOrderScopeClient`
info	[Changelog] - New function `*ClientFactory.NewReservationScopeClient() *ReservationScopeClient`
info	[Changelog] - New function `*ClientFactory.NewSavingsPlanOrderScopeClient() *SavingsPlanOrderScopeClient`
info	[Changelog] - New function `*ClientFactory.NewSavingsPlanScopeClient() *SavingsPlanScopeClient`
info	[Changelog] - New function `*ClientFactory.NewScheduledActionsClient() *ScheduledActionsClient`
info	[Changelog] - New function `NewGenerateCostDetailsReportClient(azcore.TokenCredential, *arm.ClientOptions) (*GenerateCostDetailsReportClient, error)`
info	[Changelog] - New function `*GenerateCostDetailsReportClient.BeginCreateOperation(context.Context, string, GenerateCostDetailsReportRequestDefinition, *GenerateCostDetailsReportClientBeginCreateOperationOptions) (*runtime.Poller[GenerateCostDetailsReportClientCreateOperationResponse], error)`
info	[Changelog] - New function `*GenerateCostDetailsReportClient.BeginGetOperationResults(context.Context, string, string, *GenerateCostDetailsReportClientBeginGetOperationResultsOptions) (*runtime.Poller[GenerateCostDetailsReportClientGetOperationResultsResponse], error)`
info	[Changelog] - New function `*IncludedQuantityUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary`
info	[Changelog] - New function `NewPriceSheetClient(azcore.TokenCredential, *arm.ClientOptions) (*PriceSheetClient, error)`
info	[Changelog] - New function `*PriceSheetClient.BeginDownload(context.Context, string, string, string, *PriceSheetClientBeginDownloadOptions) (*runtime.Poller[PriceSheetClientDownloadResponse], error)`
info	[Changelog] - New function `*PriceSheetClient.BeginDownloadByBillingProfile(context.Context, string, string, *PriceSheetClientBeginDownloadByBillingProfileOptions) (*runtime.Poller[PriceSheetClientDownloadByBillingProfileResponse], error)`
info	[Changelog] - New function `NewReservationOrderScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*ReservationOrderScopeClient, error)`
info	[Changelog] - New function `*ReservationOrderScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, BenefitUtilizationSummariesRequest, *ReservationOrderScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[ReservationOrderScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)`
info	[Changelog] - New function `NewReservationScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*ReservationScopeClient, error)`
info	[Changelog] - New function `*ReservationScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, string, BenefitUtilizationSummariesRequest, *ReservationScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[ReservationScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)`
info	[Changelog] - New function `NewSavingsPlanOrderScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*SavingsPlanOrderScopeClient, error)`
info	[Changelog] - New function `*SavingsPlanOrderScopeClient.BeginGenerateBenefitUtilizationSummariesReport(context.Context, string, BenefitUtilizationSummariesRequest, *SavingsPlanOrderScopeClientBeginGenerateBenefitUtilizationSummariesReportOptions) (*runtime.Poller[SavingsPlanOrderScopeClientGenerateBenefitUtilizationSummariesReportResponse], error)`
info	[Changelog] - New function `NewSavingsPlanScopeClient(azcore.TokenCredential, *arm.ClientOptions) (*SavingsPlanScopeClient, error)`
info	[Changelog] - New function `*SavingsPlanScopeClient.BeginGenerateBenefitUtilizationSummariesReportAsync(context.Context, string, string, BenefitUtilizationSummariesRequest, *SavingsPlanScopeClientBeginGenerateBenefitUtilizationSummariesReportAsyncOptions) (*runtime.Poller[SavingsPlanScopeClientGenerateBenefitUtilizationSummariesReportAsyncResponse], error)`
info	[Changelog] - New function `*SavingsPlanUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary`
info	[Changelog] - New function `NewScheduledActionsClient(azcore.TokenCredential, *arm.ClientOptions) (*ScheduledActionsClient, error)`
info	[Changelog] - New function `*ScheduledActionsClient.CheckNameAvailability(context.Context, CheckNameAvailabilityRequest, *ScheduledActionsClientCheckNameAvailabilityOptions) (ScheduledActionsClientCheckNameAvailabilityResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.CheckNameAvailabilityByScope(context.Context, string, CheckNameAvailabilityRequest, *ScheduledActionsClientCheckNameAvailabilityByScopeOptions) (ScheduledActionsClientCheckNameAvailabilityByScopeResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.CreateOrUpdate(context.Context, string, ScheduledAction, *ScheduledActionsClientCreateOrUpdateOptions) (ScheduledActionsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.CreateOrUpdateByScope(context.Context, string, string, ScheduledAction, *ScheduledActionsClientCreateOrUpdateByScopeOptions) (ScheduledActionsClientCreateOrUpdateByScopeResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.Delete(context.Context, string, *ScheduledActionsClientDeleteOptions) (ScheduledActionsClientDeleteResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.DeleteByScope(context.Context, string, string, *ScheduledActionsClientDeleteByScopeOptions) (ScheduledActionsClientDeleteByScopeResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.Get(context.Context, string, *ScheduledActionsClientGetOptions) (ScheduledActionsClientGetResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.GetByScope(context.Context, string, string, *ScheduledActionsClientGetByScopeOptions) (ScheduledActionsClientGetByScopeResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.NewListByScopePager(string, *ScheduledActionsClientListByScopeOptions) *runtime.Pager[ScheduledActionsClientListByScopeResponse]`
info	[Changelog] - New function `*ScheduledActionsClient.NewListPager(*ScheduledActionsClientListOptions) *runtime.Pager[ScheduledActionsClientListResponse]`
info	[Changelog] - New function `*ScheduledActionsClient.Run(context.Context, string, *ScheduledActionsClientRunOptions) (ScheduledActionsClientRunResponse, error)`
info	[Changelog] - New function `*ScheduledActionsClient.RunByScope(context.Context, string, string, *ScheduledActionsClientRunByScopeOptions) (ScheduledActionsClientRunByScopeResponse, error)`
info	[Changelog] - New function `*SharedScopeBenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties`
info	[Changelog] - New function `*SingleScopeBenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties`
info	[Changelog] - New struct `AllSavingsBenefitDetails`
info	[Changelog] - New struct `AllSavingsList`
info	[Changelog] - New struct `AsyncOperationStatusProperties`
info	[Changelog] - New struct `BenefitRecommendationModel`
info	[Changelog] - New struct `BenefitRecommendationsListResult`
info	[Changelog] - New struct `BenefitResource`
info	[Changelog] - New struct `BenefitUtilizationSummariesListResult`
info	[Changelog] - New struct `BenefitUtilizationSummariesOperationStatus`
info	[Changelog] - New struct `BenefitUtilizationSummariesRequest`
info	[Changelog] - New struct `BenefitUtilizationSummaryProperties`
info	[Changelog] - New struct `BlobInfo`
info	[Changelog] - New struct `CheckNameAvailabilityRequest`
info	[Changelog] - New struct `CheckNameAvailabilityResponse`
info	[Changelog] - New struct `CostDetailsOperationResults`
info	[Changelog] - New struct `CostDetailsTimePeriod`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorDetailsWithNestedDetails`
info	[Changelog] - New struct `ErrorResponseAutoGenerated`
info	[Changelog] - New struct `ErrorResponseWithNestedDetails`
info	[Changelog] - New struct `ExportRun`
info	[Changelog] - New struct `ExportRunProperties`
info	[Changelog] - New struct `FileDestination`
info	[Changelog] - New struct `ForecastAggregation`
info	[Changelog] - New struct `ForecastColumn`
info	[Changelog] - New struct `ForecastComparisonExpression`
info	[Changelog] - New struct `ForecastDatasetConfiguration`
info	[Changelog] - New struct `ForecastFilter`
info	[Changelog] - New struct `ForecastProperties`
info	[Changelog] - New struct `ForecastResult`
info	[Changelog] - New struct `ForecastTimePeriod`
info	[Changelog] - New struct `GenerateCostDetailsReportErrorResponse`
info	[Changelog] - New struct `GenerateCostDetailsReportRequestDefinition`
info	[Changelog] - New struct `IncludedQuantityUtilizationSummary`
info	[Changelog] - New struct `IncludedQuantityUtilizationSummaryProperties`
info	[Changelog] - New struct `NotificationProperties`
info	[Changelog] - New struct `OperationForCostManagement`
info	[Changelog] - New struct `ProxyResourceForCostManagement`
info	[Changelog] - New struct `RecommendationUsageDetails`
info	[Changelog] - New struct `ReportManifest`
info	[Changelog] - New struct `RequestContext`
info	[Changelog] - New struct `ResourceForCostManagement`
info	[Changelog] - New struct `SavingsPlanUtilizationSummary`
info	[Changelog] - New struct `SavingsPlanUtilizationSummaryProperties`
info	[Changelog] - New struct `ScheduleProperties`
info	[Changelog] - New struct `ScheduledAction`
info	[Changelog] - New struct `ScheduledActionListResult`
info	[Changelog] - New struct `ScheduledActionProperties`
info	[Changelog] - New struct `ScheduledActionProxyResource`
info	[Changelog] - New struct `SharedScopeBenefitRecommendationProperties`
info	[Changelog] - New struct `SingleScopeBenefitRecommendationProperties`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New field `ExpiryTime` in struct `DownloadURL`
info	[Changelog] - New anonymous field `ForecastResult` in struct `ForecastClientExternalCloudProviderUsageResponse`
info	[Changelog] - New anonymous field `ForecastResult` in struct `ForecastClientUsageResponse`
info	[Changelog] - New field `EndTime`, `StartTime` in struct `GenerateDetailedCostReportOperationStatuses`
info	[Changelog] - New field `ActionType`, `IsDataAction`, `Origin` in struct `Operation`
info	[Changelog]
info	[Changelog] Total 18 breaking change(s), 259 additive change(s).
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a9c6594. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.7` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-costmanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group BenefitRecommendationsOperations
info	[Changelog]   - Added operation group BenefitUtilizationSummariesOperations
info	[Changelog]   - Added operation group BillingAccountScopeOperations
info	[Changelog]   - Added operation group BillingProfileScopeOperations
info	[Changelog]   - Added operation group GenerateCostDetailsReportOperations
info	[Changelog]   - Added operation group GenerateDetailedCostReportOperationResultsOperations
info	[Changelog]   - Added operation group GenerateDetailedCostReportOperationStatusOperations
info	[Changelog]   - Added operation group GenerateDetailedCostReportOperations
info	[Changelog]   - Added operation group PriceSheetOperations
info	[Changelog]   - Added operation group ReservationOrderScopeOperations
info	[Changelog]   - Added operation group ReservationScopeOperations
info	[Changelog]   - Added operation group SavingsPlanOrderScopeOperations
info	[Changelog]   - Added operation group SavingsPlanScopeOperations
info	[Changelog]   - Added operation group ScheduledActionsOperations
info	[Changelog]   - Model Alert has a new parameter e_tag
info	[Changelog]   - Model AlertPropertiesDetails has a new parameter company_name
info	[Changelog]   - Model AlertPropertiesDetails has a new parameter department_name
info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_end_date
info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_number
info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_start_date
info	[Changelog]   - Model AlertPropertiesDetails has a new parameter invoicing_threshold
info	[Changelog]   - Model CommonExportProperties has a new parameter next_run_time_estimate
info	[Changelog]   - Model CommonExportProperties has a new parameter partition_data
info	[Changelog]   - Model CommonExportProperties has a new parameter run_history
info	[Changelog]   - Model Dimension has a new parameter e_tag
info	[Changelog]   - Model Dimension has a new parameter location
info	[Changelog]   - Model Dimension has a new parameter sku
info	[Changelog]   - Model Export has a new parameter next_run_time_estimate
info	[Changelog]   - Model Export has a new parameter partition_data
info	[Changelog]   - Model Export has a new parameter run_history
info	[Changelog]   - Model ExportDeliveryDestination has a new parameter sas_token
info	[Changelog]   - Model ExportDeliveryDestination has a new parameter storage_account
info	[Changelog]   - Model ExportProperties has a new parameter next_run_time_estimate
info	[Changelog]   - Model ExportProperties has a new parameter partition_data
info	[Changelog]   - Model ExportProperties has a new parameter run_history
info	[Changelog]   - Model Operation has a new parameter action_type
info	[Changelog]   - Model Operation has a new parameter is_data_action
info	[Changelog]   - Model Operation has a new parameter origin
info	[Changelog]   - Model OperationDisplay has a new parameter description
info	[Changelog]   - Operation ExportsOperations.get has a new optional parameter expand
info	[Changelog]   - Operation ExportsOperations.list has a new optional parameter expand
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model Alert no longer has parameter tags
info	[Changelog]   - Model ProxyResource no longer has parameter e_tag
info	[Changelog]   - Model ReportConfigFilter no longer has parameter tag_key
info	[Changelog]   - Model ReportConfigFilter no longer has parameter tag_value
info	[Changelog]   - Model Resource no longer has parameter tags
info	[Changelog]   - Removed operation group SettingsOperations
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a9c6594. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️cost-management [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • ❌Pipeline Framework Failed [Logs]Release - Generate from a9c6594. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe
    • ❌Az.cost-management.DefaultTag [View full logs]  
      error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.cost-management.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 16, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/costmanagement/armcostmanagement https://apiview.dev/Assemblies/Review/dcbea5ac3a5d4bb2b0043e4cf2904778

    This was referenced May 16, 2023
    Closed
    Closed
    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels May 16, 2023
    @openapi-workflow-bot
    Copy link

    Hi @karthikku-2020, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    This was referenced May 16, 2023
    Closed
    Closed
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 17, 2023
    @JackTn
    Copy link
    Member

    JackTn commented May 22, 2023

    @msyyc take a look on this pr and help to merge it , Thanks

    @JackTn JackTn added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 22, 2023
    @msyyc msyyc merged commit a9c6594 into main May 22, 2023
    @msyyc msyyc deleted the karthikku-2020-views-api-Microsoft.CostManagement-2022-10-01 branch May 22, 2023 06:16
    @azure-sdk azure-sdk mentioned this pull request May 22, 2023
    Closed
    This was referenced May 22, 2023
    Closed
    Closed
    @azure-sdk azure-sdk mentioned this pull request May 22, 2023
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @msyyc msyyc msyyc approved these changes

    Assignees

    @JackTn JackTn

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @karthikku-2020 @JackTn @msyyc @JeffreyRichter @AzureRestAPISpecReview