Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new stable API version 2023-06-01 for Microsoft.Elastic #24182

Merged
merged 3 commits into from
May 31, 2023
Merged

Adding new stable API version 2023-06-01 for Microsoft.Elastic #24182

merged 3 commits into from
May 31, 2023

Conversation

poshett
Copy link
Contributor

@poshett poshett commented May 26, 2023

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @poshett Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 26, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    elastic.json 2023-06-01(ea275a5) 2020-07-01(main)
    elastic.json 2023-06-01(ea275a5) 2023-05-01-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-2023-06-01 package-2023-06-01(ea275a5) default(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    XmsParameterLocation The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Microsoft.Elastic/stable/2023-06-01/elastic.json#L2470
    XmsParameterLocation The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Microsoft.Elastic/stable/2023-06-01/elastic.json#L2478
    ⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.Elastic/stable/2023-06-01/elastic.json#L1424
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/stable/2023-06-01/elastic.json#L1544
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.Elastic/stable/2023-06-01/elastic.json#L1758
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/stable/2023-06-01/elastic.json#L1806
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/stable/2023-06-01/elastic.json#L2051
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/stable/2023-06-01/elastic.json#L2055
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/stable/2023-06-01/elastic.json#L2059
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Elastic/stable/2023-06-01/elastic.json#L2141
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/stable/2023-06-01/elastic.json#L2217
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Elastic/stable/2023-06-01/elastic.json#L2390
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.Elastic/stable/2023-06-01/elastic.json#L2458
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.Elastic' for api version '2023-06-01'. The supported api-versions are '2020-07-01-preview,
    2020-07-01,
    2021-09-01-preview,
    2021-10-01-preview,
    2022-05-05-preview,
    2022-07-01-preview,
    2022-09-01-preview,
    2023-02-01-preview'."
    ️❌~[Staging] ServiceAPIReadinessTest: 28 Errors, 0 Warnings failed [Detail]

    Tag package-2023-06-01; Prod region: Not deployed; Canary region: Deployed

    Test run on region: eastus2euap; Operation coverage: total: 29, untested: 0, failed: 28, passed: 1

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Rule Message
    CLIENT_ERROR statusCode: 400,
    errorCode: InvalidResource,
    errorMessage: The resource definition is invalid.
    Source: runtime
    OperationId: Monitors_Create
    CLIENT_ERROR statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'monitors' could not be found in the namespace 'Microsoft.Elastic' for api version '2023-06-01'. The supported api-versions are '2020-07-01-preview,2020-07-01,2021-09-01-preview,2021-10-01-preview,2022-05-05-preview,2022-07-01-preview,2022-09-01-preview,2023-02-01-preview'.
    Source: runtime
    OperationId: Monitors_List
    CLIENT_ERROR statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'monitors' could not be found in the namespace 'Microsoft.Elastic' for api version '2023-06-01'. The supported api-versions are '2020-07-01-preview,2020-07-01,2021-09-01-preview,2021-10-01-preview,2022-05-05-preview,2022-07-01-preview,2022-09-01-preview,2023-02-01-preview'.
    Source: runtime
    OperationId: Monitors_ListByResourceGroup
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Monitors_Get
    CLIENT_ERROR statusCode: 400,
    errorCode: InvalidResource,
    errorMessage: The resource definition is invalid.
    Source: runtime
    OperationId: Monitors_Update
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'monitornpq5ved' not found.
    Source: runtime
    OperationId: TagRules_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'monitornpq5ved' not found.
    Source: runtime
    OperationId: TagRules_List
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'monitornpq5ved' not found.
    Source: runtime
    OperationId: TagRules_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'operations' could not be found in the namespace 'Microsoft.Elastic' for api version '2023-06-01'. The supported api-versions are '2020-07-01-preview,2020-07-01,2021-09-01-preview,2021-10-01-preview,2022-05-05-preview,2022-07-01-preview,2022-09-01-preview,2023-02-01-preview'.
    Source: runtime
    OperationId: Operations_List
    CLIENT_ERROR statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'elasticVersions' could not be found in the namespace 'Microsoft.Elastic' for api version '2023-06-01'. The supported api-versions are '2023-02-01-preview'.
    Source: runtime
    OperationId: ElasticVersions_List
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Elastic/getOrganizationApiKey/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: Organizations_GetApiKey
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: AssociateTrafficFilter_Associate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: createAndAssociateIPFilter_Create
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: createAndAssociatePLFilter_Create
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: ExternalUser_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: TrafficFilters_Delete
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DetachAndDeleteTrafficFilter_Delete
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DetachTrafficFilter_Update
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: AllTrafficFilters_list
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: listAssociatedTrafficFilters_list
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DeploymentInfo_List
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MonitoredResources_List
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: UpgradableVersions_Details
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VMHost_List
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Monitor_Upgrade
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VMCollection_Update
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornpq5ved' under resource group 'apiTest-XrnRui-24182' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: VMIngestion_Details
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'monitornpq5ved' not found.
    Source: runtime
    OperationId: TagRules_Delete
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 26, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking



    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 73d8ea0. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.7` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-elastic [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group AllTrafficFiltersOperations
      info	[Changelog]   - Added operation group AssociateTrafficFilterOperations
      info	[Changelog]   - Added operation group CreateAndAssociateIPFilterOperations
      info	[Changelog]   - Added operation group CreateAndAssociatePLFilterOperations
      info	[Changelog]   - Added operation group DetachAndDeleteTrafficFilterOperations
      info	[Changelog]   - Added operation group DetachTrafficFilterOperations
      info	[Changelog]   - Added operation group ElasticVersionsOperations
      info	[Changelog]   - Added operation group ExternalUserOperations
      info	[Changelog]   - Added operation group ListAssociatedTrafficFiltersOperations
      info	[Changelog]   - Added operation group MonitorOperations
      info	[Changelog]   - Added operation group OrganizationsOperations
      info	[Changelog]   - Added operation group TrafficFiltersOperations
      info	[Changelog]   - Added operation group UpgradableVersionsOperations
      info	[Changelog]   - Model DeploymentInfoResponse has a new parameter deployment_url
      info	[Changelog]   - Model DeploymentInfoResponse has a new parameter marketplace_saas_info
      info	[Changelog]   - Model MonitorProperties has a new parameter generate_api_key
      info	[Changelog]   - Model MonitorProperties has a new parameter version
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 73d8ea0. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-elastic [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 73d8ea0. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/elastic/armelastic [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New field `MarketplaceStatus` in struct `MarketplaceSaaSInfo`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 73d8ea0. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️elastic [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 73d8ea0. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.elastic.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.elastic.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 26, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/elastic/armelastic https://apiview.dev/Assemblies/Review/46fd8f8333774ccfa92e7af55c16d000
    Java azure-resourcemanager-elastic https://apiview.dev/Assemblies/Review/b6b4a1c0f7a64bcca07d5921e3a22898

    @openapi-workflow-bot
    Copy link

    Hi @poshett, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi, @poshett, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @AzureRestAPISpecReview AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test and removed CI-FixRequiredOnFailure labels May 26, 2023
    @poshett poshett added the Liftr Marketplace-Liftr RPs label May 26, 2023
    @visingla-ms visingla-ms added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 26, 2023
    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 26, 2023
    @poshett poshett added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels May 29, 2023
    @mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 30, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 30, 2023
    @mentat9
    Copy link
    Member

    mentat9 commented May 30, 2023

    You didn't construct the PR correctly for a new API version:

    Adding a new API version
    -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.

    Please carefully follow these instructions in the future, to avoid duplicate reviews, wasted time, and delays in ARM signoff. Also, any needed context to understand your PR should be provided in comments.

    I've signed off, since this swagger is identical to one that was previously signed off by ARM.

    @mentat9
    Copy link
    Member

    mentat9 commented May 30, 2023

    @poshett - I've signed off with comments.

    @zedy-wj
    Copy link
    Member

    zedy-wj commented May 31, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @zedy-wj zedy-wj added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 31, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-MissingBaseCommit Liftr Marketplace-Liftr RPs new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants