Update readme.java.md to make Resource.resourcegroup and subscriptionid readonly #24530

haolingdong-msft · 2023-06-21T08:59:09Z

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

Make Resource.resourcegroup and Resource.subscriptionid readonly according to service team's ask. https://github.com/Azure/sdk-release-request/issues/4203#issuecomment-1603387205

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
I commit to follow the Breaking Change Policy.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.

ARM API changes review

If you want for the ARM team to review this PR, you must add the ARMReview label.
The automation may automatically add the ARMReview label, if appropriate.
If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For additional help, see https://aka.ms/azsdk/support/spectools.

openapi-workflow-bot · 2023-06-21T08:59:12Z

Hi, @haolingdong-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-06-21T08:59:13Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v2.1.3)	new version	base version
default	default(41dcddd)	default(main)

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-21T08:59:13Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-js - @azure/arm-deviceprovisioningservices - 6.0.0-beta.2

+	Type of parameter code of interface ErrorDetails is changed from string to number

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 89e91a0. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.DeviceProvisioningServices [View full logs] [Release SDK Changes]
- Azure.ResourceManager.DeviceProvisioningServices.1.2.0-alpha.20230625.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 89e91a0. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.7.2` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-iothubprovisioningservices [View full logs] [Release SDK Changes]
- azure_mgmt_iothubprovisioningservices-1.0.0b1-py3-none-any.whl
- azure-mgmt-iothubprovisioningservices-1.0.0b1.zip
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 89e91a0. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-deviceprovisioningservices [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 89e91a0. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/deviceprovisioningservices/armdeviceprovisioningservices [View full logs] [Release SDK Changes]
```
info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 89e91a0. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-deviceprovisioningservices [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-deviceprovisioningservices-6.0.0-beta.2.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface ManagedServiceIdentity
info	[Changelog]   - Added Interface UserAssignedIdentity
info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
info	[Changelog]   - Interface IotDpsPropertiesDescription has a new optional parameter portalOperationsHostName
info	[Changelog]   - Interface ProvisioningServiceDescription has a new optional parameter identity
info	[Changelog]   - Interface Resource has a new optional parameter resourcegroup
info	[Changelog]   - Interface Resource has a new optional parameter subscriptionid
info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Type of parameter code of interface ErrorDetails is changed from string to number

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 89e91a0. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️deviceprovisioningservices [View full logs]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 89e91a0. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

❌Az.deviceprovisioningservices.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.deviceprovisioningservices.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-21T08:59:15Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/deviceprovisioningservices/armdeviceprovisioningservices	There is no API change compared with the previous version
Java	azure-resourcemanager-deviceprovisioningservices	https://apiview.dev/Assemblies/Review/075628977ece44459b3f2d38f5cfe774
.Net	Azure.ResourceManager.DeviceProvisioningServices	https://apiview.dev/Assemblies/Review/a3dad8064cdc45f9ae66e195a4fc4ee9
JavaScript	@azure/arm-deviceprovisioningservices	https://apiview.dev/Assemblies/Review/829ede76483f4be4aebe975ed10fa27e

JackTn · 2023-06-25T07:44:15Z

/azp run

azure-pipelines · 2023-06-25T07:44:24Z

Azure Pipelines successfully started running 1 pipeline(s).

JackTn · 2023-06-25T08:01:04Z

@qiaozha help to approve breaking change for js, Thanks

…id readonly (Azure#24530) * Update readme.java.md to make Resource.resourcegroup readonly * Update readme.java.md * Update readme.java.md to make subscriptionid readonly

Update readme.java.md to make Resource.resourcegroup readonly

dd5b77e

AzureRestAPISpecReview added the resource-manager label Jun 21, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Jun 21, 2023

haolingdong-msft added 2 commits June 21, 2023 17:29

Update readme.java.md

4d8b735

Update readme.java.md to make subscriptionid readonly

41dcddd

haolingdong-msft changed the title ~~Update readme.java.md to make Resource.resourcegroup readonly~~ Update readme.java.md to make Resource.resourcegroup and subscriptionid readonly Jun 25, 2023

weidongxu-microsoft approved these changes Jun 25, 2023

View reviewed changes

haolingdong-msft marked this pull request as ready for review June 25, 2023 07:11

openapi-assignment-bot bot assigned JackTn Jun 25, 2023

AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 25, 2023

haolingdong-msft merged commit 89e91a0 into main Jun 25, 2023

haolingdong-msft deleted the haolingdong-msft-patch-2 branch June 25, 2023 08:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update readme.java.md to make Resource.resourcegroup and subscriptionid readonly #24530

Update readme.java.md to make Resource.resourcegroup and subscriptionid readonly #24530

haolingdong-msft commented Jun 21, 2023 •

edited

Loading

openapi-workflow-bot bot commented Jun 21, 2023

openapi-pipeline-app bot commented Jun 21, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 21, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Jun 21, 2023 •

edited

Loading

JackTn commented Jun 25, 2023

azure-pipelines bot commented Jun 25, 2023

JackTn commented Jun 25, 2023

Update readme.java.md to make Resource.resourcegroup and subscriptionid readonly #24530

Update readme.java.md to make Resource.resourcegroup and subscriptionid readonly #24530

Conversation

haolingdong-msft commented Jun 21, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

Due diligence checklist

ARM API changes review

Breaking change review

Getting help

openapi-workflow-bot bot commented Jun 21, 2023

openapi-pipeline-app bot commented Jun 21, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 21, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Jun 21, 2023 • edited Loading

Generated ApiView

JackTn commented Jun 25, 2023

azure-pipelines bot commented Jun 25, 2023

JackTn commented Jun 25, 2023

haolingdong-msft commented Jun 21, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 21, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 21, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 21, 2023 •

edited

Loading