Skip to content

Commit

Permalink
Update PublishCodeCoverageResults task (#2912)
Browse files Browse the repository at this point in the history
  • Loading branch information
weshaggard authored Sep 12, 2024
1 parent c1740b4 commit 48ef2f7
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions eng/pipelines/templates/steps/ci.test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,8 @@ steps:
displayName: Generate Code Coverage Data
condition: eq(variables['AZ_SDK_CODE_COV'], 1)

- task: PublishCodeCoverageResults@1
- task: PublishCodeCoverageResults@2
inputs:
codeCoverageTool: Cobertura
summaryFileLocation: '$(Build.SourcesDirectory)/**/Cobertura.xml'
displayName: Publish Code Coverage to DevOps
condition: eq(variables['AZ_SDK_CODE_COV'], 1)
Expand All @@ -93,7 +92,7 @@ steps:
CustomCondition: eq(variables['PublishMapFiles'], 'true')
SbomEnabled: false

- task: mspremier.BuildQualityChecks.QualityChecks-task.BuildQualityChecks@6
- task: BuildQualityChecks@9
displayName: Check line coverage
inputs:
checkCoverage: true
Expand All @@ -103,15 +102,16 @@ steps:
coverageThreshold: 90
condition: eq(variables['AZ_SDK_CODE_COV'], 1)

- task: mspremier.BuildQualityChecks.QualityChecks-task.BuildQualityChecks@6
displayName: Check branch coverage
inputs:
checkCoverage: true
coverageFailOption: fixed
coverageType: branch
# 70% minimum branch coverage
coverageThreshold: 70
condition: eq(variables['AZ_SDK_CODE_COV'], 1)
# Disabling branch coverage check until newer tasks can support it see issue https://github.com/microsoft/azure-pipelines-tasks/issues/19669 tracking that request.
# - task: BuildQualityChecks@9
# displayName: Check branch coverage
# inputs:
# checkCoverage: true
# coverageFailOption: fixed
# coverageType: branch
# # 70% minimum branch coverage
# coverageThreshold: 70
# condition: eq(variables['AZ_SDK_CODE_COV'], 1)

# Validate all the files are saved as ASCII only without a UTF-8 BOM.
- bash: |
Expand Down

0 comments on commit 48ef2f7

Please sign in to comment.