Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing mandatory certificate preconditions #2659

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Removing mandatory certificate preconditions #2659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
193f4bc
Removing certificate preconditions
RLeclair Oct 11, 2023
b9acd80
Minor fix
RLeclair Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/inc/azure/core/az_mqtt5_rpc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@
/**
* @brief The MQTT5 RPC status property name.
*/
#define AZ_MQTT5_RPC_STATUS_PROPERTY_NAME "status"
#define AZ_MQTT5_RPC_STATUS_PROPERTY_NAME "Status"
/**
* @brief The MQTT5 RPC status message property name.
*/
#define AZ_MQTT5_RPC_STATUS_MESSAGE_PROPERTY_NAME "statusMessage"
#define AZ_MQTT5_RPC_STATUS_MESSAGE_PROPERTY_NAME "StatusMessage"
/**
* @brief The MQTT5 RPC correlation id length.
*/
Expand Down
8 changes: 5 additions & 3 deletions sdk/src/azure/core/az_mqtt5_connection_hfsm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,11 @@ AZ_INLINE az_result _connect(az_mqtt5_connection* me)
_az_PRECONDITION_VALID_SPAN(me->_internal.options.client_id_buffer, 1, false);
_az_PRECONDITION_VALID_SPAN(me->_internal.options.username_buffer, 1, false);
_az_PRECONDITION_VALID_SPAN(me->_internal.options.password_buffer, 0, true);
_az_PRECONDITION_NOT_NULL(me->_internal.options.client_certificates);
_az_PRECONDITION_VALID_SPAN(me->_internal.options.client_certificates[0].cert, 1, false);
_az_PRECONDITION_VALID_SPAN(me->_internal.options.client_certificates[0].key, 1, false);
if (me->_internal.options.client_certificates != NULL)
{
_az_PRECONDITION_VALID_SPAN(me->_internal.options.client_certificates[0].cert, 1, false);
_az_PRECONDITION_VALID_SPAN(me->_internal.options.client_certificates[0].key, 1, false);
}

az_mqtt5_connect_data connect_data = (az_mqtt5_connect_data){
.host = me->_internal.options.hostname,
Expand Down