[Identity] Fixes to spawn a new instance on macOS #22195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpodwysocki
requested review from
KarishmaGhiya,
witemple-msft and
schaabs
as code owners
ghost
added
the
|
API change check API changes are not detected in this pull request. |
KarishmaGhiya
requested review from
mikeharder,
praveenkuttappan,
deyaaeldeen,
benbp,
weshaggard,
qiaozha,
dw511214992,
MaryGao,
bterlson,
xirzec,
jeremymeng,
joheredi,
dpwatrous,
paterasMSFT,
zfengms,
LarryOsterman and
HarshaNalluru
as code owners
|
the number of commits here makes me think there is a bad branch mismatch. |
3 tasks
|
Sorry folks, I was trying to rebase this against the hotfix branch, didn't work out well. Recreated the PR here against the hotfix branch - #22214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
On macOS, the default browser held open the connection, and refused to close the associated sockets unless the window was closed. This forces a spawn of a new instance.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists