Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebPubSub] Support new release 2022-11-01 #27385

Merged
merged 25 commits into from
Dec 9, 2022
Merged

Conversation

xingsy97
Copy link
Contributor

@xingsy97 xingsy97 commented Nov 9, 2022

Description

Support new release 2022-11-01

  1. Support sending with "filter" syntax
  2. Support generating access url with initial groups
  3. Add new API "removeConnectionFromAllGroups"
  4. Add patches for send_to_all, send_to_user, send_to_connection, send_to_group and their async versions. Because the new version of autorest python requires sdk manager to pre-process http request content according to different Content-Type by themselves.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@xingsy97 xingsy97 marked this pull request as ready for review November 9, 2022 10:49
@xingsy97 xingsy97 changed the title [WebPubSub] Adding new features [WebPubSub] Support new swagger 2022-11-01 Nov 9, 2022
@xingsy97 xingsy97 changed the title [WebPubSub] Support new swagger 2022-11-01 [WebPubSub] Support new swagger new release 2022-11-01 Nov 9, 2022
@xingsy97 xingsy97 changed the title [WebPubSub] Support new swagger new release 2022-11-01 [WebPubSub] Support new release 2022-11-01 Nov 9, 2022
@msyyc
Copy link
Member

msyyc commented Nov 21, 2022

@xingsy97 Which version of cmd do you use to update the SDK code?

@xingsy97
Copy link
Contributor Author

@xingsy97 Which version of cmd do you use to update the SDK code?

Hi @msyyc , I use autorest --version=3.9.2 --use=@autorest/python@6.1.11 --use=@autorest/modelerfour@4.24.3 ./swagger/README.md

@msyyc
Copy link
Member

msyyc commented Nov 23, 2022

Since @iscai-msft is on vacation, add @lmazuel @johanste to review

Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think overall it looks good, hard to tel though bc all of the functions switched order

@msyyc msyyc mentioned this pull request Dec 5, 2022
@msyyc
Copy link
Member

msyyc commented Dec 6, 2022

CI failure is not caused by this PR and it can be ignored.

@msyyc msyyc merged commit 498b036 into Azure:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants