-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebPubSub] Support new release 2022-11-01 #27385
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingsy97
changed the title
[WebPubSub] Adding new features
[WebPubSub] Support new swagger 2022-11-01
Nov 9, 2022
xingsy97
changed the title
[WebPubSub] Support new swagger 2022-11-01
[WebPubSub] Support new swagger new release 2022-11-01
Nov 9, 2022
xingsy97
changed the title
[WebPubSub] Support new swagger new release 2022-11-01
[WebPubSub] Support new release 2022-11-01
Nov 9, 2022
@xingsy97 Which version of cmd do you use to update the SDK code? |
msyyc
reviewed
Nov 21, 2022
sdk/webpubsub/azure-messaging-webpubsubservice/samples/integration_sample.py
Outdated
Show resolved
Hide resolved
msyyc
approved these changes
Nov 23, 2022
msyyc
approved these changes
Nov 23, 2022
Since @iscai-msft is on vacation, add @lmazuel @johanste to review |
iscai-msft
reviewed
Nov 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think overall it looks good, hard to tel though bc all of the functions switched order
...e-messaging-webpubsubservice/azure/messaging/webpubsubservice/aio/_operations/_operations.py
Show resolved
Hide resolved
...azure-messaging-webpubsubservice/azure/messaging/webpubsubservice/_operations/_operations.py
Outdated
Show resolved
Hide resolved
msyyc
reviewed
Dec 5, 2022
Closed
msyyc
reviewed
Dec 6, 2022
CI failure is not caused by this PR and it can be ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support new release 2022-11-01
send_to_all
,send_to_user
,send_to_connection
,send_to_group
and their async versions. Because the new version of autorest python requires sdk manager to pre-process http request content according to differentContent-Type
by themselves.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines