Clearer error if AzureName is not set (#2366)

Azure · Jun 29, 2022 · 4ff3dde · 4ff3dde
1 parent 8e99791
commit 4ff3dde
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/v2/internal/reconcilers/arm/azure_generic_arm_reconciler_instance.go b/v2/internal/reconcilers/arm/azure_generic_arm_reconciler_instance.go
@@ -296,6 +296,11 @@ func (r *azureDeploymentReconcilerInstance) MonitorDelete(ctx context.Context) (
 }
 
 func (r *azureDeploymentReconcilerInstance) BeginCreateOrUpdateResource(ctx context.Context) (ctrl.Result, error) {
+	if r.Obj.AzureName() == "" {
+		err := errors.New("AzureName was not set. A webhook should default this to .metadata.name if it was omitted. Is the ASO webhook service running?")
+		return ctrl.Result{}, conditions.NewReadyConditionImpactingError(err, conditions.ConditionSeverityError, conditions.ReasonFailed)
+	}
+
 	armResource, err := r.ConvertResourceToARMResource(ctx)
 	if err != nil {
 		return ctrl.Result{}, err