Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Microsoft.NotificationHubs #4539

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

super-harsh
Copy link
Collaborator

What this PR does

This PR adds support for Microsoft.NotificationHubs 2023-09-01. The following resources have been added:

  • Namespace
    • AuthorizationRule
    • NotificationHub
      • AuthorizationRule

Closes #3194

Checklist

  • this PR contains documentation
  • this PR contains tests
  • this PR contains YAML Samples

@super-harsh super-harsh self-assigned this Jan 27, 2025
@super-harsh super-harsh added this to the v2.12.0 milestone Jan 27, 2025
name: aso-sample-ns
properties:
rights:
- Listen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing EoLn at EoF.

Copy link
Member

@theunrepentantgeek theunrepentantgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing EoLn at EoF in the samples, but otherwise all looks great.

@super-harsh super-harsh enabled auto-merge February 3, 2025 21:00
@super-harsh super-harsh added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 905b2cd Feb 4, 2025
8 checks passed
@super-harsh super-harsh deleted the feature/notificationhubs branch February 4, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Recently Completed
Development

Successfully merging this pull request may close these issues.

Support: New resource type Microsoft.NotificationHubs
2 participants