Refactoring code to enable a common package for bicep-deploy

.github/workflows/check-dist.yml

@@ -45,11 +45,11 @@ jobs:
         id: build
         run: |
           rm -Rf dist
-          npm run package
+          npm run build
 
       # This will fail the workflow if the `dist/` directory is different than
       # expected.
-      - name: Compare Directories
+      - name: Compare dist/ Directories
         id: diff
         run: |
           if [ ! -d dist/ ]; then
@@ -71,4 +71,4 @@ jobs:
         uses: actions/upload-artifact@v5
         with:
           name: dist
-          path: dist/
+          path: dist/

.github/workflows/ci.yml

@@ -28,8 +28,20 @@ jobs:
           node-version-file: .node-version
           cache: npm
 
+      - name: Install Dependencies Common
+        id: npm-install-common
+        working-directory: ./packages/bicep-deploy-common
+        run: npm ci
+
+      - name: Build bicep-deploy-common Package
+        id: build
+        working-directory: ./packages/bicep-deploy-common
+        run: |
+          rm -Rf dist
+          npm run build
+
       - name: Install Dependencies
-        id: npm-ci
+        id: npm-install
         run: npm ci
 
       - name: Lint
@@ -77,6 +89,18 @@ jobs:
           node-version-file: .node-version
           cache: npm
 
+      - name: Install Dependencies Common
+        id: npm-install-common
+        working-directory: ./packages/bicep-deploy-common
+        run: npm ci
+
+      - name: Build bicep-deploy-common Package
+        id: build
+        working-directory: ./packages/bicep-deploy-common
+        run: |
+          rm -Rf dist
+          npm run build
+
       - name: Install Dependencies
         id: npm-ci
         run: npm ci
@@ -121,6 +145,13 @@ jobs:
         id: checkout
         uses: actions/checkout@v5
 
+      - name: Setup Node.js
+        id: setup-node
+        uses: actions/setup-node@v6
+        with:
+          node-version-file: .node-version
+          cache: npm
+
       - uses: azure/login@v2
         with:
           client-id: ${{ secrets.AZURE_CLIENT_ID }}

.github/workflows/upload-package.yml

@@ -0,0 +1,59 @@
+name: Upload bicep-deploy-common Package
+
+on: workflow_dispatch
+
+permissions:
+  contents: read
+
+jobs:
+  upload-package:
+    name: Upload bicep-deploy-common Package
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        id: checkout
+        uses: actions/checkout@v5
+
+      - name: Setup Node.js
+        id: setup-node
+        uses: actions/setup-node@v6
+        with:
+          node-version-file: .node-version
+          cache: npm
+
+      - name: Install Dependencies for bicep-deploy-common
+        id: install-common
+        working-directory: ./packages/bicep-deploy-common
+        run: npm ci
+
+      - name: Build bicep-deploy-common Package
+        id: build
+        working-directory: ./packages/bicep-deploy-common
+        run: |
+          rm -Rf dist
+          npm run build
+
+      - name: Create package tarball
+        id: pack
+        working-directory: ./packages/bicep-deploy-common
+        run: |
+          packOutput=$(npm pack --json)
+          echo "filename=$(echo $packOutput | jq -r '.[0].filename')" >> $GITHUB_OUTPUT
+          echo "version=$(echo $packOutput | jq -r '.[0].version')" >> $GITHUB_OUTPUT
+
+      # Using upload steps defined for the Partner Release Pipeline (https://aka.ms/azsdk/partner-release-pipeline)
+      # azuresdkpartnerdrops is the managed identity that we use to upload to the partner drop folder
+      - name: Login to azuresdkpartnerdrops
+        uses: azure/login@v2
+        with:
+          client-id: ${{ secrets.AZURESDKPARTNERDROPS_CLIENT_ID }}
+          tenant-id: ${{ secrets.AZURESDKPARTNERDROPS_TENANT_ID }}
+          subscription-id: ${{ secrets.AZURESDKPARTNERDROPS_SUBSCRIPTION_ID }}
+
+      # Upload bicep-deploy-common package to partner drop folder to allow external distribution under the @azure scope
+      - name: Upload files to partner drop folder
+        working-directory: ./packages/bicep-deploy-common
+        run: |
+          echo "Uploading ${{ steps.pack.outputs.filename }} to partner drop folder at drops/bicep-deploy-common/npm/${{ steps.pack.outputs.version }}..."
+          az storage blob upload -f ${{ steps.pack.outputs.filename }} -c drops/bicep-deploy-common/npm/${{ steps.pack.outputs.version }} --account-name azuresdkpartnerdrops --auth-mode login

.gitignore

@@ -1,5 +1,6 @@
 # Dependency directory
 node_modules
+packages/**/node_modules
 
 # Rest pulled from https://github.com/github/gitignore/blob/master/Node.gitignore
 # Logs
@@ -102,4 +103,7 @@ __tests__/runner/*
 *.code-workspace
 
 # build output
-/out
+/out
+
+# Ignore package dist/
+packages/bicep-deploy-common/dist/

.node-version

@@ -1 +1 @@
-22.8.0
+22.12.0

action.yml

@@ -108,4 +108,4 @@ inputs:
 
 runs:
   using: node20
-  main: dist/index.js
+  main: dist/index.cjs

eslint.config.mjs

@@ -1,31 +1,37 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-// @ts-check
+// @ts-nocheck
 import eslint from "@eslint/js";
 import tseslint from "typescript-eslint";
-import pluginJest from 'eslint-plugin-jest';
+import vitest from '@vitest/eslint-plugin';
 import notice from "eslint-plugin-notice";
 import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended';
 
-export default tseslint.config({
-  files: ["src/**/*.ts", "test/**/*.ts", "test-live/**/*.ts"],
-  extends: [
-    eslint.configs.recommended,
-    pluginJest.configs['flat/recommended'],
-    eslintPluginPrettierRecommended,
-    ...tseslint.configs.recommended,
-  ],
-  languageOptions: {
-    ecmaVersion: 2020,
-  },
-  plugins: { notice },
-  rules: {
-    "notice/notice": [
-      "error",
-      {
-        template: "// Copyright (c) Microsoft Corporation.\n// Licensed under the MIT License.\n",
-      },
-    ],
-  },
-});
+export default [
+  eslint.configs.recommended,
+  ...tseslint.configs.recommended,
+  eslintPluginPrettierRecommended,
+  {
+    files: ["src/**/*.ts", "test/**/*.ts", "test-live/**/*.ts", "packages/**/*.ts"],
+    languageOptions: {
+      ecmaVersion: 2020,
+      globals: {
+        ...vitest.environments.env.globals,
+      }
+    },
+    plugins: {
+      notice,
+      vitest
+    },
+    rules: {
+      "notice/notice": [
+        "error",
+        {
+          template: "// Copyright (c) Microsoft Corporation.\n// Licensed under the MIT License.\n",
+        },
+      ],
+      ...vitest.configs.recommended.rules,
+    },
+  }
+];