[MrBot] Add coding guidelines learnings from feature flags PR #14521373#324
Open
dcristoloveanu wants to merge 1 commit intomasterfrom
Open
[MrBot] Add coding guidelines learnings from feature flags PR #14521373#324dcristoloveanu wants to merge 1 commit intomasterfrom
dcristoloveanu wants to merge 1 commit intomasterfrom
Conversation
dcristoloveanu
force-pushed
the
dcristo/learnings-from-feature-flags-pr
branch
from
cdc1caf to
2eadba8
Compare
Member
Author
|
/azp run Azure-C-Build-Tools-Gate |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dcristoloveanu
commented
Feb 19, 2026
Added 3 learnings extracted from PR review comments: 1. .CallCannotFail() modifier rules - only use in negative tests (placed in Negative Testing section) 2. SRS requirements must be individually taggable per test 3. Exposed API section in requirements must mirror the header Also removed duplicate Struct Arguments Require IGNORED_STRUCT_ARG section (already present from master). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dcristoloveanu
force-pushed
the
dcristo/learnings-from-feature-flags-pr
branch
from
2eadba8 to
7d14cbc
Compare
Member
Author
|
/azp run Azure-C-Build-Tools-Gate |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 3 learnings extracted from PR review comments on Azure-MessagingStore PR #14521373 (feature flags implementation).
Learnings Added
1.
.CallCannotFail()Modifier RulesUse
.CallCannotFail()on expected calls ONLY in umock negative tests to exclude specific calls from failure injection. Do NOT use it in positive/happy path tests where it has no effect.2. SRS Requirements Must Be Individually Taggable
Each SRS requirement should describe a single testable behavior. Combined specs (e.g., 'returns A or B') should be split into separate specs for independent test tagging.
3. Exposed API Section Must Mirror the Header
The Exposed API section in requirements docs must contain all public enums, typedefs, and function declarations exactly as they appear in the public header file.
Session
Copilot session:
ce97c609-5e29-446e-9557-f92b318c2e8e