[MrBot] Add timed test suite validation to build_test_folder#277
Open
parth21999 wants to merge 4 commits intomasterfrom
Open
[MrBot] Add timed test suite validation to build_test_folder#277parth21999 wants to merge 4 commits intomasterfrom
parth21999 wants to merge 4 commits intomasterfrom
Conversation
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
9b86126 to
69e29f3
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
69e29f3 to
853d82e
Compare
parth21999
commented
Feb 12, 2026
parth21999
commented
Feb 12, 2026
parth21999
commented
Feb 12, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
parth21999
commented
Feb 12, 2026
parth21999
commented
Feb 12, 2026
parth21999
commented
Feb 12, 2026
parth21999
commented
Feb 12, 2026
parth21999
commented
Feb 12, 2026
parth21999
commented
Feb 12, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
parth21999
commented
Feb 12, 2026
|
|
||
| # Note: We don't add test_validate_timed_test_suite_detection as a dependency because | ||
| # it should fail with exit code 1 (which would fail the build). | ||
| # Instead, it's available to run manually to verify detection works. |
Member
Author
parth21999
commented
Feb 12, 2026
| WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} | ||
| COMMENT "Testing timed test suite validation on clean files" | ||
| ) | ||
|
|
Member
Author
There was a problem hiding this comment.
Tests should use the cmake function validate_timed_test_suite.
Add a test cases where the skip regex causes the check to be skipped.
… regex test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_timed_test_suite()CMake function that checks integration test files useTIMED_TEST_SUITE_INITIALIZE/CLEANUPmacrosbuild_test_folderwhen building integration tests (*int*) on Windows-Dtimed_test_suite_skip_regex="folder_a|folder_b"for folders that need exemptionDepends on c-build-tools PR that moves the validation script to
build_functions/validate_timed_test_suite.ps1.Test plan
cmake ... -Drun_int_tests=ONand verify validation fires automaticallycmake --build cmake --target test_validate_timed_test_suite🤖 Generated with Claude Code