Skip to content

Commit

Permalink
[Bugfix] Microphone lobby fix (#3896)
Browse files Browse the repository at this point in the history
* Allow mic to be active in the lobby screen

* Change files

* Duplicate change files for beta release

* update logic to be cleaner

* Update packages/react-composites CallComposite browser test snapshots

* Update packages/react-composites CallComposite browser test snapshots

* update comment

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
dmceachernmsft and github-actions[bot] authored Dec 11, 2023
1 parent f896d25 commit a33fb42
Show file tree
Hide file tree
Showing 15 changed files with 20 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Bug fix",
"comment": "Allow mic to be active in the lobby screen",
"packageName": "@azure/communication-react",
"email": "94866715+dmceachernmsft@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Bug fix",
"comment": "Allow mic to be active in the lobby screen",
"packageName": "@azure/communication-react",
"email": "94866715+dmceachernmsft@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,10 @@ export const Microphone = (props: {
const unmuteMicCapability = adapter.getState().call?.capabilitiesFeature?.capabilities.unmuteMic;

/**
* When call is in Lobby, microphone button should be disabled.
* When call is in connecting state, microphone button should be disabled.
* This is due to to headless limitation where a call can not be muted/unmuted in lobby.
*/
if (_isInLobbyOrConnecting(callStatus)) {
microphoneButtonProps.disabled = true;
if (callStatus === 'Connecting') {
// Lobby page should show the microphone status that was set on the local preview/configuration
// page until the user successfully joins the call.
microphoneButtonProps.checked = isLocalMicrophoneEnabled;
Expand All @@ -56,7 +55,6 @@ export const Microphone = (props: {
}
: {};
const styles = useMemo(() => concatButtonBaseStyles(props.styles ?? {}), [props.styles]);

// tab focus on MicrophoneButton on page load
return (
<MicrophoneButton
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit a33fb42

Please sign in to comment.